Repository navigation
refactor(playback): SDK-owned playback via LightAudioQueueSessions + SDK main consolidation - #3
Merged
Merged
Conversation
…essions Drop Kelp's own ExoPlayer controller and the strict Media3 1.5.0 pins in app and server. The server module now consumes the SDK client streaming API: Kelp keeps TIDAL stream resolution (playbackinfopostpaywall, BTS/clear-DASH) and the similar-tracks continuation, while the SDK media service owns the player, queue, transitions, and background lifecycle. Requires the companion SDK fork that carries LightAudioQueueSessions.
…yback v0.2.5 (55d22ca) reworked playback as a Kelp-owned KelpPlaybackService and TidalMediaSource; the sdk-owned-playback branch supersedes that with the SDK's LightAudioQueueSessions, so the merge keeps this branch's controller, resolves docs toward the SDK design, and drops KelpPlaybackService, TidalMediaSource, and their manifest declaration. Main's catalog browsing, search, action-bar, queue, and settings work merges unchanged; its 'only implemented settings' rule is kept in AGENTS.md.
…adata SDK main carries the cert override as checkCertOverride, consulted by the installed-caller filter instead of an assignable checkCert. The rebased SDK server also brings a Netty/ktor stack whose jars share META-INF indexes and version manifests, so the merged APK drops the legacy index and picks the first version manifest.
…pt-in CI was checking out the codex/kelp-official-sdk branch of the old SDK; everything Kelp needs now lives on gavdevs/light-sdk main, pinned here at 251237e. The serverPackage guard's opt-in moves from ad-hoc -D flags into gradle.properties so scripts, CI, and local builds agree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LightAudioQueueSessions: the SDK media service owns the player, queue, transitions, and background lifecycle; Kelp keeps TIDAL stream resolution and the similar-tracks continuation.origin/mainv0.2.6: v0.2.5'sKelpPlaybackService/TidalMediaSourcewas a parallel take on the same goal and is superseded; main's catalog, search, action-bar, queue, and settings work is kept.codex/kelp-official-sdktogavdevs/light-sdkmain at251237e, and the companionserverPackageopt-in moves intogradle.properties.checkCertOverrideon the server bootstrap (SDK main's hook), and Netty/ktorMETA-INFmerge dedupe for the merged APK.Verification
:protocol:test :app:testDebugUnitTest :server:testDebugUnitTest :app:assembleDebugall green, 44 unit tests, no flags.Notes
251237eexactly; Kelp and its companion SDK changes ship together.