Repository navigation
Conversation
With disagg_by_src the atomic groups of a task were computed together and all their rates were attributed to the source of the first group in mean_rates_by_src; moreover the ruptures of the other groups were not stored. Now there is a result per group, stored in the RateMap of the first group of the task. Added test_case_27_other.
With few sites the atomic groups of a task were merged in a single result, keeping only the rup_data of the first group, so the disaggregation missed the ruptures of the other groups. Now classical_bysrc returns a result per atomic group, while the classical task (many sites, no rup_data) still merges them. Moved the logic in _atomic_results to respect the function-length limit. Added test_case_27_nodbs.
The ruptures lost when several atomic groups shared a task changed the disaggregation (Mag sum .19 instead of .41), not the hazard curves, so the test is now a disaggregation test comparing the Mag and Dist outputs with expected files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And added tests.