Repository navigation
Made it possible to run multiple workerpools on the same machine - #11934
Merged
Merged
Conversation
host_cores entries can now specify a port, as in "127.0.0.1:1910 4", so that several workerpools can run on the same host. The port is passed to the workerpool with the new --ctrl-port option and defaults to ctrl_port. WorkerMaster.status() reports each pool as host:port. WorkerMaster.stop() now waits for the local workerpools to exit after sending the stop command, and terminates them only on timeout; killing them immediately leaked the semaphores of their process pool.
Replace the test that needed a running task streamer with one that starts two workerpools on localhost, checks their status, dispatches tasks to both and checks that they exit on their own after stop.
On Windows the Popen pid of a venv launcher differs from the process running the workerpool, so the test compares against getpid instead.
Parse host_cores once and pass it to ssh_args, add a _running helper for the repeated socket_ready/ctrl_url loops, and replace the bare assert in the test teardown with an explicit AssertionError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful to test the zmq cluster locally