Repository navigation
Docstring for distance measure in disaggregation - #11937
Merged
Merged
Conversation
micheles
approved these changes
Oct 19, 2026
CB-quakemodel
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
the disaggregation docstring in openquake/hazardlib/calc/disagg.py and the "Disaggregation" section of doc/underlying-science/PSHA-with-OQ-engine.rst state that ruptures are binned by Joyner-Boore distance (rjb). However, the engine actually bins by rupture distance (rrup):
oq-engine/openquake/hazardlib/calc/disagg.py
Line 243 in 11649e3
oq-engine/openquake/hazardlib/calc/disagg.py
Line 373 in 11649e3
This PR corrects both descriptions. Users rely on these docs to interpret disaggregation outputs, so the mismatch can lead to misreading the distance bins.