Repository navigation
Conversation
region_grid_spacing is mandatory in impact mode since the circulant embedding regular grid commit, but the shakemap validation path never set it, so impact_validate failed. Default it to 10 km, expose it in the impact form (label, placeholder, default, strictly positive validator) and pass it from the JS form data.
The sites of impact jobs are now a regular UTM grid around the rupture (see 9ba22b7), which changes the aggregated risk and the exposure by MMI tables. Regenerated with OQ_OVERWRITE=1 for impact1, impact3, impact4 and impact5. impact2 is left unchanged: it fails when building the grid because it straddles a UTM zone boundary.
The job.zip of an impact job has no exposure HDF5, so the reloaded job was not in impact mode and required reference_vs30_value. Associate the site parameters of the site model close to the rupture to the sites before writing sites.csv, so the reloaded job finds them there.
The grid sites of impact jobs have no parameters and req_site_params is still empty when they are associated in base.py, so vs30 was 0 at every site and the GMPEs returned garbage. Add all the site model parameters to the sitecol and to the complete sitecol before associating them. Drop the export helper, since sites.csv now carries the parameters. Regenerate the impact1, impact3 and impact4 expected values.
raoanirudh
approved these changes
Oct 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.