Repository navigation
fix: event loop handler teardown bug - #1704
Merged
jakelorocco merged 1 commit intoOct 2, 2026
Merged
Conversation
Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com> Assisted-by: CLAUDE:OPUS
planetf1
approved these changes
Oct 2, 2026
planetf1
left a comment
Contributor
There was a problem hiding this comment.
Looks good. I reproduced the __del__ warning on main (it needs something like a live daemon thread to keep the module around until shutdown wipes it) and it's gone with this change. One optional note on the test inline.
|
|
||
| monkeypatch.setattr(elh, "sys", None) | ||
| try: | ||
| # Treated as finalization: must not raise, and must not wait on the thread. |
Contributor
There was a problem hiding this comment.
Optional, fine to merge as is. Nothing here checks the "must not wait" part: I flipped the fallback to finalizing = False and this test still passed, because _event_loop is None holds either way. Wrapping handler._close_event_loop with mock.patch.object(..., wraps=...) and asserting it was called with join_timeout=0.0 would pin it. I checked that version fails on main and on the flipped fallback.
Merged
via the queue into
generative-computing:main
with commit Oct 2, 2026
4c53add
13 checks passed
gretadolcetti
pushed a commit
to gretadolcetti/mellea
that referenced
this pull request
Oct 5, 2026
Assisted-by: CLAUDE:OPUS Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com>
gretadolcetti
pushed a commit
to gretadolcetti/mellea
that referenced
this pull request
Oct 5, 2026
Assisted-by: CLAUDE:OPUS Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com>
gretadolcetti
pushed a commit
to gretadolcetti/mellea
that referenced
this pull request
Oct 5, 2026
Assisted-by: CLAUDE:OPUS Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Fixes N/A
Description
Cleans up the event loop handler teardown so that it doesn't log a warning when Python has already started tearing down module globals.
Testing
Attribution
Adding a new component, requirement, sampling strategy, or tool?
If your PR adds or modifies one of the types below, check the matching box. A checklist of type-specific review items will be posted as a comment.
NOTE: Please ensure you have an issue that has been acknowledged by a core contributor and routed you to open a pull request against this repository. Otherwise, please open an issue before continuing with this pull request.