feat: expose gas overrides for intelligent contract transactions - #111
Open
MuncleUscles wants to merge 1 commit into
Open
feat: expose gas overrides for intelligent contract transactions#111MuncleUscles wants to merge 1 commit into
MuncleUscles wants to merge 1 commit into
Conversation
Add the outer EVM gas option to write_contract and deploy_contract, align default estimation headroom with genlayer-js, and stop before broadcast when estimation fails.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delivery context
No direct cross-repository dependency. This is the Python SDK parity implementation of the same public transaction-level gas convention.
Problem and outcome
Large intelligent-contract deploy/write calldata can exceed a guessed outer EVM gas limit. The Python SDK previously offered no transaction-level override, so callers could not bypass an unreliable
eth_estimateGasresult.This PR:
gastowrite_contractanddeploy_contract;eth_estimateGas;gascontrols the outer EVMConsensusMain.addTransactioncall and is separate from GenLayerfeesbudgets.There is no protocol, consensus, or fee-accounting change.
Implementation and validation
Validation:
.venv/bin/pytest tests/unit/contracts/test_contract_actions.py -q— 45 passed..venv/bin/pytest tests/unit --ignore=tests/unit/smoke -q— 124 passed..venv/bin/python -m compileall -q genlayer_py— passed.The excluded
tests/unit/smokedirectory performs live Bradbury/Asimov RPC calls; its sandbox run failed only on blocked DNS/network access. No live transaction was broadcast for this change.Coverage includes:
BudgetTooLowerror context.Decisions, risks, and rollback
gas, matching standard EVM transaction APIs and genlayer-js.gasis deliberately outside thefeesobject because it belongs to the outer EVM envelope, not GenLayer execution/consensus budgets.