Force a 404 code for tiles out of bounds#2365
Merged
Merged
Conversation
tomkralidis
requested changes
Jun 19, 2026
| resp = session.get(f'{base_url}/{layer}/{z}/{x}/{y}{url_query}') # noqa | ||
|
|
||
| if resp.status_code == 404: | ||
| if resp.status_code == 404 or resp.status_code == 500: |
Member
There was a problem hiding this comment.
Can we update to:
if resp.status_code in [404, 500]:
tomkralidis
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Related Issue / discussion
#2364
Additional information
On the mvt-proxy provider, we are not sure what the behaviour of the upstream server is regarding tiles out of bounds; however, we need to make sure that if the tile is out of bounds we return a 404. This PR forces that behaviour on mvt-proxy, by evaluating if the 500 error was caused by requesting a tile outside the limits of the TMS. This also ensures that we pass the conformance test.
Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)