Add EuclideanDistance.unsafe, module configuration, typeclass instances for Distance, and PixelDefinition and Pixels3D tests from looptrace#29
Merged
Conversation
…D and PixelDefinition
Drop Java 11 and 19 from the CI build matrix, keeping only the LTS releases Temurin 17 and 21. Exclude the macOS + Temurin 17 combination so macOS only runs on Java 21, matching the looptrace CI setup. Java 19 (non-LTS, EOL March 2023) was the source of the SSLHandshakeException when resolving edu.ucar:cdm-core from Unidata's artifact server: its bundled cacerts predates the Sectigo Root R46 trust anchor. Java 17 and 21 already trust that root, so no truststore workaround is needed. Also bump primaryJavaVersion to 21 so the scalafmt/scalafix checks run on the new primary JVM, and add .DS_Store to .gitignore.
Correct EuclideanDistance.unsafe scaladoc to state it interprets (not "tries to interpret") a length and throws IllegalArgumentException on a negative value, matching its actual behavior. Document that the Show[Distance] format is chosen to roundtrip through Distance.parse via squants' Length parser. Remove a stray blank line and add a trailing newline in .gitignore.
Member
Code Review — Approving ✅Reviewed the full diff for #29. Solid, well-tested work — clean typeclass usage, good coverage, and consistent propagation of the error-message change. What this PR delivers
Strengths
Should-fix / worth confirming
Nits
Questions
Follow-up fixes applied after review
Verification
Good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
CHANGELOGupdateSNAPSHOT)Updated base feature branch from #28