fix(app): prevent composer history update loops - #1669
Draft
Flame119052 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Opening a bb thread could fail with React error #185 (
Maximum update depth exceeded). The production stack pointed toPromptBoxInternal's history reset effect andresetHistorySession.Root cause
Callers may recreate an empty
historyobject while React is processing overlapping transition and synchronous updates. Each effect pass unconditionally dispatched threenullstate updates. With another update lane already pending, React could not always take its eager same-value bailout, so the redundant passive-effect commit could feed another render and eventually hit the nested update limit.The reset now uses a ref as the accepted session-transition marker. History recall marks the session active before state dispatch. Reset marks it inactive before dispatching its three clears, so re-entrant effects cannot enqueue the same reset twice.
User impact
Thread composers no longer risk blanking the route with React #185 when empty history props are recreated during concurrent rendering. Normal history recall and reset behavior is preserved.
Regression coverage
The regression combines
startTransitionwithflushSyncwhile recreating an empty history object. It fails on the original implementation with six commits and passes with the bounded five-commit sequence after the fix.Validation
pnpm --dir apps/app exec vitest run --config vitest.config.ts src/components/promptbox/PromptBoxInternal.test.tsx— 98 passedpnpm exec prettier --check apps/app/src/components/promptbox/PromptBoxInternal.tsx apps/app/src/components/promptbox/PromptBoxInternal.test.tsx— passedpnpm exec eslint apps/app/src/components/promptbox/PromptBoxInternal.tsx apps/app/src/components/promptbox/PromptBoxInternal.test.tsx— passedpnpm exec turbo run typecheck --filter=@bb/app --force— passedpnpm exec turbo run build --filter=@bb/app --force— passed