Fix squished diff toolbar in narrow panels - #1733
Conversation
|
🚨 SLOP COP 🚨 · I am SlopCop. I am reviewing this pull request for security, code quality, performance, architecture, and compact-screen behavior. |
a8c9d1f to
d6c6919
Compare
There was a problem hiding this comment.
🚨 SLOP COP 🚨 · review
Plain-English summary
This change lets the Git diff toolbar move controls onto more rows when the panel becomes narrow. Wide panels keep one row.
Findings
I found no actionable security, quality, architecture, duplication, or performance problems.
The final commit uses the toolbar width directly. It does not copy viewport rules into its callers.
Validation
- Three agents reviewed security, code quality, architecture, duplication, and performance.
- A GPT-5.6 final review gate returned APPROVE.
- The focused toolbar test passed.
- The app type check passed.
- The diff check passed.
- Browser checks passed at 320 and 760 pixels. All controls stayed inside the viewport.
- The full app lint did not finish within eight minutes. It produced no result.
The author changed the head during review. I repeated the focused checks against d6c691958e8bbc907b7753d3a1fff74a0f732be4.
|
CI follow-up: workflow run 32077636826 was allowed to finish, then its failed integration job was rerun. Attempt 1 failed in This is unrelated integration infrastructure flakiness: this PR changes only |
|
Final CI follow-up: current head |
|
CI note for current head This PR still changes only the diff toolbar and its component test. The immediately preceding head passed the complete integration job in run 32078805247, further confirming nondeterministic infrastructure flakiness. No plugin-host or integration code was changed here. |
|
Current head |
Summary
Root cause
The toolbar switched layouts only when the entire app entered its compact drawer. A resizable right panel on a 900px-wide page could therefore remain in the inline layout at just 257px wide, shrinking the selector to 0px and truncating the large-change tally. The revised flex policy wraps intrinsically from the toolbar's own width.
Validation
pnpm exec turbo run test --filter=@bb/app --force -- src/components/secondary-panel/ThreadSecondaryPanel.test.ts src/components/secondary-panel/ThreadSecondaryPanel.collapseControl.test.tsx(17 tests)pnpm exec turbo run typecheck --filter=@bb/apppnpm exec turbo run lint --filter=@bb/app --force(no errors)Closes #1652
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.