Repository navigation
ci(release): read description from Cargo.toml instead of hardcoding it - #199
Merged
Merged
Conversation
…coding it CodeRabbit flagged this on #198: release.yml hardcoded the pre-rewrite description in both the Homebrew formula and Scoop manifest generation steps, so v1.3.0 would have shipped stale package-manager metadata even though Cargo.toml's description was just updated. Extract it at runtime instead so the two can't drift apart again. update-homebrew had no checkout step at all (it only clones the separate homebrew-agentflare repo) -- added one so Cargo.toml is actually available to read.
getappz
enabled auto-merge
July 15, 2026 15:06
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release workflow now checks out the repository for Homebrew generation and sources both Homebrew and Scoop manifest descriptions from ChangesRelease manifest generation
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update-homebrewhad no checkout step at all (it only clones the separatehomebrew-agentflarerepo) -- added one so Cargo.toml is actually readable there.Test plan
grep -m1 '^description = ' Cargo.toml | cut -d'"' -f2) against the real Cargo.toml locally -- produces the correct stringSummary by CodeRabbit