Repository navigation
fix(ci): release.yml if: condition referencing secrets is invalid, breaks entire pipeline - #200
Merged
Merged
Conversation
…valid GitHub Actions doesn't allow the secrets context directly in an if: conditional (job or step level) -- it produces 'Unrecognized named-value: secrets', which GitHub surfaces by treating the whole workflow as unparseable: falls back to the file path as the run name instead of the declared 'name: release', and creates an instant-failure stub run on every single push regardless of the on: tags filter. This has been silently broken since whenever 'if: secrets.PPA_GPG_KEY != \' landed after v1.2.0 shipped -- confirmed by diffing this file against the last tag (v1.2.0) that produced a real, correctly-named 'release' run. Fix: map the secret to a job-scoped env var first, then condition on that instead, per GitHub's documented workaround.
getappz
enabled auto-merge
July 15, 2026 15:16
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release workflow’s PPA dispatch step now exposes the signing key through its environment and evaluates that environment variable before running, while retaining the GitHub token export. ChangesRelease workflow
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is why pushing the v1.3.0 tag didn't trigger a release build at all.
release.yml'strigger-ppa-publishjob hasif: secrets.PPA_GPG_KEY != ''-- GitHub Actions does not allow thesecretscontext directly in anif:conditional (job or step level). It producesUnrecognized named-value: 'secrets', and GitHub responds by treating the entire workflow file as unparseable:.github/workflows/release.yml) as the run name instead of the declaredname: releaseon: push: tags: ["v*"]filterv1.3.0produced zero workflow runs across the whole repo)Confirmed via
git diff v1.2.0 HEAD -- .github/workflows/release.yml: thisif:condition is the only non-cosmetic change since the last tag (v1.2.0) that produced a correctly-namedreleaserun. It's been silently broken since whatever PR introduced it, landing on master, and nobody had tried cutting a tag-triggered release since -- until now, when I hit it directly.Fix
Map the secret to a job-scoped env var first, then condition on that, per GitHub's documented workaround:
Test plan
Summary by CodeRabbit