Repository navigation
test(agentflare-shim): cover in_scoped_project's home-boundary walk-up - #280
Merged
Merged
Conversation
Non-trivial branching logic (project-marker walk-up, stopping at home so ~/.agentflare's own dir never false-positives as a project marker -- a real bug already found once on the bash-function prototype of this same idea) shipped with zero test coverage.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdded filesystem-based unit tests for ChangesScoped project detection
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Agentflare-Agent: claude-code_2-1-215_agent Agentflare-Branch: test/agentflare-shim-home-boundary-coverage
getappz
added a commit
that referenced
this pull request
Jul 20, 2026
Agentflare-Agent: claude-code_2-1-215_agent Agentflare-Branch: item-185-asset-store-migration
5 tasks done
5 tasks done
This was referenced Sep 17, 2026
getappz
added a commit
that referenced
this pull request
Sep 18, 2026
## Status Added a `BROWSER` rule constant to `src/rule_text.rs` (mirroring `EXA`/`FLARE_DOCS`'s terse `@tag` style — `@use`, `@commands`, `@scope`, `@how`) covering the `agentflare browser` CLI, and added it to `rule_text::all()`. Since `codex`, `cursor`, `windsurf`, `vscode-copilot`, and `cline` all get their rule files from `rule_targets()` joining `all()` (`src/components.rs`), this fixes the gap for all five without per-host wiring — same pattern item #280 already validated for `FLARE_DOCS`. Added a test, `browser_rule_is_included_in_joined_hosts`, mirroring the existing `flare_docs_rule_is_included_in_joined_hosts` test. Scope note: `claude-code`/`opencode` weren't touched — they list explicit per-file rule constants rather than using `all()`, and both already have direct MCP access to the browser tool, so they weren't part of the reported gap. Verification (all synchronous, in foreground): - `cargo build --lib` — success (had to bypass the `sccache` rustc-wrapper, which was failing with spurious "Read-only file system" errors on `.d` file writes in this worktree — unrelated to my change, a pre-existing environment issue with the sccache wrapper/shim, not the code) - `cargo test --bin agentflare -- components::` — 43 passed, 0 failed, including the new test - `cargo fmt --check` — clean Concern: the `sccache` build issue is worth flagging separately — plain `cargo build`/`cargo test` fail in this worktree unless `rustc-wrapper` is disabled. Not caused by this change, but it'll bite the next build here too. Agentflare-Branch: task/285-add-a-browser-automation-rule-to-rule-te Agentflare-Item: 285 Co-authored-by: shiva <shiva@gosysinfo.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports test coverage from the closed/superseded PR #278 (feat/lean-ctx-winshim-227) — the feature itself landed via #279 with a different implementation, but these 4 unit tests for
in_scoped_project's home-boundary walk-up were never carried over. Cherry-picked from 3315c3e.Summary by CodeRabbit