Repository navigation
fix(worktree): retry pre-branch git fetch once, log real failure reason - #528
Conversation
…ailure reason Fetching origin's target branch before branching a new task branch off it silently swallowed the actual git error and fell back to the (possibly stale) local ref on any failure. This caused a real incident: item #495 (issue #483) branched off a stale local master because a transient fetch failure went unlogged, missing an already-merged fix for the very issue it was meant to work on. Adds a single retry with a short fixed delay, and logs the real stderr/ error on the fallback path instead of a generic message. Agentflare-Agent: claude-code_2-1-233_agent Agentflare-Branch: task/496-worktree-log-real-git-error-on-fetch-fal Agentflare-Item: 496
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 59 minutes Limit details: You’ve used all 1 included review currently available under your plan. You completed 68 included PR reviews in the past 7 days; at that activity level, included reviews refill at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Comment |
…og-real-git-error-on-fetch-fal Agentflare-Agent: 1 Agentflare-Branch: task/496-worktree-log-real-git-error-on-fetch-fal Agentflare-Item: 496
…og-real-git-error-on-fetch-fal Agentflare-Agent: 1 Agentflare-Branch: task/496-worktree-log-real-git-error-on-fetch-fal Agentflare-Item: 496
Summary
create_worktree's pre-branchgit fetch origin <target_branch>swallowed the actual git error on failure and fell back to a possibly-stale local ref, logging only a generic message.master, missing an already-merged fix (PR fix(git-shim): scope-check subprocess crash denies legit push (issue #483 bug #2) #513) for the very issue it was dispatched to work on -- only discovered by manually diffing branch bases after the fact.fetch_with_retry: one retry with a 2s fixed delay before giving up, and logs the real stderr/error on the fallback path.Test plan
cargo build -p flare-git-corecargo test -p flare-git-core --lib worktree-- 61 passed (2 new: retry-then-succeed, retry-then-still-fails)cargo clippy -p flare-git-core --lib -- -A unsafe_code -A clippy::pedantic -D warnings-- clean