Skip to content

fix: Systematic-debugging enforcement gate (go/no-go) - #652

Merged
getappz merged 1 commit into
masterfrom
task/203-systematic-debugging-enforcement-gate-go
Sep 2, 2026
Merged

getappz merged 1 commit into
masterfrom
task/203-systematic-debugging-enforcement-gate-go

Conversation

@getappz

@getappz getappz commented Sep 2, 2026 •

Copy link
Copy Markdown
Owner

Design-spec for the systematic-debugging enforcement gate (item #168's greenlit candidate), authored in-session per PM-mode convention -- no code change. Mirrors the shipped verification-evidence gate (#169/PR #581): same SessionRecord/PostToolUse capture pattern, new DiagnosisEvidence tracking investigative git commands, gated behind metadata.task_type == "bugfix" via a backend DB lookup precedented by hook.rs's session_start_message. Full doc: crates/skill-registry/SYSTEMATIC_DEBUGGING_GATE_DESIGN.md. Implementation will be dispatched as a separate item per this project's design-spec-authorship convention.


Opened by claude-code on flared:51bb8de6c33b for item #203 via agentflare.

Summary by CodeRabbit

  • Documentation
    • Added a design specification for a systematic-debugging completion gate.
    • Documents requirements for recording diagnostic evidence and verification evidence before completing bug-fix work.
    • Covers evidence preservation during changes, diagnostic command detection, task-type handling, and planned testing.
    • Clarifies scenarios that remain out of scope, including non-bug-fix work and retrospective history scans.

…t gate

Item #203 (decided GO 2026-08-29, from item #168's superpowers-adoption gap
analysis). Mirrors the shipped verification-evidence gate (#169/PR #581):
same SessionRecord/PostToolUse capture pattern, new DiagnosisEvidence
tracking investigative git commands (log/blame/diff/show), gated in
completion_gate_reason behind metadata.task_type == "bugfix" via a backend
DB lookup precedented by hook.rs's session_start_message. No code change --
design-spec authorship happens in-session per this project's PM-mode
convention; implementation is dispatched as a separate item.

Agentflare-Agent: claude-code
Agentflare-Branch: task/203-systematic-debugging-enforcement-gate-go
Agentflare-Item: 203
Agentflare-Session: 895cd1c8-38c4-4ef3-a6c3-9b3149deb489
@getappz
getappz merged commit 3603f0e into master Sep 2, 2026
1 of 16 checks passed
@getappz
getappz deleted the task/203-systematic-debugging-enforcement-gate-go branch September 2, 2026 14:20
@coderabbitai

coderabbitai Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Essentials

Run ID: c5b96c31-ea37-4573-8fe3-b144366268a2

📥 Commits

Reviewing files that changed from the base of the PR and between faa6e09 and 2e4d529.

📒 Files selected for processing (1)
  • crates/skill-registry/SYSTEMATIC_DEBUGGING_GATE_DESIGN.md

📝 Walkthrough

Walkthrough

The pull request adds a design specification for bugfix-specific systematic-debugging enforcement. It defines diagnosis evidence detection, session storage, hook capture, task-type lookup, completion-gate integration, fail-open behavior, tests, and explicit scope exclusions.

Changes

Systematic debugging gate

Layer / File(s) Summary
Gate scope and detection rules
crates/skill-registry/SYSTEMATIC_DEBUGGING_GATE_DESIGN.md
The design limits diagnosis enforcement to bugfix items and selects investigative Git commands for diagnosis detection.
Diagnosis evidence storage and capture
crates/skill-registry/SYSTEMATIC_DEBUGGING_GATE_DESIGN.md
The specification adds DiagnosisEvidence, session diagnosis state, freshness rules, mutation retention, and PostToolUse capture.
Completion integration and validation
crates/skill-registry/SYSTEMATIC_DEBUGGING_GATE_DESIGN.md
The design extends completion gating, resolves task type in pre_tool_use, fails open on lookup errors, and defines tests and scope exclusions.

Estimated code review effort: 1 (Trivial) | ~3 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch task/203-systematic-debugging-enforcement-gate-go

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant