Skip to content

fix(work_item_pipeline): reinstate anti-backgrounding instruction in build_implementer_prompt (item #71 regression) - #657

Merged
getappz merged 2 commits into
masterfrom
task/214-fix-work-item-pipeline-reinstate-anti-ba
Sep 8, 2026
Merged

getappz merged 2 commits into
masterfrom
task/214-fix-work-item-pipeline-reinstate-anti-ba

Conversation

@getappz

@getappz getappz commented Sep 8, 2026

Copy link
Copy Markdown
Owner

All 90 work_item_pipeline tests pass (2 pre-existing ignores unrelated to this change). Working tree is clean, so nothing left to commit.

Status: Item #71/PR #438's fix was dropped when the SDD loop (#498) introduced its own per-role prompt builders in work_item_pipeline.rs, replacing the old single build_prompt. I found the fix already reinstated in this branch's checkpoint commits (8aca3bf, b2f6145): a shared RESUME_VERIFICATION_NOTE constant in src/work_item_pipeline/prompt_builders.rs, applied to every role that can run its own build/test/lint commands — implementer, review analyst, task reviewer, review-of-analysis, and re-reviewer — with the judge excluded since it only emits a JSON decision. The wording is updated for the SDD loop's resume capability: it explicitly says a fix round may resume the conversation, but each round is still a separate process, so a backgrounded verification command is still lost.

Tests: cargo check --lib clean; targeted backgrounding_verification tests (5/5 pass) plus the full work_item_pipeline:: suite (90 passed, 2 pre-existing ignores unrelated to this change, 0 failed).

Concerns: None — the diff was already committed and verified; my role here was confirmation, not new implementation. Working tree is clean, no further action pending.


Opened by claude-code on flared:51bb8de6c33b for item #214 via agentflare.

shiva added 2 commits September 8, 2026 12:17
Agentflare-Branch: task/214-fix-work-item-pipeline-reinstate-anti-ba
Agentflare-Item: 214-fix-work-item-pipeline-reinstate-anti-ba
Agentflare-Branch: task/214-fix-work-item-pipeline-reinstate-anti-ba
Agentflare-Item: 214-fix-work-item-pipeline-reinstate-anti-ba
@getappz

getappz commented Sep 8, 2026

Copy link
Copy Markdown
Owner Author

Tracking this PR for automated review (flared:51bb8de6c33b).

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: e35a69f3-4e60-44da-ad12-14cffd63fc92


Comment @coderabbitai help to get the list of available commands.

@getappz
getappz merged commit 81629fc into master Sep 8, 2026
2 of 16 checks passed
@getappz
getappz deleted the task/214-fix-work-item-pipeline-reinstate-anti-ba branch September 8, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant