Repository navigation
test: Test suite leaks real Telegram notifications via unmocked vault secret lookup - #758
Merged
getappz merged 1 commit intoSep 17, 2026
Conversation
… via test-only notify_disabled() circuit breaker (blocks unless AGENTFLARE_TEST_ALLOW_NOTIFY=1); verified 78 supervisor + 75 mcp_server::item + 14 quota::decide tests pass, build/clippy clean; correctly found quota::decide gated-lifecycle tests don't reach the gate (no fix needed there). Awaiting commit. Task 0: REVIEW_APPROVED — Telegram notify leak fix verified independently (guard coverage, test counts, clean build); ready to commit. Agentflare-Branch: task/274-test-suite-leaks-real-telegram-notificat Agentflare-Item: 274
|
Warning Review limit reachedNext included review available in 1 minute. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Your 51 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Comment |
getappz
deleted the
task/274-test-suite-leaks-real-telegram-notificat
branch
September 17, 2026 09:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 0: Fixed real Telegram notification leak in supervisor/notify.rs via test-only notify_disabled() circuit breaker (blocks unless AGENTFLARE_TEST_ALLOW_NOTIFY=1); verified 78 supervisor + 75 mcp_server::item + 14 quota::decide tests pass, build/clippy clean; correctly found quota::decide gated-lifecycle tests don't reach the gate (no fix needed there). Awaiting commit.
Task 0: REVIEW_APPROVED — Telegram notify leak fix verified independently (guard coverage, test counts, clean build); ready to commit.
Opened by
claude-codeon flared:51bb8de6c33b for item #274 via agentflare.