Skip to content

chore: agentflare browser CLI prints "installing via mise" on every call, even when already cached - #765

Merged
getappz merged 2 commits into
masterfrom
task/278-agentflare-browser-cli-prints-installing
Sep 17, 2026
Merged

getappz merged 2 commits into
masterfrom
task/278-agentflare-browser-cli-prints-installing

Conversation

@getappz

@getappz getappz commented Sep 17, 2026

Copy link
Copy Markdown
Owner

Same story — pre-existing clippy debt in unrelated crates, not in browser_install.rs/browser.rs. Skipping full-workspace clippy (this is a -D warnings gate across the whole codebase that fails regardless of this task). Build and the relevant unit tests are what matter here, and both pass.

Status

The fix was already implemented in a prior checkpoint commit on this branch (f52e6f6, "wip(sdd-loop): task 0 checkpoint") before I started. I verified rather than re-did it:

  • browser_install.rs gained pub fn needs_install(), which checks both find_backend() (PATH scan) and cached_backend() (the JSON cache file ensure_agent_browser actually relies on).
  • cli/browser.rs:225 now gates the "installing via mise…" print on crate::browser_install::needs_install() instead of the bare flare_browser::find_backend().is_err().

This matches the task exactly: the print will no longer fire on every call once a mise-backed install exists in the cache.

Verification (foreground, synchronous):

  • cargo build --lib --bin agentflare — succeeds (only pre-existing unsafe lint warnings elsewhere).
  • cargo test --bin agentflare browser_install:: — 5/5 tests pass, including the pre-existing ensure_respects_disabled_auto_install_when_backend_absent and cache-related tests.
  • cargo clippy -D warnings (both --bin agentflare --lib and -p agentflare) fails, but only on pre-existing issues in unrelated crates (agent-registry, agentflare-resource-gate) not touched by this branch's diff vs master — confirmed via git diff master --stat, which shows only src/browser_install.rs, src/cli/browser.rs, and an unrelated doc file changed.

No code changes were needed from me this round. No concerns beyond the pre-existing, out-of-scope clippy debt noted above.


Opened by claude-code on flared:51bb8de6c33b for item #278 via agentflare.

Agentflare-Branch: task/278-agentflare-browser-cli-prints-installing
Agentflare-Item: 278
@coderabbitai

coderabbitai Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 18 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 56 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Essentials

Run ID: 78ae0af7-4f48-49bf-9bc1-bb8b0f3157e2

📥 Commits

Reviewing files that changed from the base of the PR and between 362286e and ea4f6f8.

📒 Files selected for processing (2)
  • src/browser_install.rs
  • src/cli/browser.rs

Comment @coderabbitai help to get the list of available commands.

@getappz
getappz merged commit 0420ec0 into master Sep 17, 2026
16 checks passed
@getappz
getappz deleted the task/278-agentflare-browser-cli-prints-installing branch September 17, 2026 15:35
getappz added a commit that referenced this pull request Oct 21, 2026
…ge and doc comment (#765)

clippy's double_must_use rejected the attribute: Registration is already
#[must_use], so the builder inherits it. Also joins the split eprintln!
message with a line continuation instead of an 18-space gap, and reflows
the last_agent_for_item doc comment.

Agentflare-Agent: claude-code_2-1-305_agent
Agentflare-Branch: task/765-supervisor-repair-fallback-should-use-th
Agentflare-Item: 765
Agentflare-Session: b39fb7c8-e549-4da4-9407-4c3a3392da34
getappz added a commit that referenced this pull request Oct 21, 2026
…765) (#940)

* fix: supervisor: persist the effective execution agent so repair targets the agent that ran the work (#765)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Agentflare-Agent: claude-code
Agentflare-Branch: task/765-supervisor-repair-fallback-should-use-th
Agentflare-Item: 765
Agentflare-Session: a7614f3b-ff30-4e5c-b80d-dfc51b946b70

* fix: supervisor: route effective-agent recording through settle_execution_agent, test it end to end (#765)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Agentflare-Agent: claude-code
Agentflare-Branch: task/765-supervisor-repair-fallback-should-use-th
Agentflare-Item: 765
Agentflare-Session: a7614f3b-ff30-4e5c-b80d-dfc51b946b70

* fix: jobs: drop redundant must_use on with_agent_sink; tidy log message and doc comment (#765)

clippy's double_must_use rejected the attribute: Registration is already
#[must_use], so the builder inherits it. Also joins the split eprintln!
message with a line continuation instead of an 18-space gap, and reflows
the last_agent_for_item doc comment.

Agentflare-Agent: claude-code_2-1-305_agent
Agentflare-Branch: task/765-supervisor-repair-fallback-should-use-th
Agentflare-Item: 765
Agentflare-Session: b39fb7c8-e549-4da4-9407-4c3a3392da34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant