Repository navigation
chore: agentflare browser CLI prints "installing via mise" on every call, even when already cached - #765
Merged
getappz merged 2 commits intoSep 17, 2026
Conversation
Agentflare-Branch: task/278-agentflare-browser-cli-prints-installing Agentflare-Item: 278
|
Warning Review limit reachedNext included review available in 18 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Your 56 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (2)
Comment |
getappz
deleted the
task/278-agentflare-browser-cli-prints-installing
branch
September 17, 2026 15:35
getappz
added a commit
that referenced
this pull request
Oct 21, 2026
…ge and doc comment (#765) clippy's double_must_use rejected the attribute: Registration is already #[must_use], so the builder inherits it. Also joins the split eprintln! message with a line continuation instead of an 18-space gap, and reflows the last_agent_for_item doc comment. Agentflare-Agent: claude-code_2-1-305_agent Agentflare-Branch: task/765-supervisor-repair-fallback-should-use-th Agentflare-Item: 765 Agentflare-Session: b39fb7c8-e549-4da4-9407-4c3a3392da34
getappz
added a commit
that referenced
this pull request
Oct 21, 2026
…765) (#940) * fix: supervisor: persist the effective execution agent so repair targets the agent that ran the work (#765) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Agentflare-Agent: claude-code Agentflare-Branch: task/765-supervisor-repair-fallback-should-use-th Agentflare-Item: 765 Agentflare-Session: a7614f3b-ff30-4e5c-b80d-dfc51b946b70 * fix: supervisor: route effective-agent recording through settle_execution_agent, test it end to end (#765) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Agentflare-Agent: claude-code Agentflare-Branch: task/765-supervisor-repair-fallback-should-use-th Agentflare-Item: 765 Agentflare-Session: a7614f3b-ff30-4e5c-b80d-dfc51b946b70 * fix: jobs: drop redundant must_use on with_agent_sink; tidy log message and doc comment (#765) clippy's double_must_use rejected the attribute: Registration is already #[must_use], so the builder inherits it. Also joins the split eprintln! message with a line continuation instead of an 18-space gap, and reflows the last_agent_for_item doc comment. Agentflare-Agent: claude-code_2-1-305_agent Agentflare-Branch: task/765-supervisor-repair-fallback-should-use-th Agentflare-Item: 765 Agentflare-Session: b39fb7c8-e549-4da4-9407-4c3a3392da34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same story — pre-existing clippy debt in unrelated crates, not in browser_install.rs/browser.rs. Skipping full-workspace clippy (this is a
-D warningsgate across the whole codebase that fails regardless of this task). Build and the relevant unit tests are what matter here, and both pass.Status
The fix was already implemented in a prior checkpoint commit on this branch (
f52e6f6, "wip(sdd-loop): task 0 checkpoint") before I started. I verified rather than re-did it:browser_install.rsgainedpub fn needs_install(), which checks bothfind_backend()(PATH scan) andcached_backend()(the JSON cache fileensure_agent_browseractually relies on).cli/browser.rs:225now gates the "installing via mise…" print oncrate::browser_install::needs_install()instead of the bareflare_browser::find_backend().is_err().This matches the task exactly: the print will no longer fire on every call once a mise-backed install exists in the cache.
Verification (foreground, synchronous):
cargo build --lib --bin agentflare— succeeds (only pre-existingunsafelint warnings elsewhere).cargo test --bin agentflare browser_install::— 5/5 tests pass, including the pre-existingensure_respects_disabled_auto_install_when_backend_absentand cache-related tests.cargo clippy -D warnings(both--bin agentflare --liband-p agentflare) fails, but only on pre-existing issues in unrelated crates (agent-registry,agentflare-resource-gate) not touched by this branch's diff vsmaster— confirmed viagit diff master --stat, which shows onlysrc/browser_install.rs,src/cli/browser.rs, and an unrelated doc file changed.No code changes were needed from me this round. No concerns beyond the pre-existing, out-of-scope clippy debt noted above.
Opened by
claude-codeon flared:51bb8de6c33b for item #278 via agentflare.