Repository navigation
fix: agentflare update never verifies the swap either: same stale-install bug as dev-install, unfixed on the twin path - #795
Merged
getappz merged 1 commit intoSep 22, 2026
Conversation
…nstall (item 627) verify_installed/digest moved from dev_install::run into the shared update::swap module so agentflare update's self-upgrade path calls the same byte-level check dev-install already runs after replace_binary (item 624) instead of trusting SwapOutcome::Installed on its own. Agentflare-Agent: claude-code Agentflare-Branch: task/627-agentflare-update-never-verifies-the-swa Agentflare-Item: 627 Agentflare-Session: f0fc45e8-94ad-4f09-b663-89b425da180d
|
Warning Review limit reachedNext included review available in 18 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 60 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: getappz/agentflare/.coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (3)
Comment |
getappz
deleted the
task/627-agentflare-update-never-verifies-the-swa
branch
September 22, 2026 07:28
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: no new work needed — this task was already resolved, but by a different PR.
What I found: The fix was already implemented on this branch (commit
215620c) exactly per the ask —verify_installed/digestmoved fromdev_install/mod.rsintoswap.rs,update::runnow callsswap::verify_installedafterOk(SwapOutcome::Installed), with a regression test mirroringdev_install's.cargo fmt --checkpasses clean.But: this branch's PR (#794) was opened and then closed minutes later by the bot as a duplicate of PR #792 (
fix/update-verify-swap), which implements the same fix plus the "nice-to-have" dedupe (collapses the twoSwapOutcomematch blocks into a sharedinstall_verified/InstallOutcomehelper) — the more complete version item 627 asked for. #792 is still open, CI is green, and CodeRabbit flagged one outstanding risk there (a recovery message that could be wrong on verification failure after a successful swap) that still needs a push.Concern / recommendation: Opening another new PR from this worktree would just create a second duplicate. The live thread to watch is #792 — it needs that CodeRabbit finding addressed before merge. I did not touch #792 or push anything further from here; let me know if you want me to go fix that finding on
fix/update-verify-swapinstead.Opened by
claude-codeon flared:c997d745ae66 for item #627 via agentflare.