Repository navigation
fix(supervisor): stop re-dispatching items whose PR merged; keep review repair for unresolved findings - #875
Merged
Conversation
Agentflare-Branch: task/698-supervisor-re-dispatches-items-whose-pr Agentflare-Item: 698
Agentflare-Branch: task/698-supervisor-re-dispatches-items-whose-pr Agentflare-Item: 698
…r armed auto-merge, re-dispatch after a dead repair job Review fixes on the item 698 branch: look up merged/merging PR state for dead claims before taking the backend DB lock; restore the in-flight guard so a dispatched round whose job died goes back out; skip repair only for a merged PR (armed auto-merge no longer strands unresolved findings); cover the started-state promotion with a test. Agentflare-Agent: claude-code_2-1-289_agent Agentflare-Branch: task/698-supervisor-re-dispatches-items-whose-pr Agentflare-Item: 698 Agentflare-Session: c30b84bf-e38e-4eaa-bf9c-c726700b4982
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 37 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 65 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (12)
Comment |
Owner
Author
|
Tracking this PR for automated review ( |
Agentflare-Agent: claude-code_2-1-289_agent Agentflare-Branch: task/698-supervisor-re-dispatches-items-whose-pr Agentflare-Item: 698 Agentflare-Session: c30b84bf-e38e-4eaa-bf9c-c726700b4982
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agentflare item 698 (not GitHub PR/issue 698).
The supervisor kept working items after their PR had shipped (observed on items 687, 695, 696: roughly 10 wasted jobs).
Changes
claim_liveness.rs): before re-arming a released item, look at its PR. A merged PR (or one with auto-merge armed) is not re-dispatched; a merged one is promoted throughpromote_merged_item. The PR lookup happens before the backend DB lock is taken (confirmed_dead_items), never inside it.promote_verified_merged_itemcancels the item's queued/running jobs, so a job queued before the merge no longer runs after it.promote_in_review_to_completed_if_pralso completes astarteditem, but only on the verified-merged path and only for the PR that was checked. The unconditional promote stays in_review-only.Deliberately not changed
merge_or_repair_findingsdisarms it and repairs, so a PR with real unresolved findings is never left with nobody working on it and never merged untouched (item 628).Tests
promote_if_pr_completes_a_started_item_but_only_on_the_verified_prunresolved_thread_dispatched_this_round_waits_while_its_job_still_runsunresolved_thread_dispatched_this_round_goes_back_out_once_its_job_is_gonearmed_auto_merge_with_green_checks_still_repairs_unresolved_findingsclaim_liveness_tests.rsLocal: fmt clean, clippy (
-D warnings -A unsafe_code -A clippy::pedantic --all-targets) clean, 290 supervisor/claim/item tests and 6 backend promote tests pass.Follow-up: cancelled CI run on adc9355 (2026-10-06)
The Actions API lookup using the full head SHA
adc9355847d1e98fcfe79bb0cca6f1997d1586defoundcirun 37353686716, created 2026-10-05 18:08:22 UTC and completedcancelledat 18:21:39 UTC. The same head had successful security checks, but no required build/clippy/fmt contexts in the PR rollup. This is a cancelled or superseded CI run, not a never-triggered run; the available record does not identify what cancelled it. The later empty commit (86402353) produced the required checks.