Skip to content

chore: run_review_sweep gather phase: one project's lookup error aborts the sweep for every project - #901

Merged
getappz merged 3 commits into
masterfrom
task/361-run-review-sweep-gather-phase-one-projec
Oct 14, 2026
Merged

getappz merged 3 commits into
masterfrom
task/361-run-review-sweep-gather-phase-one-projec

Conversation

@getappz

@getappz getappz commented Oct 13, 2026 •

Copy link
Copy Markdown
Owner

Fixes #357: a failing per-project lookup in the review sweep gather is logged and that project skipped, instead of aborting the sweep for all projects. Adds regression test.


Opened by claude-code on i-flare-51bb8de6c33b (flared:51bb8de6c33b) for item #361 via agentflare.

Summary by CodeRabbit

  • Bug Fixes
    • A project’s review-batch lookup failure no longer prevents other projects from being included in the review sweep. Projects with lookup failures are skipped individually.

…iew sweep for every project (#357)

Agentflare-Agent: claude-code
Agentflare-Branch: task/361-run-review-sweep-gather-phase-one-projec
Agentflare-Item: 361
Agentflare-Session: c1c849f2-d21a-4001-9d36-b5d4a2976cf5
@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
  • Configuration used: Repository: getappz/agentflare/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 590fe6b2-7883-4192-a1fa-554cadb55395
📥 Commits

Reviewing files that changed from the base of the PR and between 40b4305 and 6bbf771.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: getappz/agentflare/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 9461b0e5-3132-4806-9729-d09ff696f886
📥 Commits

Reviewing files that changed from the base of the PR and between 2875c28 and 5126cc2.

📒 Files selected for processing (2)
  • src/supervisor.rs
  • src/supervisor/tests/multi_project_sweep_tests.rs

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📝 Walkthrough

Review-batch collection now handles each project independently. A lookup failure skips that project’s batch without aborting collection for the remaining projects. A regression test verifies that another project’s batch remains included.

Changes: Review batch collection

Layer / File(s) Summary
Isolated review batch collection
src/supervisor.rs, src/supervisor/tests/multi_project_sweep_tests.rs
The supervisor builds each project’s review batch separately and skips projects whose item, state, or label lookup fails. Projects without an in_review state still produce no batch. Stray-PR recovery candidates retain their existing eligibility checks. The test verifies that a lookup failure for project A does not exclude project B.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 5126c

A failed project lookup should no longer prevent other projects from being collected. No issue identified here needs resolution before merge.

Pre-merge checks: Passed 5
Passed Passed checks (5 passed)
Check name Status Explanation
Title check Passed The title clearly identifies the per-project lookup failure that aborts the review sweep. It is specific and directly related to the primary change.
Description check Passed The description states the fix and mentions the regression test. It omits the template headings for Summary, Test plan, and Notes for reviewers, but it provides the main change and validation informat…
Linked Issues check Passed Issue #357 is closed and provides historical context only. The linked-issue data states that no active directly linked target remains. Therefore, no coding requirements from #357 apply to this pull re…
Out of Scope Changes check Passed The diff stays within the current PR intent. collect_review_batches isolates per-project lookup failures, logs the skipped project, and preserves batches for other projects. The regression test veri…
Docstring Coverage Passed Docstring coverage is 80.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@getappz
getappz marked this pull request as ready for review October 13, 2026 13:36
@getappz

getappz commented Oct 13, 2026

Copy link
Copy Markdown
Owner Author

Claiming self-repair for i-flare-51bb8de6c33b.

@getappz

getappz commented Oct 13, 2026

Copy link
Copy Markdown
Owner Author

supervisor — CI self-repair dispatched

Failing checks: cargo audit.

Please investigate and push a fix.

job: 87_mxEh4nmpMN7uQCc8tj

@getappz

getappz commented Oct 13, 2026

Copy link
Copy Markdown
Owner Author

supervisor — CI green

Checks are passing again.

@getappz
getappz merged commit bee5c0c into master Oct 14, 2026
17 checks passed
@getappz
getappz deleted the task/361-run-review-sweep-gather-phase-one-projec branch October 14, 2026 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant