Repository navigation
ci: Design-spec: PR lifecycle workflow replacing supervisor review sweep (v1) - #956
Merged
getappz merged 5 commits intoOct 24, 2026
Merged
Conversation
Carve docs/superpowers out of /docs gitignore so shared specs can be versioned like existing superpowers plans. Documents replacing the supervisor review sweep with flare-workflow pr-reconcile/pr-lifecycle. Co-authored-by: Cursor <cursoragent@cursor.com> Agentflare-Agent: cursor Agentflare-Branch: task/395-design-spec-pr-lifecycle-workflow-replac Agentflare-Item: 395
Clarify #366 start_key_for semantics, JSON-vs-Rust schedule fire path, expanded pr-agent audit, and explicit design-spec acceptance criteria. Co-authored-by: Cursor <cursoragent@cursor.com> Agentflare-Agent: cursor Agentflare-Branch: task/395-design-spec-pr-lifecycle-workflow-replac Agentflare-Item: 395
…idence Clarify how SDD design-spec items differ from review-only tasks, what counts as completion evidence versus cargo test on an unchanged tree, and how #395 relates to the proposed pr-reconcile lifecycle workflows. Co-authored-by: Cursor <cursoragent@cursor.com> Agentflare-Agent: cursor Agentflare-Branch: task/395-design-spec-pr-lifecycle-workflow-replac Agentflare-Item: 395
Agentflare-Branch: task/395-design-spec-pr-lifecycle-workflow-replac Agentflare-Item: 395
…t state, and key codebase references. REVIEW_ISSUES: - **Stale verification claim:** Rev 5 is **committed** at `HEAD` (`71cf49f8`, +43 lines to the spec). Working tree is clean; there is no uncommitted rev 5 delta. The “commit before `item done`” note applies only if that was written before the checkpoint commit. - **Branch scope not surfaced:** `git diff master` is **not** limited to design docs. Besides `.gitignore` and the spec, **19 Rust paths** differ (~93 insertions, **~1,889 deletions**), including large removals under `src/review/diff.rs`, `src/memory/mcp.rs`, `src/mcp_server/item_merged_pr.rs`, and supervisor/worktree tests. That contradicts item #395 (“design-spec only, no application code”) and is a merge risk; the analysis should call this out explicitly for operators. - **Embedded spec verification vs current HEAD:** The rev 5 verification block still records `HEAD=83f1d90a` and **497** lines; the file is now **500** lines at `71cf49f8`. Harmless as history, but the analyst run should report **current** `wc -l` and `HEAD` when citing verification. - **Line count:** Spec is **500** lines, not “~501” (minor). - **Branch sync:** Branch is **behind `origin/master` by 4** commits (and ahead by 5). Not mentioned; relevant before PR/merge. - **Technical summary:** Substance on `pr-reconcile` / `pr-lifecycle`, `spawn_schedule_ticker` + JSON-only schedule fire (`resolve_named_definition` in `schedule/tick.rs`), `start_workflow_once`, cutover flag, pr-agent stance, item-work vs PR lifecycle, and parity rows for all `PrCiStatus` variants matches the spec and current code anchors. No correction needed there beyond the branch hygiene gap above.The `mbx build -p agentflare` check never finished: it was killed after about two minutes (exit **137**, lean-ctx output cap), so we don’t have a compile pass/fail for this branch. That doesn’t change the review outcome. The branch still has large Rust diffs vs `master` (~1.9k lines removed across 19 files) on top of the design spec, which is the main hygiene issue called out in **REVIEW_ISSUES**. Agentflare-Branch: task/395-design-spec-pr-lifecycle-workflow-replac Agentflare-Item: 395
getappz
marked this pull request as ready for review
October 22, 2026 15:24
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 54 minutes. View limit details
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifying the analyst's report against the repo: reading the spec, git state, and key codebase references.
REVIEW_ISSUES:
HEAD(71cf49f8, +43 lines to the spec). Working tree is clean; there is no uncommitted rev 5 delta. The “commit beforeitem done” note applies only if that was written before the checkpoint commit.git diff masteris not limited to design docs. Besides.gitignoreand the spec, 19 Rust paths differ (~93 insertions, ~1,889 deletions), including large removals undersrc/review/diff.rs,src/memory/mcp.rs,src/mcp_server/item_merged_pr.rs, and supervisor/worktree tests. That contradicts item fix(supervisor): dispatched jobs inherit the wrong timeout (300s, not works own 1800s) #395 (“design-spec only, no application code”) and is a merge risk; the analysis should call this out explicitly for operators.HEAD=83f1d90aand 497 lines; the file is now 500 lines at71cf49f8. Harmless as history, but the analyst run should report currentwc -landHEADwhen citing verification.origin/masterby 4 commits (and ahead by 5). Not mentioned; relevant before PR/merge.pr-reconcile/pr-lifecycle,spawn_schedule_ticker+ JSON-only schedule fire (resolve_named_definitioninschedule/tick.rs),start_workflow_once, cutover flag, pr-agent stance, item-work vs PR lifecycle, and parity rows for allPrCiStatusvariants matches the spec and current code anchors. No correction needed there beyond the branch hygiene gap above.Thembx build -p agentflarecheck never finished: it was killed after about two minutes (exit 137, lean-ctx output cap), so we don’t have a compile pass/fail for this branch.That doesn’t change the review outcome. The branch still has large Rust diffs vs
master(~1.9k lines removed across 19 files) on top of the design spec, which is the main hygiene issue called out in REVIEW_ISSUES.Opened by
cursoron i-flare-51bb8de6c33b (flared:51bb8de6c33b) for item #395 via agentflare.