Skip to content

ci: Design-spec: PR lifecycle workflow replacing supervisor review sweep (v1) - #956

Merged
getappz merged 5 commits into
masterfrom
task/395-design-spec-pr-lifecycle-workflow-replac
Oct 24, 2026
Merged

getappz merged 5 commits into
masterfrom
task/395-design-spec-pr-lifecycle-workflow-replac

Conversation

@getappz

@getappz getappz commented Oct 22, 2026

Copy link
Copy Markdown
Owner

Verifying the analyst's report against the repo: reading the spec, git state, and key codebase references.
REVIEW_ISSUES:

  • Stale verification claim: Rev 5 is committed at HEAD (71cf49f8, +43 lines to the spec). Working tree is clean; there is no uncommitted rev 5 delta. The “commit before item done” note applies only if that was written before the checkpoint commit.
  • Branch scope not surfaced: git diff master is not limited to design docs. Besides .gitignore and the spec, 19 Rust paths differ (~93 insertions, ~1,889 deletions), including large removals under src/review/diff.rs, src/memory/mcp.rs, src/mcp_server/item_merged_pr.rs, and supervisor/worktree tests. That contradicts item fix(supervisor): dispatched jobs inherit the wrong timeout (300s, not works own 1800s) #395 (“design-spec only, no application code”) and is a merge risk; the analysis should call this out explicitly for operators.
  • Embedded spec verification vs current HEAD: The rev 5 verification block still records HEAD=83f1d90a and 497 lines; the file is now 500 lines at 71cf49f8. Harmless as history, but the analyst run should report current wc -l and HEAD when citing verification.
  • Line count: Spec is 500 lines, not “~501” (minor).
  • Branch sync: Branch is behind origin/master by 4 commits (and ahead by 5). Not mentioned; relevant before PR/merge.
  • Technical summary: Substance on pr-reconcile / pr-lifecycle, spawn_schedule_ticker + JSON-only schedule fire (resolve_named_definition in schedule/tick.rs), start_workflow_once, cutover flag, pr-agent stance, item-work vs PR lifecycle, and parity rows for all PrCiStatus variants matches the spec and current code anchors. No correction needed there beyond the branch hygiene gap above.The mbx build -p agentflare check never finished: it was killed after about two minutes (exit 137, lean-ctx output cap), so we don’t have a compile pass/fail for this branch.

That doesn’t change the review outcome. The branch still has large Rust diffs vs master (~1.9k lines removed across 19 files) on top of the design spec, which is the main hygiene issue called out in REVIEW_ISSUES.


Opened by cursor on i-flare-51bb8de6c33b (flared:51bb8de6c33b) for item #395 via agentflare.

Carve docs/superpowers out of /docs gitignore so shared specs can be
versioned like existing superpowers plans. Documents replacing the
supervisor review sweep with flare-workflow pr-reconcile/pr-lifecycle.

Co-authored-by: Cursor <cursoragent@cursor.com>

Agentflare-Agent: cursor
Agentflare-Branch: task/395-design-spec-pr-lifecycle-workflow-replac
Agentflare-Item: 395
Clarify #366 start_key_for semantics, JSON-vs-Rust schedule fire path,
expanded pr-agent audit, and explicit design-spec acceptance criteria.

Co-authored-by: Cursor <cursoragent@cursor.com>

Agentflare-Agent: cursor
Agentflare-Branch: task/395-design-spec-pr-lifecycle-workflow-replac
Agentflare-Item: 395
…idence

Clarify how SDD design-spec items differ from review-only tasks, what
counts as completion evidence versus cargo test on an unchanged tree, and
how #395 relates to the proposed pr-reconcile lifecycle workflows.

Co-authored-by: Cursor <cursoragent@cursor.com>

Agentflare-Agent: cursor
Agentflare-Branch: task/395-design-spec-pr-lifecycle-workflow-replac
Agentflare-Item: 395
Agentflare-Branch: task/395-design-spec-pr-lifecycle-workflow-replac
Agentflare-Item: 395
…t state, and key codebase references.

REVIEW_ISSUES:

- **Stale verification claim:** Rev 5 is **committed** at `HEAD` (`71cf49f8`, +43 lines to the spec). Working tree is clean; there is no uncommitted rev 5 delta. The “commit before `item done`” note applies only if that was written before the checkpoint commit.
- **Branch scope not surfaced:** `git diff master` is **not** limited to design docs. Besides `.gitignore` and the spec, **19 Rust paths** differ (~93 insertions, **~1,889 deletions**), including large removals under `src/review/diff.rs`, `src/memory/mcp.rs`, `src/mcp_server/item_merged_pr.rs`, and supervisor/worktree tests. That contradicts item #395 (“design-spec only, no application code”) and is a merge risk; the analysis should call this out explicitly for operators.
- **Embedded spec verification vs current HEAD:** The rev 5 verification block still records `HEAD=83f1d90a` and **497** lines; the file is now **500** lines at `71cf49f8`. Harmless as history, but the analyst run should report **current** `wc -l` and `HEAD` when citing verification.
- **Line count:** Spec is **500** lines, not “~501” (minor).
- **Branch sync:** Branch is **behind `origin/master` by 4** commits (and ahead by 5). Not mentioned; relevant before PR/merge.
- **Technical summary:** Substance on `pr-reconcile` / `pr-lifecycle`, `spawn_schedule_ticker` + JSON-only schedule fire (`resolve_named_definition` in `schedule/tick.rs`), `start_workflow_once`, cutover flag, pr-agent stance, item-work vs PR lifecycle, and parity rows for all `PrCiStatus` variants matches the spec and current code anchors. No correction needed there beyond the branch hygiene gap above.The `mbx build -p agentflare` check never finished: it was killed after about two minutes (exit **137**, lean-ctx output cap), so we don’t have a compile pass/fail for this branch.

That doesn’t change the review outcome. The branch still has large Rust diffs vs `master` (~1.9k lines removed across 19 files) on top of the design spec, which is the main hygiene issue called out in **REVIEW_ISSUES**.

Agentflare-Branch: task/395-design-spec-pr-lifecycle-workflow-replac
Agentflare-Item: 395
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Next included review available in 54 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 61 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 6179f98 and 7519969.

📒 Files selected for processing: 2
  • .gitignore
  • docs/superpowers/specs/pr-lifecycle-workflow-v1.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@getappz
getappz merged commit 2ab11bf into master Oct 24, 2026
17 checks passed
@getappz
getappz deleted the task/395-design-spec-pr-lifecycle-workflow-replac branch October 24, 2026 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant