Add the possibility to delete file responses after send and set the download filename - #951
Merged
giuscris merged 1 commit intoSep 6, 2026
Conversation
giuscris
marked this pull request as ready for review
September 6, 2026 20:34
giuscris
deleted the
feature/file-response-delete-after-send-set-filename
branch
September 6, 2026 21:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the
FileResponseclass to provide better control over file downloads and lifecycle management. The main improvements include supporting automatic file deletion after sending and allowing the filename to be set for download responses, while enforcing correct usage with error handling.File download enhancements:
deleteAfterSendproperty toFileResponse, enabling automatic removal of the file from disk after it is sent to the client. The file is deleted if this property is set totrue. [1] [2]setFilenamemethod to specify the download filename in theContent-Dispositionheader. This method throws aLogicExceptionif used when the response is not configured as a download, ensuring correct usage. [1] [2]Constructor and property improvements:
deleteAfterSendproperty, and madedownloada protected property for better encapsulation.