fix: read breakpoint via cached GetBreakpoint partial instead of page Scratch (render-once D3)#2037
Merged
Merged
Conversation
… Scratch All ten readers of the baseof-seeded Scratch key 'breakpoint' now call partialCached "utilities/GetBreakpoint.html" site directly. The partial is a pure function of site.Params.main.breakpoint and never reads its context, so the shared per-language cache entry is unchanged. This removes the render- context timing dependency in content-reachable partials (assets/links.html, assets/breadcrumb.html) and fixes the malformed 'd--none' class emitted when the breadcrumb shortcode resolves a foreign page via its 'path' argument. The seed at baseof.html:24 stays until mod-blocks stops reading the key. Part of the render-once program (slice D3). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for gethinode-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was referenced Jul 16, 2026
Collaborator
Author
|
🎉 This PR is included in version 3.2.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render-once program — slice D3 (HELD for maintainer review)
Part of the Hinode render-once implementation program (design:
gethinode.com
docs/superpowers/specs/2026-07-15-content-render-once-design.md, §4.1/§6-D3).Changes
All 10 readers of
Scratch.Get "breakpoint"now callpartialCached "utilities/GetBreakpoint.html" sitedirectly (single,list,tags/list,header,docs/header,docs/all,minimal/header,page/taxonomy-tag,assets/links,assets/breadcrumb). GetBreakpoint is a pure function ofsite.Params.main.breakpoint, so thecached call is context-free; cache behavior is identical (one entry per language). The seed at
baseof.html:24stays until D9 (mod-blocks ≤ current release still reads the Scratch key).Gate evidence (byte-diff, exampleSite @ 50b5612, hugo v0.164.0)
(2026-07-16):
en/docs/components/breadcrumb/index.html— two attribute values change from themalformed
d--none/d--block(stock deterministically hits the documented breakpoint-Scratchbug when the breadcrumb demo renders a foreign page via
.Site.GetPage) to the correctd-sm-none/d-sm-block. This PR fixes that bug at the source;grep -rl 'd--none'over thecandidate output is empty.
pnpm testclean.🤖 Generated with Claude Code