[stealth 08/11] Harden stealth logging and telemetry defaults#8785
Closed
reflog wants to merge 8 commits into
Closed
[stealth 08/11] Harden stealth logging and telemetry defaults#8785reflog wants to merge 8 commits into
reflog wants to merge 8 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Go-side stealth build helpers to harden log-level and telemetry defaults across Lantern Core startup paths while preserving existing non-stealth defaults.
Changes:
- Adds stealth-aware default resolution for log level and telemetry consent.
- Applies effective log/telemetry values in core initialization, FFI setup, mobile early logging, and mobile IPC startup.
- Adds guard tests for stealth/non-stealth log and telemetry defaults.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
lantern-core/stealth.go |
Adds stealth build detection and effective default helpers. |
lantern-core/stealth_test.go |
Adds tests for stealth log-level and telemetry default behavior. |
lantern-core/core.go |
Applies effective log level and telemetry consent during core initialization. |
lantern-core/logging.go |
Uses effective default log level for app-side logging. |
lantern-core/ffi/ffi.go |
Uses effective default log level during FFI setup. |
lantern-core/mobile/mobile.go |
Applies effective defaults for mobile logging and IPC backend startup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
reflog
changed the title
EffectiveTelemetryConsent now hard-disables telemetry for stealth builds regardless of any prior user opt-in. Telemetry is a deanonymization surface and must not be emitted from stealth artifacts. Also fix gofmt alignment in core.go const block (EventTypeCountryCode tab alignment was off after rebase). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
reflog
force-pushed
the
stealth/8770-logging-telemetry-clean
branch
from
c17e8a3 to
541e2a8
Compare
Contributor
Author
|
Superseded — the 11 per-issue stealth PRs were consolidated into a 6-PR stack for epic getlantern/engineering#3569. This work now lives in #8861. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes getlantern/engineering#3577
Validation
env GOCACHE=/tmp/lantern-8770-go-cache GOMODCACHE=/tmp/lantern-8770-go-mod go test ./lantern-coregofmt -w lantern-core/stealth.go lantern-core/stealth_test.go lantern-core/core.go lantern-core/logging.go lantern-core/ffi/ffi.go lantern-core/mobile/mobile.gogit diff --cached --checkNotes