Skip to content

fix(windows): recover HUD input forwarding after startup - #387

Open
EV9H wants to merge 1 commit into
getopenscreen:mainfrom
EV9H:fix/windows-hud-input-recovery
Open

fix(windows): recover HUD input forwarding after startup#387
EV9H wants to merge 1 commit into
getopenscreen:mainfrom
EV9H:fix/windows-hud-input-recovery

Conversation

@EV9H

@EV9H EV9H commented Aug 17, 2026

Copy link
Copy Markdown

Summary

Re-arm the HUD's forwarded-mouse hook after the Electron window becomes visible. On Windows, the initial renderer IPC request can arrive before the native window is fully ready; if hook installation fails at that point, the HUD remains visible but all controls are unreachable.

Related issue

Refs #385

Type of change

  • Bug fix
  • Feature
  • Enhancement
  • Documentation
  • Refactor / maintenance
  • Performance
  • Security

Release impact

  • Patch
  • Minor
  • Major / breaking change
  • No release note needed

Desktop impact

  • Windows
  • macOS
  • Linux
  • Installer / packaging
  • Not platform-specific

Testing

  • npx tsc --noEmit — passed
  • npx tsc -p tsconfig.test.json --noEmit — passed
  • npx biome check --formatter-enabled=false electron/windows.ts src/components/launch/LaunchWindow.tsx src/components/launch/LaunchWindow.test.tsx — passed
  • npx vitest --run src/components/launch/LaunchWindow.test.tsx — 32 tests passed
  • npm run build-vite — passed
  • npm run test — 1,769 passed, 16 failed, 2 skipped. The 16 failures are pre-existing jsdom test failures under the local Node 25 environment (`localStorage.clear/removeItem is not a function` in four unrelated test suites); no Electron test suites failed after installing the Electron binary.
  • Local macOS development smoke test — HUD rendered, the system-language notice was visible and dismissible, and the toolbar was reachable.

Summary by CodeRabbit

  • Bug Fixes
    • Improved HUD window initialization in headless mode.
    • Ensured click-through behavior is correctly reapplied after the window becomes visible.

Re-arm click-through for HUD window after visibility to ensure input is reachable.
@EV9H
EV9H requested a review from EtienneLescot as a code owner August 17, 2026 03:51
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a08f4593-2c2e-4c8c-93ca-34abc809ab58

📥 Commits

Reviewing files that changed from the base of the PR and between c477979 and 658c40e.

📒 Files selected for processing (1)
  • electron/windows.ts

Included review availability: Your plan includes up to 4 reviews per rolling hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The HUD ready-to-show handler now checks HEADLESS, shows the window, and reapplies forwarded click-through after the native window becomes ready.

Changes

HUD window readiness

Layer / File(s) Summary
Restore HUD click-through after readiness
electron/windows.ts
The handler shows the HUD when HEADLESS is disabled, then calls setIgnoreMouseEvents(true, { forward: true }) after readiness.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 658c4

This localized Windows startup recovery change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Possibly related PRs

Suggested reviewers: etiennelescot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Windows HUD input-forwarding fix after startup.
Description check ✅ Passed The description covers the change, issue reference, classifications, platform impact, testing, and known test failures.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant