ref(service): Use static context strings and helper functions for errors#532
Closed
jan-auer wants to merge 1 commit into
Closed
ref(service): Use static context strings and helper functions for errors#532jan-auer wants to merge 1 commit into
jan-auer wants to merge 1 commit into
Conversation
Use static string references for error context where possible, avoiding unnecessary allocations for fixed messages. Introduce ergonomic helper functions so call sites can construct errors concisely without manually boxing causes or assembling struct literals.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #532 +/- ##
==========================================
+ Coverage 87.17% 87.41% +0.23%
==========================================
Files 89 89
Lines 14150 14116 -34
==========================================
+ Hits 12335 12339 +4
+ Misses 1815 1777 -38
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Closing in favor of #493 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use static string references for error context where possible, avoiding unnecessary allocations for fixed messages. Where context must be dynamic (e.g. including a key name or endpoint in the message), accept owned strings through a flexible parameter type rather than requiring callers to manually convert.
Introduce ergonomic helper functions for constructing errors so that call sites can provide context and cause directly without manually boxing or assembling struct literals.