ref(service): Replace Error with anyhow-like struct with embedded kind#547
Draft
lcian wants to merge 9 commits into
Draft
ref(service): Replace Error with anyhow-like struct with embedded kind#547lcian wants to merge 9 commits into
lcian wants to merge 9 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lcian
force-pushed
the
lcian/refactor-service-error
branch
from
July 16, 2026 11:52
a89948f to
5aad828
Compare
Use the refactored service error APIs when resolving the merge with main. Borrow the task-drop error for logging and preserve ResultExt context conversion for invalid GCS MIME types. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1105da2. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Replaces the
objectstore_service::error::Errorenum with a struct containing an independentErrorKindclassification and ananyhow::Errordiagnostic.This separates error classification from error origin: anyhow preserves the source and stacked context chain, while backends can reclassify errors with
.kind()and add context with.context()withoutmap_errboilerplate. The API maps the flatErrorKindto HTTP status codes.Closes FS-358
Ref FS-439