fix(service): Retry GCS multipart initiate and complete#566
Draft
lcian wants to merge 3 commits into
Draft
Conversation
Wrap initiate, list, abort, and complete in the existing GCS request retry helper so transient 5xx/transport failures are absorbed internally. Leave put-part unretried because the body is streamed and not buffered.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
GcsBackend::with_retry is private, so the intra-doc link failed rustdoc with -Dwarnings in Lint and docs CI jobs.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit c0841bb. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
After a successful abort whose response is lost, retry DELETE can get 404 NoSuchUpload. Treat that as success, matching delete_object.
Member
Author
|
bugbot run |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 033741c. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCS multipart
initiateandcomplete(plus list/abort) now reuse the existing internal request retry helper, so transient GCS500/transport failures are retried in-process instead of failing the client on the first blip.upload_partis intentionally left without retries because the part body is a one-shot stream and is not buffered. Complete is still fine under the same policy: retryable statuses are408/429/5xxand transport errors; if an earlier attempt already assembled the object, a later retry surfaces HTTP 404NoSuchUpload, which is not treated as retryable.