Skip to content

fix(python): Align empty-scope URL rendering with Rust client#568

Open
jan-auer wants to merge 2 commits into
mainfrom
worktree-fix+fs-435-empty-scopes
Open

fix(python): Align empty-scope URL rendering with Rust client#568
jan-auer wants to merge 2 commits into
mainfrom
worktree-fix+fs-435-empty-scopes

Conversation

@jan-auer

Copy link
Copy Markdown
Member

The Python client rendered empty scopes as an empty string, producing /v1/objects/{usecase}//{key}, while the Rust client and server use the _ sentinel, producing /v1/objects/{usecase}/_/{key}. An object written with one client under an empty scope was not addressable by the other.

This also fixes a bug where falsy scope values like 0 or False were rejected as "empty" because the truthiness check ran before str() conversion.

Fixes FS-435

@linear-code

linear-code Bot commented Jul 22, 2026

Copy link
Copy Markdown

FS-435

@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.69%. Comparing base (e88b7f8) to head (c92164e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
+ Coverage   87.67%   87.69%   +0.01%     
==========================================
  Files          93       93              
  Lines       15113    15116       +3     
==========================================
+ Hits        13251    13256       +5     
+ Misses       1862     1860       -2     
Components Coverage Δ
Rust Backend 92.45% <ø> (ø)
Rust Client 79.89% <ø> (ø)
Python Client 90.69% <100.00%> (+0.48%) ⬆️

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jan-auer
jan-auer marked this pull request as ready for review July 22, 2026 08:29
@jan-auer
jan-auer requested a review from a team as a code owner July 22, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant