Skip to content

fix(service): Scale TTI debounce proportionally for short TTI values#571

Open
jan-auer wants to merge 1 commit into
fix/s3-expired-object-filterfrom
fix/tti-debounce-1h
Open

fix(service): Scale TTI debounce proportionally for short TTI values#571
jan-auer wants to merge 1 commit into
fix/s3-expired-object-filterfrom
fix/tti-debounce-1h

Conversation

@jan-auer

Copy link
Copy Markdown
Member

The fixed 24-hour TTI_DEBOUNCE constant silently prevented TTI bumps for any TTI value of 24 hours or less — the bump condition expire_at < now + tti - 24h could never be satisfied, so short-TTI objects degraded into fixed-TTL without any indication.

The debounce window now scales with the TTI duration:

  • TTI below 4 days: uses tti / 4 — e.g. a 2-hour TTI gets a 30-minute debounce so bumps actually fire.
  • TTI of 4 days or more: stays at 24 hours, preserving existing behavior.

Fixes FS-403

@jan-auer
jan-auer requested a review from a team as a code owner July 22, 2026 10:00
@linear-code

linear-code Bot commented Jul 22, 2026

Copy link
Copy Markdown

FS-403

@jan-auer
jan-auer force-pushed the fix/tti-debounce-1h branch from 906b762 to f2a87c5 Compare July 22, 2026 11:19
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.38462% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.58%. Comparing base (56d980d) to head (f2a87c5).

Files with missing lines Patch % Lines
objectstore-service/src/backend/s3_compatible.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                        @@
##           fix/s3-expired-object-filter     #571      +/-   ##
================================================================
+ Coverage                         87.46%   87.58%   +0.12%     
================================================================
  Files                                93       93              
  Lines                             15152    15260     +108     
================================================================
+ Hits                              13252    13365     +113     
+ Misses                             1900     1895       -5     
Components Coverage Δ
Rust Backend 92.27% <95.38%> (+0.12%) ⬆️
Rust Client 79.89% <ø> (ø)
Python Client 90.20% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f2a87c5. Configure here.

Comment thread objectstore-service/src/backend/bigtable.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant