ref(security): Stop accepting Expect-CT, HPKP, and Expect-Staple reports#6230
Draft
mrduncan wants to merge 1 commit into
Draft
ref(security): Stop accepting Expect-CT, HPKP, and Expect-Staple reports#6230mrduncan wants to merge 1 commit into
mrduncan wants to merge 1 commit into
Conversation
HPKP, Expect-CT, and Expect-Staple are dead in all shipping browsers, so these report types can no longer be produced. Relay now rejects them at ingest: the security report classifier no longer recognizes them, and the dedicated expect-ct-report / expect-staple-report content types are refused at the endpoint. The interface types, EventType variants, and Event fields are intentionally retained for a later full-removal PR that coordinates with the Sentry backend. Refs getsentry/sentry#119638 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jjbayer
reviewed
Jul 15, 2026
jjbayer
left a comment
Member
There was a problem hiding this comment.
Looks reasonable to me. We'll have to remove the sentry-side relay_integration tests in order for CI to pass.
Member
To fully stop ingestion we'll also have to remove it from the /// HPKP (security) reports.
#[metastructure(pii = "true", legacy_alias = "sentry.interfaces.Hpkp")]
#[metastructure(omit_from_schema)] // we only document error events for now
pub hpkp: Annotated<Hpkp>,
/// ExpectCT (security) reports.
#[metastructure(pii = "true", legacy_alias = "sentry.interfaces.ExpectCT")]
#[metastructure(omit_from_schema)] // we only document error events for now
pub expectct: Annotated<ExpectCt>,
/// ExpectStaple (security) reports.
#[metastructure(pii = "true", legacy_alias = "sentry.interfaces.ExpectStaple")]
#[metastructure(omit_from_schema)] // we only document error events for now
pub expectstaple: Annotated<ExpectStaple>,Can be done in a follow-up, but maybe easier to do it in one sweep. Without making these changes, outdated customer hosted Relays and custom clients can still send these reports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HPKP, Expect-CT, and Expect-Staple are dead in all shipping browsers, so these report types can no longer be produced. Relay now rejects them at ingest: the security report classifier no longer recognizes them, and the dedicated expect-ct-report / expect-staple-report content types are refused at the endpoint.
This is the ~simplest change so that we stop accepting these reports and keep this PR manageable. The remaining cleanup should be straightforward as a follow up.
Refs getsentry/sentry#119638