ref(attributes): Introduce AttributeLike for shared normalizations#6235
Merged
Conversation
Dav1dde
force-pushed
the
dav1d/attribute-like
branch
from
July 15, 2026 12:53
2546c2f to
4a003f5
Compare
Contributor
|
AFAICT the trait has more of an API than strictly necessary even now, right? |
Member
Author
|
Yes, it has more than necessary, I am somewhat confident these methods will be useful, more niche ones like |
loewenheim
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we discussed in TSC, an attempt to allow normalizations to operate on
SpanDataas well asAttributes, which is handy for normalizations like in #6201.Considered adding more API surface, such as
into_value(), ormeta()accessors, decided against it for now, we should add them as the need arises.