Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Sentry/SentryClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ public void CaptureTransaction(SentryTransaction transaction, Scope? scope, Sent
var processedTransaction = transaction;
foreach (var processor in scope.GetAllTransactionProcessors())
{
processedTransaction = processor.DoProcessTransaction(transaction, hint);
processedTransaction = processor.DoProcessTransaction(processedTransaction, hint);
if (processedTransaction == null) // Rejected transaction
{
_options.ClientReportRecorder.RecordDiscardedEvent(DiscardReason.EventProcessor, DataCategory.Transaction);
Expand Down
36 changes: 36 additions & 0 deletions test/Sentry.Tests/SentryClientTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1638,6 +1638,42 @@ public void CaptureTransaction_AddedTransactionProcessor_ReceivesHint()
processor.Received(1).Process(Arg.Any<SentryTransaction>(), Arg.Any<SentryHint>());
}

[Fact]
public void CaptureTransaction_MultipleTransactionProcessors_EachReceivesThePreviousResult()
{
// Arrange
var first = Substitute.For<ISentryTransactionProcessor>();
var second = Substitute.For<ISentryTransactionProcessor>();
var replacement = new SentryTransaction("replaced by first", "operation")
{
IsSampled = true,
EndTimestamp = DateTimeOffset.Now
};
first.Process(Arg.Any<SentryTransaction>()).Returns(replacement);
second.Process(Arg.Any<SentryTransaction>()).Returns(callInfo => callInfo.Arg<SentryTransaction>());
_fixture.SentryOptions.AddTransactionProcessor(first);
_fixture.SentryOptions.AddTransactionProcessor(second);

var transaction = new SentryTransaction("original", "operation")
{
IsSampled = true,
EndTimestamp = DateTimeOffset.Now
};

Envelope envelope = null;
_fixture.BackgroundWorker.EnqueueEnvelope(Arg.Do<Envelope>(arg => envelope = arg)).Returns(true);

// Act
_fixture.GetSut().CaptureTransaction(transaction);

// Assert
second.Received(1).Process(replacement);
envelope.Should().NotBeNull();
var sent = envelope.Items.Select(i => i.Payload).OfType<JsonSerializable>()
.Select(p => p.Source).OfType<SentryTransaction>().Single();
sent.Name.Should().Be("replaced by first");
}

[Fact]
public void CaptureTransaction_TransactionProcessor_ReceivesScopeAttachments()
{
Expand Down
Loading