Repository navigation
Bump craft to 3.9.0 and update config - #2924
Merged
Merged
Conversation
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
bitsandfoxes
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps the release workflow's pinned
getsentry/craftaction from 2.21.4 (906009a1, labeled# v2) to 3.9.0 (2e29b081).Why: craft's "Check release blockers" step used to ask GitHub to cancel the run and then exit 0, so later steps kept going and could open a getsentry/publish issue even with a
release-blockerissue open (seen in getsentry/symbolic run 41665569364). getsentry/craft#956 fixed this in 3.9.0: the step now fails right away, and it also fails if the blocker lookup errors. Older pins don't get the fix.Compatibility with craft 3.x:
with:inputs stay valid..craft.ymldoesn't setchangelog.includePathsorunownedPaths.minVersionis 2.21.4, but it definespreReleaseCommand, so the new "fail when auto-bump finds nothing" check doesn't run.prepare 99.0.0 --dry-run --no-pushagainst currentmain. It ranscripts/bump-version.shand finished without errors. The first attempt failed only because pwsh wasn't installed locally.There are no open
release-blockerissues here right now. Once this lands, an open one will stop releases until it's closed orforceis set.Config changes (
.craft.yml, for craft 3.9.0):minVersionto 3.9.0 (was 2.21.4).changelogPolicy: autowithchangelog.policy: auto.minVersion(auto-bump from 2.21.0,autoversioning from 2.14.0) already apply at 2.21.4, so release behavior doesn't change.prepare 99.0.0 --dry-run --no-push, run before and after this change, bumps the same 5 files with no new errors or warnings, and thechangelogPolicydeprecation warning is gone.via @BYK.
--
View Session in Sentry