Repository navigation
Respect UploadDevelopmentSymbols for iOS symbol upload - #2928
Open
bitsandfoxes wants to merge 2 commits into
Open
bitsandfoxes wants to merge 2 commits into
bitsandfoxes wants to merge 2 commits into
Conversation
bitsandfoxes
force-pushed
the
fix/ios-upload-development-symbols
branch
from
November 4, 2026 15:47
4822ae4 to
7a39716
Compare
bitsandfoxes
changed the base branch from
main
to
test/skip-android-2021-throw-frame
November 4, 2026 15:59
bitsandfoxes
marked this pull request as ready for review
November 4, 2026 16:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iOS, symbols were uploaded for development builds even with
UploadDevelopmentSymbolsoff: the XcodeSENTRY_CLI_UPLOAD_SYMBOLSbuild setting was set fromUploadSymbolsalone. Android and the native platforms already skip development builds unlessUploadDevelopmentSymbolsis on, throughSentryCliOptions.IsValid.IsValidare now their own internal method,SentryCliOptions.IsUploadEnabled, whichIsValidcalls. Behaviour on the other platforms is unchanged.SentryXcodeProject.AddBuildPhaseSymbolUploadtakesisDevelopmentBuildand setsSENTRY_CLI_UPLOAD_SYMBOLSfromIsUploadEnabled. The iOS build post-processor passesEditorUserBuildSettings.development, the same flag the other platforms use.NO, the phase skips the upload.Test:
AddBuildPhaseSymbolUpload_DevelopmentBuild_RespectsUploadDevelopmentSymbolsinSentryXcodeProjectTestscovers development and release builds with the option on and off. The development build with the option off fails without the fix.🤖 Generated with Claude Code