Repository navigation
Limit the window's Event Sample Rate to 0.01 through 1.0 - #2929
Draft
bitsandfoxes wants to merge 3 commits into
Draft
bitsandfoxes wants to merge 3 commits into
bitsandfoxes wants to merge 3 commits into
Conversation
bitsandfoxes
force-pushed
the
fix/event-sample-rate-minimum
branch
from
November 4, 2026 15:47
0444d78 to
1f5496d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Event Sample Rate field in the Sentry window accepted values from 0 to 1. sentry-dotnet's
SentryOptions.SampleRatethrows for 0, so with the field set to 0, loading the options threw: the SDK didn't initialize, and build steps that load the options failed.The field now accepts values from 0.01 (1%), the documented minimum in sentry-dotnet, to 1.0, and the tooltip states the range. Setting
SampleRate = 0in code still throws in sentry-dotnet, as before.Tests:
CoreTabTestscovers the clamp at and around both ends, and that a value of 0 clamped by the window loads throughToSentryUnityOptionswithout throwing. Both fail with the previous[0, 1]clamp.🤖 Generated with Claude Code