Repository navigation
Send the device name only with SendDefaultPii - #2932
Draft
bitsandfoxes wants to merge 3 commits into
Draft
bitsandfoxes wants to merge 3 commits into
bitsandfoxes wants to merge 3 commits into
Conversation
bitsandfoxes
force-pushed
the
snek/sentry-unity-device-name-gate
branch
from
November 4, 2026 15:47
51037a7 to
eb3731a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The device name (
device.name, fromSystemInfo.deviceName) is set only whenSendDefaultPiiis enabled, the same waydevice.device_unique_identifieris. Users often name their device after themselves, e.g. "Jane's iPhone", so it can identify them.The gate sits where the scope's device context is filled in, so it covers native crashes too: on desktop and consoles, Unity copies that context into sentry-native's scope, and sentry-native doesn't collect a device name itself. On Android and iOS, Unity doesn't pass the name on to sentry-java or sentry-cocoa.
This changes what is sent by default, so the CHANGELOG lists it under Behavioral Changes.
Tests cover the scope with and without
SendDefaultPii, and that the native context writer gets no name without it.🤖 Generated with Claude Code