Conversation
Owner
|
Thank you, but no need for duplication, it is a typo issue in docs, i will fix it in docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #243 where referencing
Boolean2StrConverter(as documented in the documentation) fails because onlyBoolean2StringConverterwas defined as the class name and resource key.Root Cause
The file is named
Boolean2StrConverter.cs, and the official documentation specifiesBoolean2StrConverterwith[str0];[str1]parameter formatting, but the class declared inBoolean2StrConverter.csisBoolean2StringConverter. Consequently, developers following the documentation who referenceBoolean2StrConverterin XAML receive a missing resource / type error.Solution
Boolean2StrConverterinheriting fromBoolean2StringConverterinsrc/Shared/HandyControl_Shared/Tools/Converter/Boolean2StrConverter.cs:<converter:Boolean2StrConverter x:Key="Boolean2StrConverter"/>inConverters.xamlandTheme.xaml(Shared and Net_40).Boolean2StrConverterinResourceToken.cs.Verification
src/Net_GE45/HandyControl_Net_GE45/HandyControl_Net_GE45.csprojwith target frameworknet8.0-windows(0 errors, 0 warnings).src/Net_GE45/HandyControlDemo_Net_GE45/HandyControlDemo_Net_GE45.csprojwith target frameworknet8.0-windows(0 errors, 0 warnings).