Skip to content

ci: pin pr-review-threads to go-kure/.github#294's merge commit - #15

Merged
srgvg merged 1 commit into
mainfrom
chore/pr-review-threads-294
Oct 26, 2026
Merged

srgvg merged 1 commit into
mainfrom
chore/pr-review-threads-294

Conversation

@srgvg

@srgvg srgvg commented Oct 26, 2026

Copy link
Copy Markdown
Member

Bumps the pr-review-threads pin in .github/workflows/pr-review.yml from go-kure/.github@ae10bfb (go-kure/.github#154) to go-kure/.github@31dcd8b, the commit that merged go-kure/.github#294. Reviews in ginsys repositories then leave lockfiles out of the reviewed diff, so a lockfile-only change over the size ceiling no longer fails as an incomplete review.

Wrapper kept in step. Upstream's own wrapper changed between the two pins. None of those changes is needed here:

  • BOT_PAT / bot-login inputs: this wrapper posts as github.token with bot-login: github-actions[bot] and never used KURE_BOT_PAT.
  • standards-file / standards-source inputs: the action's new standards-source defaults to action, which is the behaviour this wrapper already documents.

Every input this wrapper passes still exists in the action at 31dcd8b.

Evidence

  • mise run verify passes, including check-action-pins (14 refs).
  • One local review of the commit: no findings.
  • One-line diff: the uses: pin and its comment.

The review now excludes lockfiles from its diff, so a lockfile-only change
over the size ceiling no longer fails the review as incomplete. The
action's one new input, standards-source, defaults to "action", the
behaviour this wrapper already documents.
Copilot AI balanced review requested due to automatic review settings October 26, 2026 07:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The target commit and wrapper compatibility were verified, with no unresolved findings.

No open issues 🎉

What changed in this PR

Updates the shared PR review action so ginsys repositories exclude lockfiles from reviewed diffs, preventing oversized lockfile-only changes from failing as incomplete reviews.

Changes:

  • Pins pr-review-threads to 31dcd8b, the merge commit for go-kure/.github#294.
  • Retains the existing wrapper inputs, which remain compatible with the updated action.
File Description
.github/​workflows/​pr-review.yml Updates the action’s pinned commit and accompanying reference comment.

Review effort: Balanced

@srgvg
srgvg marked this pull request as ready for review October 26, 2026 07:55
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T07:56:50.884239Z 063f42c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@srgvg
srgvg merged commit b12e1b1 into main Oct 26, 2026
5 checks passed
@srgvg
srgvg deleted the chore/pr-review-threads-294 branch October 26, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants