-
Notifications
You must be signed in to change notification settings - Fork 0
Implement sortArrayBy
#40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5db9bd6
Implement sortArrayBy
giraugh 7041581
Bump required node version to 20
giraugh a9d81c3
Update typescript version to 5 w/ corresponding versions for dts and …
giraugh a0a755d
node v 24
giraugh 60a440b
Bump version of gha standard actions
giraugh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@giraugh/tools": minor | ||
| --- | ||
|
|
||
| Implement `sortArrayBy` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| /** | ||
| * Return a sorted array using a comparison function that returns a sorting key | ||
| * @param array the array to sort | ||
| * @param keyFn the key to sort by. The elements of the array will be sorted using standard `>` and `<` operations on this key. | ||
| * @param order - whether ascending or descending. 'asc' by default. | ||
| * @returns an object containing arrays with an entry for each group | ||
| * | ||
| * @example | ||
| * const sorted = sortArrayBy(events, event => event.date.valueOf()) | ||
| */ | ||
| export const sortArrayBy = <T, K extends number | string>( | ||
| array: T[], | ||
| keyFn: (element: T) => K, | ||
| order: 'asc' | 'desc' = 'asc', | ||
| ): T[] => { | ||
| const fw = order === 'asc' ? 1 : -1; | ||
| return array | ||
| .toSorted((a, b) => keyFn(a) > keyFn(b) ? fw : -fw) | ||
| } | ||
|
|
||
| // Tests | ||
| if (import.meta.vitest) { | ||
| const { it, expect } = import.meta.vitest | ||
|
|
||
| it('works for example 1', () => { | ||
| const events = [ | ||
| { message: 'Checked into hotel', date: new Date('2026-03-03 08:00') }, | ||
| { message: 'Plane took off', date: new Date('2026-03-02 13:00') }, | ||
| { message: 'Arrived at the airport', date: new Date('2026-03-02 10:00') }, | ||
| { message: 'Arrived in Italy', date: new Date('2026-03-03 05:00') }, | ||
| ] | ||
|
|
||
| const sorted = sortArrayBy(events, e => e.date.valueOf()) | ||
| expect(sorted.map(s => s.message)).toEqual([ | ||
| 'Arrived at the airport', | ||
| 'Plane took off', | ||
| 'Arrived in Italy', | ||
| 'Checked into hotel', | ||
| ]) | ||
| }) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.