Rust: Set RUSTUP_AUTO_INSTALL=1 - #22369
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables rustup toolchain auto-installation for Rust extraction.
Changes:
- Adds
RUSTUP_AUTO_INSTALL=1to cargo’s extra environment. - Preserves configured cargo environment overrides.
Show a summary per file
| File | Description |
|---|---|
rust/extractor/src/config.rs |
Configures rustup auto-installation for cargo operations. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
redsun82
reviewed
Aug 18, 2026
hvitved
force-pushed
the
rust/rustup-auto-install
branch
from
August 18, 2026 08:25
58045c9 to
e636bbd
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| let sysroot_src_input = self.sysroot_src.as_ref().map(|p| join_path_buf(dir, p)); | ||
| match (sysroot_input, sysroot_src_input) { | ||
| (None, None) => Sysroot::discover(dir, &self.cargo_extra_env), | ||
| (None, None) => Sysroot::discover(dir, &self.get_extra_env()), |
Contributor
There was a problem hiding this comment.
uh, I thought we had gotten rid of this false positive?
| let sysroot_src_input = self.sysroot_src.as_ref().map(|p| join_path_buf(dir, p)); | ||
| match (sysroot_input, sysroot_src_input) { | ||
| (None, None) => Sysroot::discover(dir, &self.cargo_extra_env), | ||
| (None, None) => Sysroot::discover(dir, &self.get_extra_env()), |
hvitved
force-pushed
the
rust/rustup-auto-install
branch
from
August 18, 2026 08:28
e636bbd to
4c4e13c
Compare
redsun82
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.