Add Rust low-level tool-definition E2E test [5/6]#1727
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Rust E2E coverage for the “low-level tool definition” scenario (shared replay snapshot) and tweaks a Rust session-lifecycle E2E prompt to align with replay expectations.
Changes:
- Added a new Rust E2E test (
low_level_tool_definition) that registers two custom tools, constrains available tools viaToolSet, and asserts both assistant output and handler-side state. - Added Rust tool handler implementations for
set_current_phaseandsearch_itemsused by the new E2E test. - Updated the session-lifecycle test’s second prompt string.
Show a summary per file
| File | Description |
|---|---|
| rust/tests/e2e/tools.rs | Adds a new low-level tool-definition E2E test plus new tool handlers used by the test. |
| rust/tests/e2e/session_lifecycle.rs | Changes the second session’s prompt text used by the replay-based lifecycle test. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 2
| "phase": { | ||
| "type": "string", | ||
| "description": "Current phase", | ||
| "pattern": "^(searching|analyzing|done)$" |
This was referenced Jun 18, 2026
The snapshot expects 'Say world' but the branch had changed it to 'Say hi', causing 'No cached response found' failures across all three OS variants. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Rust low-level tool-definition E2E coverage and includes the session-lifecycle replay prompt alignment fix.
This PR is related to issue #1682 but does not fix #1682.
What changed
low_level_tool_definitioncoverage in:rust/tests/e2e/tools.rsrust/tests/e2e/session_lifecycle.rstest/snapshots/tools/low_level_tool_definition.yamlDependency / sequencing
Related