Repository navigation
Remove redundant Copilot Decisions API integration test - #76083
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot evals already provide live API coverage. Remove the standalone test and scheduled workflow, update its documentation, and drop the obsolete CJS inference permission exception. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ PR Specification Reviewer completed successfully! PR Specification ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Ponytail Reviewer completed successfully!
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
There was a problem hiding this comment.
🟢 Approval recommended
The changes consistently remove the redundant live Decisions API test, tighten CJS workflow permission validation with regression coverage, and update the related documentation without identified active issues.
No open issues 🎉
What changed in this PR
This pull request removes the redundant live Copilot Decisions API smoke test from the CJS workflow, relying on existing Copilot eval coverage instead. It also tightens workflow-permission validation and updates the related documentation.
Changes:
- Removes the standalone Decisions API integration test and CJS workflow job.
- Removes the associated checkout-cache cleanup dependency.
- Removes the CJS
copilot-requests: writepurity exception and adds regression coverage rejecting it. - Updates setup documentation to describe eval-based API coverage.
Review note: The PR description says the daily workflow was removed, but the daily workflow files and weekday schedule still appear to be present. The scope should be reconciled.
| File | Summary |
|---|---|
scripts/check-cgo-cjs-workflow-purity.sh |
Removes the obsolete CJS Copilot write-permission exception. |
scripts/check-cgo-cjs-workflow-purity_test.sh |
Updates regression coverage to reject copilot-requests: write for CJS workflows. |
actions/setup/README.md |
Documents eval-based live Decisions API coverage; requires reconciliation with the remaining daily workflow. |
actions/setup/js/scripts/test_decisions_client.cjs |
Removes the redundant live Decisions API integration test. |
.github/workflows/cjs.yml |
Removes the Decisions integration job and its cleanup dependency. |
Review effort: Lite (auto)
Copilot evals already provide live Decisions API coverage, so the standalone smoke test adds redundant API calls.
Removes the test script and its CJS integration job, including the checkout-cache cleanup dependency. The daily workflow introduced earlier in this branch is also removed. Updates the setup documentation and drops the now-unused CJS
copilot-requests: writepurity exception, with regression coverage confirming that CJS rejects that permission.All other CJS checks and existing evals remain unchanged.
Validation:
make agent-report-progress, all nine workflow-purity regression tests, workflow purity checks, and a repository search confirming no references to the removed test or job remain.