Skip to content

Remove redundant Copilot Decisions API integration test - #76083

Merged
pelikhan merged 2 commits into
mainfrom
pelikhan/daily-decisions-test
Nov 9, 2026
Merged

pelikhan merged 2 commits into
mainfrom
pelikhan/daily-decisions-test

Conversation

@pelikhan

@pelikhan pelikhan commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

Copilot evals already provide live Decisions API coverage, so the standalone smoke test adds redundant API calls.

Removes the test script and its CJS integration job, including the checkout-cache cleanup dependency. The daily workflow introduced earlier in this branch is also removed. Updates the setup documentation and drops the now-unused CJS copilot-requests: write purity exception, with regression coverage confirming that CJS rejects that permission.

All other CJS checks and existing evals remain unchanged.

Validation: make agent-report-progress, all nine workflow-purity regression tests, workflow purity checks, and a repository search confirming no references to the removed test or job remain.

pelikhan and others added 2 commits November 8, 2026 17:47
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot evals already provide live API coverage. Remove the standalone test and scheduled workflow, update its documentation, and drop the obsolete CJS inference permission exception.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@pelikhan pelikhan changed the title Run Copilot Decisions API integration test daily Remove redundant Copilot Decisions API integration test Nov 9, 2026
@pelikhan
pelikhan marked this pull request as ready for review November 9, 2026 01:51
Copilot AI auto review requested due to automatic review settings November 9, 2026 01:51
@pelikhan
pelikhan merged commit e6ef04b into main Nov 9, 2026
32 of 52 checks passed
@pelikhan
pelikhan deleted the pelikhan/daily-decisions-test branch November 9, 2026 01:51
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Test Quality Sentinel · routed: haiku55 xhigh · ~2 AIC · ⌖ ~2 AIC · ⊞ 7.2K · ◷

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

✅ PR Specification Reviewer completed successfully!

PR Specification Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from PR Specification Reviewer · gpt56 · ~1 AIC · ⌖ ~2 AIC · ⊞ 1.7K · ◷

Generated by PR Specification Reviewer for #76083

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

✅ Ponytail Reviewer completed successfully!

Generated by Ponytail Reviewer for #76083

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

Design Decision Gate 🏗️

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Design Decision Gate 🏗️ · routed: haiku55 xhigh · ~1 AIC · ⌖ ~2 AIC · ⊞ 8.6K · ◷

🏗️ ADR gate enforced by Design Decision Gate 🏗️

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes consistently remove the redundant live Decisions API test, tighten CJS workflow permission validation with regression coverage, and update the related documentation without identified active issues.

No open issues 🎉

What changed in this PR

This pull request removes the redundant live Copilot Decisions API smoke test from the CJS workflow, relying on existing Copilot eval coverage instead. It also tightens workflow-permission validation and updates the related documentation.

Changes:

  • Removes the standalone Decisions API integration test and CJS workflow job.
  • Removes the associated checkout-cache cleanup dependency.
  • Removes the CJS copilot-requests: write purity exception and adds regression coverage rejecting it.
  • Updates setup documentation to describe eval-based API coverage.

Review note: The PR description says the daily workflow was removed, but the daily workflow files and weekday schedule still appear to be present. The scope should be reconciled.

File Summary
scripts/​check-cgo-cjs-workflow-purity.sh Removes the obsolete CJS Copilot write-permission exception.
scripts/​check-cgo-cjs-workflow-purity_test.sh Updates regression coverage to reject copilot-requests: write for CJS workflows.
actions/​setup/​README.md Documents eval-based live Decisions API coverage; requires reconciliation with the remaining daily workflow.
actions/​setup/​js/​scripts/​test_decisions_client.cjs Removes the redundant live Decisions API integration test.
.github/​workflows/​cjs.yml Removes the Decisions integration job and its cleanup dependency.

Review effort: Lite (auto)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants