Skip to content

Require terminal safe-output signals - #76194

Draft
gh-aw-bot with Copilot wants to merge 2 commits into
mainfrom
copilot/aw-top-10-reduce-runs-without-terminal-safe-output
Draft

gh-aw-bot with Copilot wants to merge 2 commits into
mainfrom
copilot/aw-top-10-reduce-runs-without-terminal-safe-output

Conversation

Copilot AI commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Some workflows finish without recording a terminal safe output, leaving completion unconfirmed. Failure reports should distinguish a missing signal from explicitly incomplete work.

  • Terminal outcome guidance

    • Require a safe-output call after task work.
    • Use noop for completed work requiring no action; use report_incomplete for blockers.
  • Failure classification

    • Label collector-detected missing outputs as “Completion Signal Missing.”
    • Preserve “Task Could Not Be Completed” for agent-reported incomplete work.

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Hey @Copilot 👋 — thanks for tackling the safe output terminal detection issue! The direction is solid and aligns well with the project. Here's what's needed to move this forward:

  • Add regression tests — The PR lists "Add focused prompt and failure-report regression tests" as an unchecked task. These are essential to validate the fix prevents runs from finishing without proper terminal safe outputs. Unit tests for the happy path (terminal safe output present) and edge cases (missing terminal signal) would lock this in.
  • Complete the WIP — The PR is currently in draft with an incomplete task checklist. Once tests are in and the implementation is ready, remove the draft flag and mark all tasks complete so reviewers can proceed.

If you'd like help, you can assign this prompt to your coding agent:

Add focused regression tests for the safe output terminal detection fix (#76175).
Cover these scenarios:
1. Agent completes with a terminal safe output (noop or report_incomplete) — test that the output is recorded and run is marked complete.
2. Agent finishes without terminal safe output — test that collector detects the missing signal and reports it distinctly from agent-reported incomplete work.
3. Mixed run states (some steps with terminal output, some without) — ensure only missing signals are flagged.
Run targeted validation after tests pass.

Generated by ✅ Contribution Check · copilot · routed: haiku55 xhigh · ~17 AIC · ⌖ ~2 AIC · ⊞ 5.4K · ◷

Copilot AI changed the title [WIP] Fix runs that finish without a terminal safe output Require terminal safe-output signals Nov 9, 2026
Copilot AI requested a review from gh-aw-bot November 9, 2026 09:00

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AW Top 10] 06 Reduce runs that finish without a terminal safe output

2 participants