Repository navigation
chore(release): prepare Squad 2.0.0 - #2534
Conversation
* fix(sdk): export gitignore-state helpers; bump Squad.Agents.AI to 0.5.5 (#1387)
migrate-backend.ts imports addSquadStateGitignoreBlock/removeSquadStateGitignoreBlock
from @bradygaster/squad-sdk, but src/index.ts never re-exported them, breaking the CLI
TypeScript build (TS2305). Re-export both helpers (and their marker constants) so the CLI
compiles. Also bump the stale Squad.Agents.AI NuGet version 0.5.1 -> 0.5.5 so a republish
pins to the fixed CLI.
Unblocks a stable release carrying the #1378 inline-dispatch-gate fix.
Refs #1386
Co-authored-by: brady gaster <bradygaster@github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* feat(tracing): capture task-tool dispatch + tool requests for subagent OTel (#1384)
Adds a "subagent dispatched" envelope to the SquadSubagentTraceMapper so
consumers and OTel backends see the LLM-supplied persona identity from the
moment the coordinator invokes the `task` tool — instead of waiting for the
later SubagentStartedEvent (which only carries the catalog `agent_type`,
e.g. always "general-purpose").
Mapper / public surface:
- Add `SubagentDispatched` to `SquadAgentTraceEventKind` and four persona
properties on `SquadAgentTraceEvent`
(`DispatchedPersonaName/Description/AgentType/Prompt`).
- Rewrite mapper to key live activities by `ToolCallId` (primary) and
maintain a `SdkAgentId → ToolCallId` lookup so `AssistantMessageEvent`s
(which only carry `AgentId`) can find the right span. Activities are
opened on the task-dispatch event and labelled with the persona name from
the start, then augmented on `SubagentStartedEvent`.
- Surface `AssistantMessageData.ToolRequests[].Name` on the typed envelope
as `RequestedToolNames`, and add a `squad.subagent.tool_requests`
ActivityEvent so tool-only assistant turns (empty Content) are visible
on the OTel span as "called gh, view, grep" instead of a blank marker.
Sample:
- Add Flow 5 demonstrating both the typed `OnSubagentTrace` callback and
an `ActivityListener` for OTel.
- Update Flow 1 to use the same handler with the new tool-name surfacing
and a short `ShortId` formatter so parallel subagents are
visually distinct.
- Fix Flow 3 (BYOK): merge the parent process env with custom vars to
avoid the `Assertion failed: ncrypto::CSPRNG(nullptr, 0)` Node crash on
Windows.
SDK:
- When forwarding `options.Environment` to the Copilot client, merge with
the parent process env (instead of replacing it) so the native CLI
inherits SYSTEMROOT/PATH/TEMP and doesn't crash on crypto init.
Tests (82 total, all pass on net8.0/net9.0/net10.0):
- 11 new tests covering task-dispatch parsing, `subagent_type` alias,
bare-arguments fallback, `ToolRequests` extraction, the
`squad.subagent.tool_requests` ActivityEvent, ToolCallId-keyed activity
lifecycle, parallel dispatches, missing-arguments path, and the
`sessionConfig.Agent = "Squad"` routing assertion update.
Co-authored-by: Tamir Dresher <tamirdresher@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix: escape args for cmd.exe shell on Windows (DEP0190) (#1388)
* fix: escape args for cmd.exe shell on Windows (DEP0190)
When execFile is called with shell: true on Windows, Node concatenates
args with spaces but does NOT quote them. This causes multi-word prompts
(e.g. the -p/--message arg) to be split by cmd.exe, resulting in
'The system cannot find the file specified' errors.
Changes:
- Add escapeForCmd() and escapeArgs() to agent-spawn.ts that properly
wrap args containing spaces/metacharacters in double quotes
- Apply escaping in spawnWithTimeout() and spawnAgent() before passing
to execFile
- Migrate monitor-email, monitor-teams, retro, and decision-hygiene
capabilities to use the shared agent-spawn module instead of
duplicated inline buildAgentCommand/spawnWithTimeout functions
- Fix preflight checks to use IS_WINDOWS instead of hardcoded shell:true
Also resolves the Node DEP0190 deprecation warning about passing args
to a child process with shell option true being a security risk, since
args are now properly escaped before concatenation.
Fixes bradygaster/squad#TBD
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix: use gh auth token instead of gh auth status for auth checks
gh auth status returns a non-zero exit code when ANY account in the
keyring has an invalid/stale token, even if the active account (e.g.
via GH_TOKEN env var) is perfectly fine. This causes squad watch and
other commands to incorrectly report 'gh CLI not authenticated'.
Switch to gh auth token which only checks the active account and
returns the token on success.
Fixes the false-negative auth check when users have multiple gh
accounts with a stale keyring entry.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix: use -p flag instead of --message for copilot CLI
The copilot CLI accepts -p/--prompt for non-interactive mode, not
--message. The --message flag doesn't exist, causing 'unknown option'
errors when capabilities try to invoke copilot.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* feat: default to --yolo when --execute is active
Copilot CLI hangs in non-interactive (-p) mode without permission
flags because it prompts for tool/path/url approval. Since squad watch
spawns copilot headlessly, default to --yolo (equivalent to
--allow-all) when execute mode is active and no explicit copilotFlags
or agentCmd are set.
Users can still override with --copilot-flags to use a more
restrictive set of permissions.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* chore: add changeset for shell spawn fixes
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* feat(coordinator): spawn cast members as sub-sessions in Copilot App (#1385)
* feat(coordinator): spawn cast members as sub-sessions in Copilot App
Add SpawnBackend abstraction with TaskSpawnBackend (CLI) and
SessionSpawnBackend (App) implementations. When create_session tool
is available, agents spawn as sub-sessions with real-time visibility
in the left nav. Zero CLI impact — behavior unchanged without the tool.
Key design:
- Platform detection via tool availability probe at session start
- Naming: '{Name} {verb}ing {noun}' (40-char max, sentence case)
- Concurrency cap: 4-5 simultaneous sub-sessions
- Depth limit: max 1 (no sub-sub-sessions)
- Graceful fallback: App backend fails → degrade to task tool
Closes #1377
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(coordinator): address PR review - wire spawnBackend, fix detection order, add release()
- Reorder platform detection: create_session > runSubagent > task > inline
- Wire spawnBackend.spawn() into spawnSingle() with fallback to createSession
- Both backends now require injected createSession callback (real session creation)
- Add release(handle) to SpawnBackend interface for concurrency tracking
- SessionSpawnBackend: proper pending/active tracking, reject (not queue) at cap
- Remove unused SpawnRequest import (now used in fan-out wiring)
- Add tests for spawn-backend and fan-out integration
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: brady gaster <bradygaster@github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(coordinator): address #1385 review follow-ups (#1390)
Hardening fixes for the sub-session spawn backend (#1377):
- App->task fallback: spawnSingle() falls back to createSession when the
platform backend fails instead of failing the agent (emits
session.spawn_fallback)
- Slot-leak guards: registerSpawnRelease() handles 'completed' status and
adds an unref'd max-lifetime safety timer
- createSession timeout in both backends (createSessionTimeoutMs, default 60s)
- Honest isAvailable() with injectable availabilityCheck predicate
- Prompt sanitization for caller task/context (sanitizePromptValue)
- Re-synced template platform-detection probe order to mirrors
Adds vitest coverage for all six items.
Closes #1377
Co-authored-by: brady gaster <bradygaster@github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Rename .NET Aspire references to Aspire (#1239)
* docs: rename .NET Aspire references
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Meir Blachman <meirblachman@gmail.com>
---------
Co-authored-by: Meir Blachman <meblachm@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* chore: simplify workflow files by removing .ai-team fallback logic (#1263)
Remove dead .ai-team/ fallback code from workflow templates. The .squad/
directory is the canonical location since the rename — the fallback paths
were never triggered and added unnecessary complexity.
Changes:
- Remove .ai-team/ fallback branches from triage, issue-assign, heartbeat,
and sync-squad-labels workflows
- Clean up empty if-blocks left by fallback removal
- Simplify warning messages to reference only .squad/team.md
- Change let → const for team/routing file paths (no longer reassigned)
- Sync all template copies (.squad-templates/, packages/)
Guard rail checks in squad-preview.yml and squad-promote.yml are preserved
since they legitimately prevent .ai-team/ files from shipping.
Closes #1167
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(routing): strip surrounding quotes from routing.md examples (#1357)
parseRoutingMarkdown kept surrounding quotes on Examples cells, so a quoted example tokenized with the quote glued on and compiled to patterns that never matched, silently routing everything to fallback. Strip leading/trailing quotes so quoted and unquoted examples behave identically. Adds parse and matchRoute regression tests.
Co-authored-by: duau_microsoft <107149404+duau_microsoft@users.noreply.github.com>
* fix(cli): add externalize/internalize to top-level squad --help (#1232)
The top-level `squad --help` command list omitted the externalize and
internalize commands, leaving them undiscoverable. Add both entries
(descriptions sourced verbatim from command-help.ts) plus a regression
test guarding the top-level command list.
Closes #1050
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* deps: bump @types/node from 25.9.4 to 26.0.0 in /packages/squad-cli (#1365)
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 25.9.4 to 26.0.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)
---
updated-dependencies:
- dependency-name: "@types/node"
dependency-version: 26.0.0
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* deps: bump @types/node from 25.9.4 to 26.0.0 in /packages/squad-sdk (#1366)
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 25.9.4 to 26.0.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)
---
updated-dependencies:
- dependency-name: "@types/node"
dependency-version: 26.0.0
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* ci: bump esbuild and tsx in /samples/storage-provider-sqlite (#1380)
Bumps [esbuild](https://github.com/evanw/esbuild) to 0.28.1 and updates ancestor dependency [tsx](https://github.com/privatenumber/tsx). These dependencies need to be updated together.
Updates `esbuild` from 0.27.4 to 0.28.1
- [Release notes](https://github.com/evanw/esbuild/releases)
- [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md)
- [Commits](https://github.com/evanw/esbuild/compare/v0.27.4...v0.28.1)
Updates `tsx` from 4.21.0 to 4.22.4
- [Release notes](https://github.com/privatenumber/tsx/releases)
- [Changelog](https://github.com/privatenumber/tsx/blob/master/release.config.cjs)
- [Commits](https://github.com/privatenumber/tsx/compare/v4.21.0...v4.22.4)
---
updated-dependencies:
- dependency-name: esbuild
dependency-version: 0.28.1
dependency-type: indirect
- dependency-name: tsx
dependency-version: 4.22.4
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* deps: bump @opentelemetry/sdk-trace-base from 1.30.1 to 2.8.0 in /packages/squad-sdk (#1368)
Bumps [@opentelemetry/sdk-trace-base](https://github.com/open-telemetry/opentelemetry-js) from 1.30.1 to 2.8.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md)
- [Commits](https://github.com/open-telemetry/opentelemetry-js/compare/v1.30.1...v2.8.0)
---
updated-dependencies:
- dependency-name: "@opentelemetry/sdk-trace-base"
dependency-version: 2.8.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* deps: bump @opentelemetry/resources from 1.30.1 to 2.8.0 in /packages/squad-sdk (#1369)
Bumps [@opentelemetry/resources](https://github.com/open-telemetry/opentelemetry-js) from 1.30.1 to 2.8.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md)
- [Commits](https://github.com/open-telemetry/opentelemetry-js/compare/v1.30.1...v2.8.0)
---
updated-dependencies:
- dependency-name: "@opentelemetry/resources"
dependency-version: 2.8.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* deps: bump @github/copilot-sdk from 0.3.0 to 1.0.4 (#1361)
Bumps [@github/copilot-sdk](https://github.com/github/copilot-sdk) from 0.3.0 to 1.0.4.
- [Release notes](https://github.com/github/copilot-sdk/releases)
- [Changelog](https://github.com/github/copilot-sdk/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/copilot-sdk/compare/v0.3.0...v1.0.4)
---
updated-dependencies:
- dependency-name: "@github/copilot-sdk"
dependency-version: 1.0.3
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* deps: bump @github/copilot-sdk from 0.3.0 to 1.0.4 in /packages/squad-sdk (#1371)
Bumps [@github/copilot-sdk](https://github.com/github/copilot-sdk) from 0.3.0 to 1.0.4.
- [Release notes](https://github.com/github/copilot-sdk/releases)
- [Changelog](https://github.com/github/copilot-sdk/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/copilot-sdk/compare/v0.3.0...v1.0.4)
---
updated-dependencies:
- dependency-name: "@github/copilot-sdk"
dependency-version: 1.0.3
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* deps: bump cspell from 9.7.0 to 10.0.1 (#1362)
Bumps [cspell](https://github.com/streetsidesoftware/cspell/tree/HEAD/packages/cspell) from 9.7.0 to 10.0.1.
- [Release notes](https://github.com/streetsidesoftware/cspell/releases)
- [Changelog](https://github.com/streetsidesoftware/cspell/blob/main/packages/cspell/CHANGELOG.md)
- [Commits](https://github.com/streetsidesoftware/cspell/commits/v10.0.1/packages/cspell)
---
updated-dependencies:
- dependency-name: cspell
dependency-version: 10.0.1
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* docs(casting): add spoiler-awareness to casting/naming rules (#1196)
* Add spoiler-awareness guideline to casting/naming rules
Squad's casting system allocated character names from fictional universes
but never screened them for plot spoilers. The existing easter-egg rule
only hides the casting *rationale*, not spoiler-bearing names. A name that
encodes a character's later title, role, transformation, or fate can spoil
a user who is mid-way through the source material, since names appear in
plain text across team.md, prompts, and logs.
Adds an always-loaded Name Allocation rule in squad.agent.md and a new
"Spoiler Awareness" section in casting-reference.md (with a scrubbed
motivating example), propagated to all mirrors via sync-templates.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(casting): restore CRLF endings on casting-reference.md to remove false diff
The Spoiler Awareness edit was made on files whose committed blobs use CRLF, but local normalization rewrote them to LF. That made all 104 existing lines appear changed (122 ins / 104 del) and hid the real 18-line addition. Restoring CRLF collapses the diff to the genuine change only (18 insertions, 0 deletions).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* docs(casting): clarify spoiler guidance wording
Address review feedback on the Spoiler Awareness section:
- Use standard spelling 'midway' instead of 'mid-way'.
- Replace the ambiguous 'Never reorganize the casting around the spoiler'
with explicit guidance: keep existing name mappings stable and only
let the next/new allocation pick a different spoiler-safe character.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* chore: add changeset for spoiler-aware casting
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* feat(prompt): slim squad.agent.md by extracting 3 sections to satellite skills (#1311)
* feat(prompt): slim squad.agent.md by extracting 3 sections to satellite skills (#1308 phase 1)
squad.agent.md is loaded as the agent prompt at every Copilot session
start. v0.10.0-insider.1 ships it at 81 KB / 1137 lines and the v0.10
stabilisation pass alone added +10.6 KB / +114 lines. Every byte is
paid at every session.
Phase 1 fix: extract three low-cross-reference, high-byte sections to
satellite skills the coordinator loads on demand via the skill tool —
same pattern that worked for cross-squad-communication (#1295).
- coordinator-init-mode — Init Mode Phase 1 + Phase 2 (5.4 KB)
- coordinator-source-of-truth — Source of Truth Hierarchy (4.4 KB)
- coordinator-response-mode — Response Mode Selection +
Lightweight Spawn Template (3.9 KB)
Result: squad.agent.md 81 KB → 70 KB (-13.9 %, -140 lines). 19 skills
installed at .github/skills/ (was 16). Behaviour unchanged — each
removed section is replaced with a stub naming the trigger condition
and instructing the coordinator to skill(coordinator-X) before acting.
Sections that stay in squad.agent.md (intentional):
- Team Mode + state-backend handshake + HARD RULE — handshake must
fire before any state write
- Routing table — hit on every user prompt
- Hard trigger keyword-to-skill match paragraph (#1307) — load-bearing
- How to Spawn an Agent — referenced from every routing action
- Coordinator Identity / Personal Squad / Memory Governance Tools —
frequently re-read inline
Wired changes:
- New canonical sources at .squad/skills/coordinator-{x}/SKILL.md
plus 2 template-dir mirrors
- MANIFEST_SKILL_NAMES grows by 3 entries (16 → 19)
- TEMPLATE_MANIFEST grows by 3 entries with ../.github/skills/
destinations (post-#1304 install location)
- .squad-templates/squad.agent.md replaces each section with a stub
- 4 mirrored squad.agent.md copies re-synced via
scripts/sync-templates.mjs --sync
Tests: 287/287 pass. The existing 'should install every
manifest-curated skill (regression: bradygaster/squad#1289, #1264)'
already iterates MANIFEST_SKILL_NAMES, so it automatically asserts the
3 new skills install.
Smoke test: fresh squad init produces 19 skills at .github/skills/
and squad.agent.md is 70 KB.
Follow-ups (separate PRs) for the still-large sections:
- Routing (9.2 KB) — extract action-cell verbiage, keep trigger table
- Team Mode (5.5 KB) — extract worktree-awareness sub-sections
- How to Spawn (3.2 KB) — extract role-emoji catalog
Target after 2-3 follow-ups: ~45 KB coordinator file.
Closes #1308 (phase 1).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* test+changeset: follow 'Determine team size' assertion to coordinator-init-mode skill
CI failure on #1311: test/squad-agent-roster.test.ts asserted the
'Determine team size' line is in squad.agent.md.template, but after
#1308 phase 1 that line moved into the coordinator-init-mode skill.
Restructured the test into two describe blocks:
1. squad.agent.md.template — must still keep an Init Mode STUB that
names the coordinator-init-mode satellite skill AND preserves the
load-bearing eager-execution exception callout. This makes sure
future edits can't accidentally drop the satellite reference.
2. coordinator-init-mode/SKILL.md (3 mirrors) — must contain the
'Determine team size' line naming all four built-ins, AND must
mark each of Scribe/Ralph/Rai/Fact Checker as 'exempt from
casting'. The regression coverage from #1299 follows the content.
22/22 tests pass.
Also addressed the changeset review comment: clarified that
.squad/skills/coordinator-*/SKILL.md are the canonical source files
in the squad repo (where every other bundled skill source lives),
and they're copied to .github/skills/ on install/upgrade per #1304.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix: git-add the canonical .squad/skills/coordinator-*/ source dirs (review on #1311)
Reviewer caught a real bug: the new coordinator-* skill source dirs
existed in my worktree but had never been `git add`-ed because
`.squad/` is gitignored on this repo (specific subpaths under it are
exception-tracked). The template mirrors at
packages/squad-{cli,sdk}/templates/skills/coordinator-*/ shipped fine,
but the canonical sources at .squad/skills/coordinator-*/SKILL.md
weren't in the tree — so:
- The changeset claim that .squad/skills/coordinator-*/ is the
canonical source was untrue on dev.
- scripts/sync-skill-templates.mjs would not see the new skills
when run from a fresh checkout, breaking the contributor workflow
(canonical → mirrors). Sync would silently drop the 3 new skills
on the next prebuild.
Force-added the 3 dirs (`git add -f` because of the .squad/ ignore
rule, same as every other tracked skill under .squad/skills/).
Verified: `node scripts/sync-skill-templates.mjs` now lists
coordinator-* among the 26 discovered skills and re-produces the
2 template mirrors byte-identical to the canonical sources.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* test: extractInitMode follows satellite skill + version regex tolerates pre-release tail
Two narrow fixes uncovered while smoke-testing the slim squad.agent.md PR
(#1311) and the 0.10.0-insider.1 release pipeline:
1. test/init-flow.test.cjs — after the Init Mode prose moved from
squad.agent.md to the coordinator-init-mode satellite skill (#1308 /
PR #1311), the structural assertions in 'Init Mode prompt structure
(#66)' had nothing to read in the parent file. They now follow the
pointer via the new readSatelliteSkill() helper (which prefers the
installed copy at .github/skills/<name>/SKILL.md and falls back to
the source repo template at packages/squad-sdk/templates/skills/),
so the same gates (STOP/WAIT, 'Look right?', numbered confirm-before-
create flow, Phase 2 trigger) keep being enforced — just against the
prompt the coordinator actually loads at runtime.
2. test/version-stamping.test.cjs + index.cjs — the version regex
[0-9.]+(?:-[a-z]+)? truncated pre-release versions with a numeric
tail (e.g. 0.10.0-insider.1 → 0.10.0-insider, 0.10.0-build.3 →
0.10.0-build). That made the test 'upgrade detects same version'
fail locally on any contributor who built the package (pkg.version
gets stamped 0.10.0-build.N during build). More importantly it made
the legacy index.cjs upgrade re-run the full upgrade flow for npm-
installed insider users (who have 0.10.0-insider.1 on disk) instead
of printing 'Already up to date'. Widened to
[0-9.]+(?:-[a-z]+(?:\.[0-9]+)?)? — matches everything we already
accepted plus the .N tail used by npm pre-release dist-tags and the
build-time stamping script.
All 133 .cjs tests now pass (was 123 pass / 10 fail before).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(docs): rephrase 'fenced code block' row in skill-security-scanner table
CI failure on dev tip (567f4475, Squad CI run 27488323855):
test/docs-build.test.ts > 'all code blocks are properly fenced (even
count of backticks)' → expected 1 to be 0
test/docs-build.test.ts > 'code blocks contain language specification
or valid content' → expected 1 to be greater than 1
Root cause: a 4-backtick table cell intended to display a literal
triple-backtick:
| Inside a fenced code block (\\\\ \\\ \\\\) | Suppressed |
made the regex /\\\/g see 5 triple-backtick occurrences across the
file (instead of the 2 from the real bash example), tripping both the
even-fence check and the line-count > 1 check.
Rephrased the table to say 'three backticks' / 'single backtick' in
prose — no embedded delimiters, no need to defend against the markdown
fence escape mechanism. Reads cleaner anyway.
Verified locally: 22/22 docs-build tests pass; npm run build in docs/
completes (171 files emitted; pagefind indexes 168 pages, 6911 words).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Tamir Dresher <tamirdresher@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* feat(cli): rename hire to cast (#1394)
The canonical command for adding team members is now 'cast' — we're casting
agents, not hiring humans. 'hire' continues to work silently as an alias
(like cls/clear in PowerShell).
- squad cast (no args) → shows roster (existing behavior preserved)
- squad cast --name X --role Y → launches team creation wizard
- squad hire → always launches the wizard (silent alias)
Updated all CLI help text, README docs, blog posts, SDK templates, and
skill files. Added 'cast' to test expectations while keeping 'hire' in
the recognized-commands list.
Closes #1393
Co-authored-by: brady gaster <bradygaster@github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add OSS release checklist files (#1217)
* Add OSS release checklist files
- CODE_OF_CONDUCT.md (Contributor Covenant v1.4)
- SUPPORT.md (points to GitHub Discussions)
- .github/CODEOWNERS (@bradygaster @tamirdresher)
- README.md: add Requirements, License, Maintainers, Support, Contributing, Code of Conduct sections
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Potential fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Potential fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* feat: add 'squad preset install <source>' for sharing presets via repo URL (#1224) (#1225)
* feat: add 'squad preset install <source>' for sharing presets via repo URL (#1224)
Closes #1224. Adds a new subcommand that installs a single preset from
a GitHub URL or local path into \\/presets/<name>/\ — the
peer-to-peer preset sharing flow that was missing in v0.10.0.
SDK side (squad-sdk/src/presets/index.ts):
- New \installPresetFromSource(source, options)\ function
- Resolves source: GitHub URL → shallow git clone --depth 1 to OS temp;
local path → use as-is
- Locates preset within source via 3 patterns:
- dir contains preset.json → single-preset source
- dir contains presets/ subdir → require --name to pick
- dir IS the presets/ dir → require --name (or auto-pick if only one)
- Validates preset.json before any destructive action
- Copies preset.json (with optional rename) + agents/ into squad home
- Cleans up temp clones in finally block (success or failure)
- Exports: installPresetFromSource, InstallPresetOptions, InstallPresetResult
CLI side (squad-cli/src/cli/commands/preset.ts):
- New 'install' dispatcher case + presetInstall() function
- Supports --name <override>, --force
- Module docstring + default usage help updated to include 'install'
Supported source shapes:
https://github.com/owner/repo
https://github.com/owner/repo#preset-name (frag as subdir hint)
https://github.com/owner/repo/tree/branch/path/... (sub-path)
git\@github.com:owner/repo.git (SSH)
./local/path (single preset OR collection)
Smoke tested all 6 cases locally:
1. Local single-preset → installs under manifest.name ✅
2. Idempotent re-install fails without --force ✅
3. --force overwrites ✅
4. --name renames + updates manifest.name ✅
5. Invalid source → clear error ✅
6. GitHub URL (cloned bradygaster/squad's presets/builtin/default) ✅
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(presets): address 6 review comments — security, validation, fragment semantics, tests, help block
Addresses all six review comments on bradygaster/squad#1225:
1. [security] git clone via execSync was vulnerable to shell injection
because the command was built as a string. Switched to execFileSync
with an argument array (no shell), so source / ref values containing
';' '&&' '|' backticks etc. can no longer be interpreted by a shell.
The earlier ad-hoc whitespace/quote escaping was the wrong defence
layer.
2. [security] nameHint was used in path.join without validation. A value
like '../something' would have escaped the presets/ directory. Added
validatePathSegment() that rejects path separators ('/' '\\'), '..',
'.', null bytes. Applied both at the public installPresetFromSource()
entry AND inside locatePresetWithinSource() as defence-in-depth in
case future callers go direct. Also added validateSubPath() for the
URL-fragment-derived subPath: rejects absolute paths and '..' segments.
3. [correctness] Fragment semantics: 'repo#some-name' (bare fragment, no
slash) was being treated as a literal subPath, so it looked for
<clone>/some-name/ and broke the documented <clone>/presets/some-name/
collection layout from the PR description. Restructured
resolveInstallSource to return a new nameHint field alongside subPath:
- Fragment WITH '/' -> literal subPath (e.g. repo#packs/team-a)
- Fragment WITHOUT '/' -> preset-name HINT (e.g. repo#my-team)
The nameHint is forwarded to locatePresetWithinSource without being
used as a path segment itself, so the common collection layout now
works as advertised.
4. [UX] --name parsing didn't validate that a value was actually
provided. 'squad preset install <src> --name' (no value) or
'--name --force' (next arg is a flag) silently produced undefined or
'--force' as the override and failed downstream with a confusing
error. Added an early fail-fast guard with a clear usage hint.
5. [tests] Added 7 focused tests for installPresetFromSource covering
the new code path:
- single-preset local source (startDir/preset.json present)
- collection local source + --name selection
- collection source without --name throws with helpful message
- --force overwrite of an existing same-name preset
- --name rename + manifest.name stamping (other fields preserved)
- --name path-escape attempts are rejected
- empty source throws 'required'
Remote (URL) branch isn't stubbed here — splitting the git-clone
call into a small helper that tests can mock is a separate follow-up.
6. [docs] preset help block in command-help.ts still printed
Usage: squad preset <list|show|apply|save|init> without 'install'.
Updated to include 'install <source>', the new --name option, and a
concise documentation of the fragment semantics from fix #3.
Verified locally: 36/36 preset tests pass (29 existing + 7 new);
14/14 command-help tests pass.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Tamir Dresher <tamirdresher@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix: update adapter/client.ts for @github/copilot-sdk 1.0.4 API changes (#1403)
* fix: update adapter/client.ts for @github/copilot-sdk 1.0.4 API changes
- Replace removed cliPath/cliArgs/useStdio/port/cliUrl options with RuntimeConnection
- Update ping() return type from timestamp: number to timestamp: string
- Make SquadModelBilling.multiplier optional to match upstream ModelBilling
- Replace client.on() with client.onLifecycle() for lifecycle events
Unblocks Dependabot PRs #1364 and #1370 which surface these type errors.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix: update test mocks for @github/copilot-sdk 1.0.4 API changes
- Add RuntimeConnection and onLifecycle to all 4 copilot-sdk test mocks
- Fix command-help.test.ts expected commands list (remove stale entries)
- Regenerate package-lock.json after merging dev (OTel dep alignment)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: brady gaster <bradygaster@github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* deps: bump @opentelemetry/sdk-metrics and sdk-trace-node to 2.8.0 (#1404)
Bumps both OpenTelemetry SDK packages from 1.x to 2.8.0:
- @opentelemetry/sdk-metrics: ^1.30.0 → ^2.8.0
- @opentelemetry/sdk-trace-node: ^1.30.0 → ^2.8.0
The createGauge API is still supported in SDK 2.x — no code changes
needed. All OTel tests and SDK export validations pass.
Closes #1364, Closes #1370
Co-authored-by: brady gaster <bradygaster@github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(cli): pin squad-sdk to workspace:* (fixes prerelease build crash) (#1406)
* fix(cli): pin squad-sdk workspace dependency
Closes #1405
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Fix CLI SDK workspace resolution
Closes #1405
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Fix green test suite (#1416)
* Fix green test suite
Align local test expectations with current personal squad paths, stabilize observer file category detection, skip unavailable docs/Aspire capabilities, and add the missing OTel context test dependency.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Fix observer review hardening
Closes #1416
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Stage 0.11.0 release (#1420)
Prepare clean 0.11.0 package versions and CHANGELOG notes for release staging.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Guard symlink test for Windows/restricted environments (#1418)
* fix(test): guard observer symlink setup
Handle restricted symlink creation in the observer symlink test so Windows and locked-down environments can continue the suite.
Refs #1416
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Address symlink test review feedback
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add tools: ["*"] to Squad coordinator agent template (#1424)
Without this field, Copilot CLI 1.0.66+ interprets the missing tools key as tools: [], so the Squad coordinator loads with no built-in tools (shell, view, edit, grep, glob) and only MCP-exposed tools (skill, sql) remain available. Basic operations like listing files or editing fail.
Setting tools: ["*"] in the canonical .squad-templates/squad.agent.md and mirrored copies (top-level templates/, packages/squad-cli/templates/, packages/squad-sdk/templates/) restores the previous behavior of exposing all built-in tools to the coordinator. .github/agents/squad.agent.md is intentionally left out of this PR.
Resolves the architectural-review nudge: sync-templates.mjs treats .squad-templates/ as canonical; mirrors are bundled into the published npm packages, so all of them must carry the fix for the next release to ship correctly.
* fix(sdk): allow identity/* state writes and widen squad_decide author validation (#1419)
* fix(sdk): allow identity/* state writes and widen squad_decide author validation
- add identity/ to the mutable-state allowlist (Closes #1255)
- relax squad_decide author regex with a 200-char cap; slugify author
for the inbox filename while preserving the raw display name (Closes #1256)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(sdk): address Copilot review — reject empty author slug, report real filename
Closes #1255
Closes #1256
Add empty-slug guard: authors that slugify to empty string (e.g. ' ', '()', '---', '...') now return a failure instead of writing a malformed filename. Fix success message to report the actual slugified filename written on disk instead of the raw author string.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix: remove duplicate cast entry in squad -h output (#1428)
* fix: remove duplicate cast entry in squad -h output
Consolidate the two 'cast' help entries into a single entry with unified
description showing it displays the current session cast (project + personal
agents) and accepts --name/--role flags for adding agents.
Closes #1423
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* chore: add changeset for cast help fix
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* style: fix indentation on cast usage line
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(presets): round-trip routing.md in preset save/apply (#1429)
* fix(presets): round-trip routing.md in preset save/apply
savePreset now captures .squad/routing.md into the preset snapshot.
applyPreset restores the saved routing.md before scaffolding so that
custom label tables, module ownership mappings, and other routing
rules survive the save/apply cycle.
Closes #1412
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(presets): address review - overwriteRouting option and truthiness checks
- Add overwriteRouting option to applyPreset so callers (e.g. squad init
--preset) can replace an existing skeleton routing.md with the preset's
saved version without forcing agent overwrites.
- Use !== undefined instead of truthiness for readSync results so
intentionally-empty routing.md files are faithfully round-tripped.
- Add regression test for overwriteRouting replacing existing skeleton.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(cli): pin squad-sdk dependency (#1431)
* fix(cli): pin squad-sdk dependency
Ensure published squad-cli installs require the matching squad-sdk version so APIs introduced in 0.11.0 cannot be paired with an older SDK.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Potential fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* fix: use >=0.11.0 range and add missing export assertions
- Change SDK dep from ^0.11.0 to >=0.11.0 to survive lockstep minor bumps
- Add readSquadRegistry, addRegistryEntry, removeRegistryEntry to
cross-package exports test (also 0.11.0-only CLI imports)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: brady gaster <bradygaster@github.com>
* deps: bump astro from 6.4.7 to 7.0.3 in /docs (#1409)
Bumps [astro](https://github.com/withastro/astro/tree/HEAD/packages/astro) from 6.4.7 to 7.0.3.
- [Release notes](https://github.com/withastro/astro/releases)
- [Changelog](https://github.com/withastro/astro/blob/main/packages/astro/CHANGELOG.md)
- [Commits](https://github.com/withastro/astro/commits/astro@7.0.3/packages/astro)
---
updated-dependencies:
- dependency-name: astro
dependency-version: 7.0.3
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat(sdk,cli): thread contextTier through agent spawning pipeline (#1448)
* feat(sdk): thread contextTier through agent spawning pipeline
Adds a contextTier concept (default vs long_context / 1M context window)
threaded end-to-end through the SDK and CLI, mirroring the reasoningEffort
plumbing from #1148. Models expose supportedContextTiers/defaultContextTier;
requests validate and clamp against what a model supports. Adds the
'squad config context-tier' CLI subcommand and coordinator guidance.
Closes #1446
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(sdk): simplify clampContextTier guard to match clampReasoningEffort (addresses PR review)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Fix doctor decisions check for two-layer state (#1434)
* Fix doctor decisions check for two-layer state
Closes #1433
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Add orphan doctor coverage
Address review feedback by exercising the orphan backend decisions.md path alongside two-layer and git-notes.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Improve doctor backend fallback message
Address review feedback by reporting the resolved backend when doctor cannot inspect the configured squad-state backend.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Normalize doctor hook backend detection
Address review feedback by applying legacy backend alias normalization before deciding whether sync hooks are required.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Fix docs build for Astro markdown plugins
Declare Astro's legacy markdown processor package and avoid running the expensive docs build twice in the same test.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* chore: add auto version-promote workflow for dev branch (#1457)
After a release is published from main, this workflow automatically
bumps the dev branch to the next minor version (e.g., 0.11.0 -> 0.12.0).
Addresses #1455
Co-authored-by: Copilot <Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(templates): resolve GitHub API host from env in ralph-triage.js (#1438)
ralph-triage.js hardcoded hostname: 'api.github.com' in its
https.request() call, so Squad Heartbeat (Ralph) failed with a 401 on
GitHub Enterprise — the GITHUB_TOKEN there is only valid against the
enterprise API host, not github.com.
Added resolveGithubApiBase(), which picks the API base in order:
GITHUB_API_URL (set by Actions on both github.com and GHE runners),
then GITHUB_SERVER_URL + /api/v3, then https://api.github.com as a
last-resort fallback. The request is now built from a URL object
instead of a hardcoded hostname/path pair. No behavior change on
github.com-hosted repos.
Fixed in the canonical .squad-templates/ralph-triage.js and synced to
the 3 mirror targets. Added unit tests covering all three resolution
branches.
Documented the env var resolution order in the CI/CD integration docs
so GHE users can discover it.
Closes #1142
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(cli): resolve externalized state in squad export (#1443)
After `squad externalize` moves team state out of the working tree,
`squad export` still read directly from the local .squad/ directory via
detectSquadDir(). Depending on what remained locally, it either died
with the misleading "No squad found — run init first" (the marker-only
.squad/ has no team.md) or silently exported stale/re-scaffolded local
files instead of the real team knowledge in the external state dir —
a corrupt backup that reports success.
Route export through effectiveSquadDir(), the same external-state-aware
resolution already used by build, loop, plugin, watch, and doctor. All
state reads (team.md, decisions.md, routing.md, casting/, agents/, and
.squad-local skills) now come from the effective state directory; the
existence check and manifest build both use it. Working-tree skill
sources (.copilot/skills, .ai-team/skills) are unchanged, as is legacy
.ai-team behavior (no external marker there, resolution falls through
to the local path).
Added two regression tests that fail without the fix: one exporting
from a marker-only externalized project (previously fatal), one
proving external state wins over stale local files when the
stateLocation marker is set (previously exported the stale copy).
Fixes #1396
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(init): include proposed roster in confirmation prompt (#1460)
Make the blocking ask_user question self-contained by reusing every
exact step-4 roster line (universe, members, roles, scopes) so users
can review the team even when preceding assistant output is hidden.
Closes #1454
Co-authored-by: Kartik <kartikkabadi@users.noreply.github.com>
* Refresh model catalog to CLI-reachable IDs and prune dead fallback chains (#1444)
* fix(models): refresh catalog to CLI-reachable IDs and prune dead fallbacks
Replace the model catalog with the 13 GitHub Copilot CLI-reachable models
(copilot-cli integration set) and remove IDs no longer offered
(gpt-4.1, gpt-5, gpt-5.1*, gpt-5.2*, gemini-3-pro-preview, claude-sonnet-4,
claude-opus-4.5, claude-opus-4.6-fast). Update runtime + SDK fallback chains,
schema defaults, and the economy-mode map to real IDs, fixing routing that
referenced retired models.
Add an optional githubCategory cost-ceiling field (lightweight/versatile/
powerful) sourced from the models API model_picker_category, kept as a
separate axis from the existing quality tier. No hardcoded per-token pricing
is added for new entries and no included/zero-credit flag is introduced.
Add catalog-refresh invariant tests: no dead IDs in chains; every chain ID
exists in the catalog; gpt-5 is treated as dead (verified absent from the
Copilot models API and the public github/docs pricing YAML); and the
MODEL_CATALOG ID set exactly equals the expected curated 13-ID seed so any
unexpected reintroduction fails. Update existing model/economy/config tests.
Refs #1080
Refs #1183
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(templates): sync shipped prompt/template assets + CLI strings to refreshed model catalog
Addresses the reviewer correctness note on PR #1444: shipped prompt/template assets
still referenced model IDs removed from the runtime catalog by the catalog-refresh
commit (f5479b0f), meaning generated squads could steer real agent spawns toward
unreachable IDs. Fixes all occurrences across canonical sources; sync scripts
propagate the changes to the 10 auto-generated copies.
Template/skill canonical source fixes (4 sources → 10 synced copies):
- .squad-templates/model-selection-reference.md: claude-opus-4.5→4.6 (Visual role +
Premium chain + spawn example), remove claude-sonnet-4 from Standard chain, remove
gpt-5.1-codex-mini+gpt-4.1 from Fast chain, gemini-3-pro-preview→gemini-2.5-pro
(analytical diversity switch), Valid-models section refreshed to 13-ID catalog
- .squad-templates/ralph-circuit-breaker.md: remove gpt-4.1 from multiplier table,
OPEN-state fallback list, JSON/PS state examples, and config reference table
- .squad/skills/model-selection/SKILL.md: remove claude-opus-4.6-fast+claude-opus-4.5
from Premium chain, claude-sonnet-4 from Standard chain, gpt-5.1-codex-mini+gpt-4.1
from Fast chain (fallback chains section only — lines 119-121)
- .squad/skills/economy-mode/SKILL.md: gpt-4.1→gpt-5-mini throughout economy table,
claude-opus-4.5→claude-opus-4.6 (Normal Mode premium row), remove "Prefer gpt-4.1
over gpt-5-mini" paragraph
Manual edit (outside sync path):
- .copilot/skills/model-selection/SKILL.md: same chain fixes as model-selection SKILL
plus gemini-3-pro-preview→gemini-2.5-pro, claude-opus-4.5→4.6 (Visual role + task
table), gpt-5.2-codex→gpt-5.3-codex (Layer 1 example + Example 3), Valid-models
section refreshed
CLI user-facing display string fixes (4 files, dead token only):
- packages/squad-cli/src/cli/commands/economy.ts: gpt-4.1→gpt-5-mini (×2, economy
downgrade display — matches ECONOMY_MODEL_MAP already updated in f5479b0f)
- packages/squad-cli/src/cli/shell/error-messages.ts: gpt-4.1→gpt-5-mini (rate-limit
recovery suggestion)
- packages/squad-cli/src/cli-entry.ts: claude-sonnet-4→claude-sonnet-4.6 (start help
example)
- packages/squad-cli/src/cli/core/command-help.ts: claude-sonnet-4→claude-sonnet-4.6
(start help example)
Test: expand DEAD_MODEL_IDS in test/catalog-refresh.test.ts to include claude-opus-4.5
and claude-opus-4.6-fast (live-but-dropped-from-seed for runtime chains, but dead in
practice for template guidance). Add new `describe` block "template asset catalog
invariants" that globs .squad-templates/**/*.md, .squad/skills/**/*.md, and
.copilot/skills/**/*.md at test time, scanning each for dead IDs with a
(?![-.\d]) lookahead to prevent gpt-5 from matching gpt-5-mini or gpt-5.4.
All 7 catalog-refresh invariants GREEN. `npm run lint` clean.
Refs #1080, #1183
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(review): add fallback-degradation tests, sonnet ordering comments, and catalog warning
B1: add describe block in test/compat-v041.test.ts asserting getNextFallback
for removed IDs ('gpt-4.1', 'claude-sonnet-4') resolves to a live catalog
model and does not throw.
A1: add inline comments in packages/squad-sdk/src/config/models.ts and
packages/squad-sdk/src/runtime/constants.ts explaining why claude-sonnet-4.6
precedes claude-sonnet-5 in the standard fallback chain (established default
with known pricing vs newer model with no tracked pricing yet).
A3: in validateConfigDetailed (packages/squad-sdk/src/runtime/config.ts),
push a non-blocking warning when config.models.defaultModel is a non-empty
string not present in MODEL_CATALOG. Existing configs with dead IDs still
load — a warning is emitted, not an error. Test added to
test/config-integration.test.ts.
Changeset: fold A3 mention into .changeset/refresh-model-catalog-1080.md.
Addresses reviewer feedback on bradygaster/squad#1444.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(review): correct A1 comment — ordering is MODELS.DEFAULT primacy only
Both claude-sonnet-4.6 and claude-sonnet-5 carry identical cost: 5 /
speed: 7 metadata. The previous comment overstated the pricing angle.
The sole code-backed reason for 4.6 leading the standard chain is that
it is MODELS.DEFAULT (the established primary); sonnet-5 was newly added
in this catalog refresh and is first fallback.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* feat(platform): add setAssignee() to PlatformAdapter (GitHub + ADO) (#1413)
Routes assignee changes through the adapter instead of inline gh/az calls in watch. Adds GitHub + ADO impls, refactors editWorkItem, tests + changeset.
Co-authored-by: OrenMaoz <ormaoz@microsoft.com>
* refactor(cli): consolidate duplicated agent-spawn logic across watch capabilities (#1437)
execute.ts and wave-dispatch.ts each carried their own copy of
buildAgentCommand() and a spawn-with-timeout helper, diverging from the
shared agent-spawn.ts module added for #920/#923 because they needed
the withAdditionalMcpConfig wiring. Extract a buildCopilotCommand()
helper and extend spawnAgent() with optional pid-tracking so both
capabilities import from the shared module instead of keeping local
copies. As a side effect, execute's Copilot spawn now goes through the
same Windows cmd.exe argument-escaping path as the rest of watch.
Fixes #994
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* ci: pin GitHub Actions references to full-length commit SHAs (#1442)
Every uses: reference across .github/workflows/*.yml (and the local
setup-squad-node composite action they call into) pointed at a
floating version tag (@v7, @v6, etc.) instead of an immutable commit
SHA. Orgs that require SHA-pinned actions as a supply-chain policy
can't adopt Squad's shipped workflows without hand-patching them,
and re-patching again on every squad upgrade.
Resolved each of the 10 unique action@tag pairs in use to its current
commit SHA via the GitHub API and rewrote every uses: line to
owner/repo@<sha> #vX, keeping the original version as a trailing
comment for readability/auditability. The two ./.github/actions/...
local action references are untouched — they have no tag to pin,
they're already pinned by living in-repo.
Also pinned the same 10 shipped workflow templates (squad-ci.yml,
squad-docs.yml, squad-heartbeat.yml, squad-issue-assign.yml,
squad-label-enforce.yml, squad-preview.yml, squad-promote.yml,
squad-release.yml, squad-triage.yml, sync-squad-labels.yml) across
all 4 template locations (.squad-templates/ canonical source, plus
its 3 synced mirrors: templates/, packages/squad-cli/templates/,
packages/squad-sdk/templates/) so squad init/upgrade ships pinned
workflows too, not just this repo's own dogfooded copies. These
templates use older tags than .github/workflows (checkout@v4 vs v7,
github-script@v7 vs v9, etc.) — pinned each to its own existing tag
rather than silently bumping versions, since a version bump is a
separate concern from pinning. squad-insider-release.yml (template)
was left untouched: it has no .github/workflows counterpart, it's a
distinct downstream-only workflow (different triggers/jobs/permissions
entirely, not a sync pair with squad-insider-publish.yml).
61 files, 172 lines changed, no other content touched. Verified all
changed workflow/action YAML still parses with js-yaml. Added a
changeset since this now touches governed template paths.
Fixes #1441
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(cli): patch repo-local node_modules on upgrade, check commit hooks in doctor (#1463)
The postinstall ESM patcher returned at the first search root that already
had a patched copy, so on global installs the consumer repo's node_modules
was never reached — the cwd entry added to SEARCH_ROOTS in 2d9f0b4e was
effectively dead code. The patcher now patches every root it finds, and
squad upgrade re-runs it against the repo's own node_modules via
runEnsureChecks, covering both the normal and already-current paths.
squad doctor's hook check now includes pre-commit/post-commit (the hooks
that guard and flush two-layer state) for two-layer/orphan backends,
matching the full set install-hooks.ts installs, instead of only the four
sync hooks.
Part of #1190
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(cli,sdk): follow externalized state in squad cast agent discovery (#1465)
squad externalize writes teamRoot '.' plus the stateLocation marker, so
an externalized repo lands in resolveSquadPaths' remote mode with a
repo-local teamDir — squad cast then probes <repo>/.squad/agents, which
after externalize is a marker dir holding stale leftovers or nothing.
The real agents live at <externalStateDir>/agents with no .squad
nesting, a shape LocalAgentSource's probing can't reach from any base
path.
LocalAgentSource gains an optional explicit agents directory that wins
over the .squad/agents probing (additive, existing callers unchanged),
and cast passes <externalStateDir>/agents when the marker is set.
resolveExternalStateDir is imported from the /resolution subpath the
command already uses — pulling the sdk root barrel into cast.ts added
seconds to the module load and tripped the cast test suite's 5s timeout.
Fixes #1399
Part of #1402
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* docs: align external-state page with actual externalize/internalize behavior (#1466)
The page promised gitignore behavior the code never had: externalize
only ignores .squad/config.json (the machine-specific marker), not all
of .squad/, and internalize doesn't touch .gitignore at all. The marker
example was also missing the version/teamRoot/projectKey fields the
command actually writes, the stateLocation table listed an "internal"
value that is never written (absence means internal), and the git
status sample showed a gitignored file as untracked, which git doesn't
do. Internalize copies state back rather than moving it — the external
copy stays in place (#1401 tracks whether that should become a move).
Documents current behavior only, no code change.
Fixes #1400
Part of #1402
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* docs/models: prefer newest per series (Opus 4.8), add GPT-5.6 IDs, fix Ralph free-model wording (#1469)
* docs/models: prefer newest per series (Opus 4.8 + Sonnet 5), add GPT-5.6 IDs, fix Ralph free-model wording
Follow-up to bradygaster/squad#1444 (merged), addressing tamirdresher's
three explicit requests in https://github.com/bradygaster/squad/pull/1444#issuecomment-4954513635
(refs #1080, #1183).
Item 1 — Prefer newest model per series (fallback ordering):
- packages/squad-sdk/src/config/models.ts: DEFAULT_FALLBACK_CHAINS.standard
now leads with claude-sonnet-5 (was claude-sonnet-4.6).
- packages/squad-sdk/src/runtime/constants.ts: MODELS.FALLBACK_CHAINS.standard
same reorder. Premium chains already led with claude-opus-4.8 post-#1444.
- model-selection-reference.md, SKILL.md files: examples now show
claude-opus-4.8 first in Premium, claude-sonnet-5 first in Standard.
Item 2 — Add GPT-5.6 model IDs (gpt-5.6-sol, gpt-5.6-terra, gpt-5.6-luna):
- Added to MODEL_CATALOG in models.ts (tier: standard, githubCategory: powerful
— mirrors gpt-5.5 sibling entry).
- Added to DEFAULT_FALLBACK_CHAINS.standard and MODELS.FALLBACK_CHAINS.standard
(after claude-sonnet-4.6, before gpt-5.4).
- Reachability: CLI-observed as Standard-tier reachable models (2026-07-13).
- NOTE: gpt-5.6 entries in DOCS_NAME_TO_ID (cli/commands/models.ts) are
deferred until draft PR #1445 merges (that file is in #1445's diff).
- Updated Valid Models in all model-selection-reference.md + SKILL.md copies.
Item 3 — Ralph circuit-breaker free-model wording:
- .squad-templates/ralph-circuit-breaker.md: replaced multiplier table
(0x / "Free — unlimited") with usage-based framing (lightweight category —
lowest-cost, still billed). Updated preferredModel example to claude-sonnet-5.
- Synced to all 3 template targets via sync-templates.mjs.
NOTE: MODELS.DEFAULT (claude-sonnet-4.6) is intentionally left unchanged.
That global default is out of scope for this PR — can be a separate decision.
TDD: test/catalog-refresh.test.ts — wrote failing tests first (8 RED), then
implemented changes. Final result: 16/16 tests GREEN.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(models): sync full Standard chain in doc/skill examples; add changeset
Address Copilot review comments on PR #1469:
- 3 doc/skill files had abbreviated Standard fallback chain (omitting
gpt-5.6-terra, gpt-5.6-luna, gemini-2.5-pro). Now matches the full
SDK runtime chain exactly:
claude-sonnet-5 → claude-sonnet-4.6 → gpt-5.6-sol → gpt-5.6-terra
→ gpt-5.6-luna → gpt-5.4 → gpt-5.3-codex → claude-sonnet-4.5
→ gemini-2.5-pro → (omit model param)
Files: .squad-templates/model-selection-reference.md,
.copilot/skills/model-selection/SKILL.md (manual),
.squad/skills/model-selection/SKILL.md (sync canonical)
Synced to all 3 template targets + 2 skill package targets.
- Premium chain confirmed correct (claude-opus-4.8 first) — no change
needed.
- Add .changeset/models-gpt56-fallback-ordering.md (@bradygaster/squad-sdk
patch) to satisfy Changelog Gate CI check.
16/16 catalog-refresh tests remain GREEN.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* test: update stale standard-chain[0] assertions to claude-sonnet-5
Three test files hard-coded the old fallback chain head (claude-sonnet-4.6)
that was intentionally reordered in the parent commit (newest-per-series
first, tamirdresher PR #1444 follow-up). The tests remain logically correct
— they now assert the NEW intended behavior.
- test/compat-v041.test.ts: standard[0] → 'claude-sonnet-5'
- test/models.test.ts: standard[0] → 'claude-sonnet-5'
- test/agents.test.ts: standard fallback chain toEqual updated
(reordered + added gpt-5.6-sol/terra/luna)
Inline comment added to each noting the deliberate reorder.
Pre-existing failures (cli-packaging-smoke, init-scaffolding) are EBUSY
file-lock errors unrelated to these changes — confirmed on baseline.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(models): correct gpt-5.6 billing categories to match live Copilot API
Live API (canonical) returns: sol=powerful, terra=versatile, luna=lightweight.
Original seed incorrectly set all three to 'powerful' (mirroring gpt-5.5).
Tier (standard) and fallback-chain membership are unchanged; only githubCategory
(the cost-policy billing axis) is corrected.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* deps: bump the minor-patch group across 1 directory with 22 updates (#1451)
---
updated-dependencies:
- dependency-name: "@github/copilot-sdk"
dependency-version: 1.0.5
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: minor-patch
- dependency-name: "@opentelemetry/context-async-hooks"
dependency-version: 2.9.0
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: minor-patch
- dependency-name: "@opentelemetry/exporter-metrics-otlp-grpc"
dependency-version: 0.220.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: minor-patch
- dependency-name: "@opentelemetry/exporter-trace-otlp-grpc"
dependency-version: 0.220.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: minor-patch
- dependency-name: "@opentelemetry/resources"
dependency-version: 2.9.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: minor-patch
- dependency-name: "@opentelemetry/sdk-metrics"
dependency-version: 2.9.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: minor-patch
- dependency-name: "@opentelemetry/sdk-node"
dependency-version: 0.220.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: …
chore: promote preview -> main (v0.13.0)
…ssing-dir fix: sync-skill-templates exits 0 when .squad/skills absent
…all fixes Complete the 0.13.0 release notes to cover: - The gh-aw install contract fix (#1887) and full hardening wave - squad-deps-worker new dependency manifest worker - Activation pin drift guard and auto-update on release - All workflow router, dispatch, and planning lifecycle fixes - CLI: squad health, watch stop signals, externalized state, archival, CRLF - SDK: scheduler Windows paths, FSStorageProvider rootDir, ADO URL decode Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
docs(changelog): expand 0.13.0 release notes (main)
* fix(gh-aw): bound activation label capacity and make truncation explicit (#1961) (#1964)
* fix(gh-aw): prevent silent truncation of activation label operations
Working as FIDO (Quality Owner).
A 50-issue activation could lose `add_labels` operations while the run still
reported success. Two causes:
1. `add-labels: max: 80` was below the worst case under the reading gh-aw's own
injected prose invites. The compiler emits "Maximum {max} label(s) can be
added", which reads as a budget of label NAMES; a full 50-issue activation
applying `squad` + `squad:{agent}` needs 100. An agent taking that phrasing
literally could conclude it had overrun and stop labeling early or batch
issues together.
2. gh-aw v0.87.10 drops an over-limit item rather than failing. Its collector
(`collect_ndjson_output.cjs`) rejects the item and `continue`s, pushing a
string into `errors`; those are emitted with `core.warning`, never
`core.setFailed`. The run finishes green with label operations missing and
nothing announces it.
Verified against the pinned runtime rather than inferred: `max` caps safe-output
ITEMS (tool calls) per type, not label names inside a call. A two-label call
costs one item.
Capacity: largest supported activation is 50 issues (`enterprise` profile
`max_issues: 50`, the highest documented profile limit, and the same threshold
`squad-plan-activate` uses to force phased activation). Worst case at that size
is 50 `create-issue` items, 50 `add_labels` calls, <=2 labels per call, 100
label names across the run.
Changes:
- `add-labels: max` 80 -> 110, sized to cover the worst case under BOTH readings
(50 calls, 100 names) so no interpretation of the cap can justify dropping a
label operation. `create-issue` stays at 75.
- Record the derivation and the item-vs-label-name semantics in the activation
skill, plus the fact that an over-limit item is dropped, not failed.
- New Step 2e Label-Operation Reconciliation: track `activated` vs `labeled`,
count a never-made/rejected/errored call as unlabeled, and on shortfall call
`report_incomplete` naming the affected work items. gh-aw treats that as a
failure signal even on successful exit, so a truncated activation can no
longer be recorded as clean. Cap exhaustion becomes a nameable cause when
observed; #1683's rule against guessing at caps is preserved and narrowed.
Tests: `test/gh-aw-activation-capacity.test.ts` (27) covers the derived maximum,
capacity under both readings, at-maximum and one-over boundaries, and the
reconciliation contract. Compiled-artifact assertions prefer runtime evidence
over prose: the declared cap reaching `GH_AW_SAFE_OUTPUTS_CONFIG`, the injected
constraint carrying the same number, `report_incomplete` being present (and so
callable), and agent-job permissions staying `issues: read`. Fails closed if
`gh aw` is absent, per #1834. Mutation-checked: reverting the cap to 80 fails 4.
No changes to temporary-ID linkage (#1962), fast-path parity (#1959), label
result reporting (#1963), broad contract coverage (#1960), or E4 (#1958).
Step 2e is deliberately neutral about how `add_labels` identifies its target so
it does not conflict with #1962.
Closes #1961
Parent #1957
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): correct runtime claims in activation capacity safeguards
Independent review found three factual defects in the prose and tests
shipped by the first commit. All three are corrected against the pinned
gh-aw v0.87.10 sources rather than gh-aw's own injected descriptions.
1. `report_incomplete` does NOT make the run conclude non-successfully.
`report_incomplete_handler.cjs` emits `core.warning` only, and
`handle_agent_failure.cjs` contains zero `setFailed`/`process.exit`
calls in 4453 lines. What it actually does is open or update a durable
`[aw] {workflow} reported incomplete result` tracking issue. Step 2e
now states that, says the run still reports success, and tells the
agent never to rely on a red run to carry the signal. gh-aw's own tool
description ("treated as a failure signal even when the agent exits
successfully") is misleading; trusting it was exactly the injected-prose
mistake #1961 exists to prevent.
Limitation, stated honestly: no narrow mechanism in the pinned runtime
makes an incomplete activation conclude red. Forcing one would require
a custom safe-job, which is outside this issue's scope. The durable
tracking record plus the "never report a clean activation you did not
perform" rule are what carry the signal.
2. Cap enforcement is dual, not collection-only. Per Safe Outputs MCE4,
`enforcePerTypeMax` in `safe_outputs_handlers.cjs` throws JSON-RPC
`E002: {type} limit reached` at invocation time, which the agent DOES
see; the collector then drops surplus items with a warning. Removed the
claim that an over-limit item "never appears as an error to the agent".
Reconciliation still keys on absence-of-success, not presence-of-error,
because a call can also simply never be made.
3. The old `max: 80` did not cause runtime truncation — 50 calls never
reached it. The real hazard is gh-aw's injected "Maximum 80 label(s)
can be added" wording against a 100-label worst case, which invites
agent self-truncation. 110 is justified by that hazard plus bounded
margin, and the docblock now explicitly records what is NOT claimed.
Also, per the PR #1965 review: Step 2e no longer demands a real issue
number for items created during the run. Issue creation is deferred to
the post-agent job, so it names the stable temporary ID plus title and
intended labels, and quotes a real number only for a reused issue —
avoiding reintroduction of #1962's invalid-number assumption.
Tests: renamed the two overclaiming tests and gave each a negative guard
that fails if the retracted wording returns; added coverage for the
temporary-ID rule. Trimmed prose to stay under the existing 160 KB
source-growth guard rather than raising another test's budget.
Verified: 221/221 across the three gh-aw suites; mutation-checked (cap
-> 80 fails 5 tests incl. the compiled-runtime one, reintroducing either
retracted claim fails its guard); strict compile clean on all four
workflows; npm run build passes.
Closes #1961
Parent #1957
Working as FIDO (Quality Owner)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 2471face-3b27-4419-bd48-0becd2642d7f
* test(gh-aw): use explicit .js extension on helper import
Addresses Copilot review on PR #1964. The reviewer is correct on both counts.
`tsc --module nodenext --moduleResolution nodenext` reports exactly one error
on this file, and TypeScript names the fix itself:
test/gh-aw-activation-capacity.test.ts(94,46): error TS2835: Relative import
paths need explicit file extensions in ECMAScript imports when
'--moduleResolution' is 'node16' or 'nodenext'. Did you mean
'./helpers/gh-aw-lock.js'?
The repo is `"type": "module"` with `module`/`moduleResolution: NodeNext` in the
root tsconfig, and the four other suites importing this helper already use the
`.js` specifier. This file was the lone outlier; it now matches.
Verified: 293/293 across all eight suites that import the helper, all four
workflows compile with `--strict` (pre-existing warnings only), `npm run build`
passes, and the NodeNext type-check on this file is now clean.
Refs #1961. Parent #1957.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 2471face-3b27-4419-bd48-0becd2642d7f
* fix(workflows): state Step 2e counts as accepted operations, not applied labels
Copilot review flagged that Step 2e's reconciliation claimed issues
"received their labels". #1963 (now merged to dev) settled the
vocabulary: an accepted safe output is queued this turn and applied by
the post-agent job, so the agent has evidence only that a call was
accepted for a specific target -- never that a label reached GitHub.
Step 2e was the remaining place still asserting application, which
conflicts with the accepted-vs-applied rule the same skill now states.
- `labeled` is defined as issues whose add_labels call was accepted.
- The report_incomplete reason reads "had a label operation accepted".
- "proof that every label landed" -> "every label operation was accepted".
- Added an explicit statement that the counts track label operations,
not labels present on GitHub.
Tests: new assertion guards the positive and both retired over-claim
phrasings; verified by reverting the prose (1 failed, 28 passed) rather
than assuming. Tightened the sibling assertion to match the exact count
definitions -- the previous `.*`-joined form matched a distant
"was accepted" elsewhere in the flattened skill and so failed to detect
a reverted definition.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0515ad5d-4c5b-48bb-92a6-4e1296594cab
* test(gh-aw): anchor the false-success assertion, which was vacuous
Copilot review caught that the regex ended in an `|activated.*artifact`
alternative. Alternation binds loosest, so the whole pattern collapsed to
that branch and matched any mention of the artifact -- the test would
have passed with the `labeled < activated` condition deleted from the
prose, which is the entire invariant it names.
Anchored to the full sentence and verified by mutation: removing the
condition from Step 2e now fails (1 failed / 28 passed) where it
previously passed.
Second instance of this defect class in this suite; the sibling count
assertions were tightened in 4ec89dde for the same reason. Audited the
remaining alternations here -- `/finish green|still succeeds/` is
legitimate (two accepted phrasings, both specific).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0515ad5d-4c5b-48bb-92a6-4e1296594cab
---------
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 2471face-3b27-4419-bd48-0becd2642d7f
Copilot-Session: 0515ad5d-4c5b-48bb-92a6-4e1296594cab
* docs: add .squad/templates/README.md — runtime inputs vs bootstrap templates (#1949)
* docs: add .squad/templates/README.md — runtime inputs vs bootstrap templates
Add a README.md template that ships with squad init to explain which files
under .squad/templates/ are runtime inputs (coordinator reads them on-demand)
vs bootstrap templates (used once to seed agent files). Register it in the
TEMPLATE_MANIFEST so it lands in every generated project and is kept current
by squad upgrade.
Also drop a copy of the README into this repo's .squad/templates/ directly.
Closes #1494
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(templates): make templates README reach squad init output
Copilot review on #1949 found that registering `templates-readme.md` in
TEMPLATE_MANIFEST does not put the README into `squad init` output. Verified:
`squad init` seeds `.squad/templates/` with a verbatim recursive copy of the
SDK templates directory (`copyRecursiveSync(getSDKTemplatesDir(), ...)` in
packages/squad-sdk/src/config/init.ts), so a file only reaches new projects if
it lives in that directory under its final name. The README existed only as
`packages/squad-cli/templates/templates-readme.md`, so new projects got nothing.
Promote the file to the canonical source `.squad-templates/README.md` and let
scripts/sync-templates.mjs mirror it to templates/, packages/squad-cli/templates/
and packages/squad-sdk/templates/. Manifest source becomes `README.md` so the
canonical name already matches the destination name.
Verified `getSDKTemplatesDir()` resolves to packages/squad-sdk/templates and that
README.md is now present there — the exact path init copies from.
Also correct the bootstrap table: the charter template on disk is `rai-charter.md`
(lowercase), not `Rai-charter.md`.
Pin the routing in test/template-routing.test.ts. Mirror sync is already covered
by test/template-sync.test.ts, which enumerates `.squad-templates/` dynamically.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0515ad5d-4c5b-48bb-92a6-4e1296594cab
* docs(templates): document all .squad/templates subtrees
Copilot review flagged that the README omitted every subtree that ships
under .squad/templates/, while the Invariant said anything unlisted is
"a stale copy and safe to remove". Verified the risk is real:
- squad init copies this directory recursively (copyRecursiveSync,
init.ts:1481), so casting/, identity/, scripts/, skills/ and
workflows/ all ship into every new project.
- .squad/templates/casting/ is read at runtime by Init Mode to allocate
custom-universe names, so deleting it breaks casting.
- .squad/templates/scripts/ and workflows/ are documented copy-sources
in shipped docs (state-backends, ci-cd-integration).
Add a Subtrees table classifying all five, scope the Invariant to
top-level files so absence from the two tables no longer implies a
subtree is stale, and correct the historical note: it told users the
workflows/ and skills/ subtrees were "safe to delete", which contradicts
the docs that instruct copying from workflows/ and would delete the
source the manifest installs skills from.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0515ad5d-4c5b-48bb-92a6-4e1296594cab
* docs(templates): make the Invariant fail safe for unclassified files
Second round of Copilot review found my subtree fix was incomplete: the
same "not in a table => stale and safe to remove" hazard still applied to
top-level files.
Audited every top-level file against both tables and TEMPLATE_MANIFEST.
Ten are in neither table and unregistered -- including notes-protocol.md,
which the state-backends doc tells users to copy into .squad/. The tables
are not a complete inventory, so "safe to remove" was an unsafe default.
- Absence from the tables now means unclassified, not stale; removal
requires positive evidence nothing reads or copies the file.
- notes-protocol.md named explicitly as the worked example.
- Registration is stated as expected for new files rather than as a
property all current files have, which they do not.
Also corrected the casting/ row: it cited .copilot/skills/init-mode,
a legacy path users do not get after squad init. No shipped template
references the casting/ directory, so the row now describes the data and
points at casting-reference.md instead of a path that would mislead.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0515ad5d-4c5b-48bb-92a6-4e1296594cab
* docs(templates): classify README.md, which broke its own Invariant
Copilot review noted the README was the one top-level file its own rule
left unaccounted for. Now that absence from the tables means
"unclassified" and requires classification, that is a real
self-contradiction rather than a cosmetic gap.
It fits neither table -- it is not a runtime input and seeds nothing --
so it is classified explicitly instead of being forced into one: it
ships as the directory's own documentation via the same recursive copy,
and is manifest-registered so squad upgrade maintains it.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0515ad5d-4c5b-48bb-92a6-4e1296594cab
* fix(templates): repair merged table row and correct casting/ claim
Two Copilot findings:
1. The copilot-instructions.md and fact-checker-charter.md rows were
concatenated onto one line, breaking the bootstrap table. Introduced
by a stray edit in the previous commit; the table now renders again.
2. The casting/ row claimed the directory is read during Init Mode
casting. Nothing shipped references it, which is the whole reason
#1972 exists -- so the row asserted a consumer this PR had already
established does not exist, and contradicted its own description.
Reclassified as shipped data with no known consumer, still
explicitly not-safe-to-delete pending #1972.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0515ad5d-4c5b-48bb-92a6-4e1296594cab
---------
Co-authored-by: brady gaster <bradygaster@github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0515ad5d-4c5b-48bb-92a6-4e1296594cab
* feat(gh-aw): add Squad repo enlistment skill (#1946)
* feat(gh-aw): add Squad repo enlistment skill
Add the gh-aw-enlistment skill that operationalizes the supported Squad
GitHub Agentic Workflows bootstrap: install the four @dev workflows, strictly
compile, honor an explicit safe-update allowlist (only the documented Squad
secrets and squad-init action), keep the default workflow token read-only,
stage only documented surfaces, and open a human-reviewed bootstrap PR that is
never auto-merged. Resolves repo identity at runtime for cross-repo safety.
Ships canonical (.squad/skills) plus both template mirrors, a focused
safety-gate regression test, a changeset, and a discoverability pointer from
the agentic-workflows router.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* test: anchor final strict-compile assertion to start-of-line (m flag)
The previous lookahead regex matched prose/backtick mentions in the Anti-Patterns section, as flagged by the code reviewer (comment 3884574741). Replace with /^gh aw compile --strict(\s+#[^\n]*)?$/m so only real command lines (L151, L260) satisfy the test; lines with --approve or indented prose do not.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(skills): make gh-aw preflight portable and bound the safe-update allowlist
Address two suppressed concerns from Copilot's second review of the
gh-aw-enlistment skill.
Portability: the step-0 extension check used `gh extension list | grep -q`,
which fails in default Windows PowerShell even though the skill is explicitly
portable. `gh extension list` has no `--json` flag, so there is no gh-native
structured check; document a verified PowerShell alternative alongside the bash
form, matching the existing step-6 portability-note convention.
Allowlist exclusivity: the safe-update allowlist is now delimited by
`<!-- allowlist-start -->` / `<!-- allowlist-end -->` so tests can bound it.
The previous tests were named as if they enforced exclusivity but only asserted
whole-document string presence, which could not fail if the allowlist grew.
They now extract the delimited region and deep-equal the sorted token set
against exactly SQUAD_GITHUB_APP_PRIVATE_KEY, SQUAD_GITHUB_TOKEN, and
bradygaster/squad/.github/actions/squad-init, assert both delimiters appear
exactly once, and assert the bullet-line count so structural drift is caught.
A new test guards the portability fix by requiring Select-String to be bound to
the github/gh-aw pattern and to guard an install.
All three skill copies (canonical, CLI template, SDK template) remain
byte-identical.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(skills): make gh-aw-enlistment triggers actually parse, strengthen guard
Copilot review on #1946 flagged that the discoverability assertions only checked
that trigger phrases appeared *somewhere* in the document, so they would still
pass if a phrase left the frontmatter `triggers:` list. Strengthening the
assertion to check the parsed `skill.triggers` array — the same array the runtime
matcher iterates in packages/squad-sdk/src/skills/index.ts — immediately failed,
revealing the weak assertion had been masking a real defect.
`parseFrontmatter` (packages/squad-sdk/src/skills/skill-loader.ts:48) is a naive
line-based parser that only understands inline arrays. Given a YAML block
sequence it stores the empty post-colon value as a string, so
`Array.isArray(meta.triggers)` is false and triggers resolve to `[]`. The skill
was therefore discoverable by NONE of its ten advertised phrases.
Measured across the three forms:
block -> "" (skill undiscoverable)
inline+quoted-> ["\"a phrase\"", ...] (quotes retained, never matches)
inline bare -> ["a phrase", ...] (correct)
Convert this skill's triggers to the only form that parses into clean, matchable
strings. All ten phrases now resolve; canonical and both mirrors stay
byte-identical.
Also note in the router that the enlistment skill is local to this repository,
since the surrounding preamble says its listed files are fetched from
`github/gh-aw` and are not available locally.
The strengthened guard is verified by mutation: moving a phrase out of `triggers:`
while leaving it in prose leaves 2 textual occurrences (the old assertion would
have passed) and fails the new one.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0515ad5d-4c5b-48bb-92a6-4e1296594cab
* test(gh-aw): assert the STOP gate, not just the warning carve-out
The suite asserted that the bot-trigger warning is documented as
permitted, but not the halt that makes that carve-out safe. As written
it would keep passing if the STOP were deleted -- turning a narrow,
justified exception into a blanket "warnings are fine" without any
test noticing.
Asserts the full sentence (whitespace-collapsed, since it wraps).
Mutation-verified: weakening the STOP to a soft note fails this
assertion; the two mirror-parity guards also fire, since the mutation
was applied to one copy only.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0515ad5d-4c5b-48bb-92a6-4e1296594cab
---------
Co-authored-by: brady gaster <bradygaster@github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0515ad5d-4c5b-48bb-92a6-4e1296594cab
* docs(gh-aw): correct credentials guidance and document activation fixes (#1973)
* docs(gh-aw): correct credentials guidance and document activation fixes
The bootstrap procedure listed SQUAD_GITHUB_APP_PRIVATE_KEY and
SQUAD_GITHUB_TOKEN as a setup-time item with no statement that they need
not exist. The clarification sat ~95 lines downstream in an "Optional:"
section a reader following the numbered path never reaches before
deciding whether they are blocked. Two independent agents read that
passage and concluded a PAT was a prerequisite for enlisting a fresh
repo. It is not. The correction now lands inline at the point of
misreading, and is mirrored byte-identically into the three
gh-aw-enlistment SKILL.md copies (outside the bounded allowlist block).
Also documents four merged activation fixes that shipped with zero docs
changes, traceable to workflows/squad.md on dev:
- #1959 label auto-provisioning (squad.md:113-115, 1307, 1931-1945,
2004) — add-labels create-if-missing auto-creates squad/squad:{agent};
auto-provisioned labels get a deterministic color and empty
description, which is expected and not a failure.
- #1961 bounded caps (squad.md:111, 121, 1997, 1999) — create-issue 75,
add_labels 110; the two shortfall paths are kept distinct;
report_incomplete does NOT fail the run, so the durable signal is the
[aw] ... reported incomplete result tracking issue, not the run
conclusion. A cap is named only when observed.
- #1963 accepted-vs-applied (squad.md:1392, 2058-2081) — defines
accepted, states what a summary must not claim, and explains why the
distinction exists (create-issue labels: silently drops missing names).
- #1962 temporary IDs — documented only where user-observable: shortfall
reports identify items by #aw_epic{K}/#aw_task{N}/#aw_wi{N}.
Adds the Activation bindings: JSON block as the checkable verification
surface, and updates the stale troubleshooting row that predated #1961.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* chore: add changeset for gh-aw-enlistment skill template change
The changelog gate's SDK_CLI_PATH_REGEX (squad-ci.yml:273) matches
^packages/squad-(sdk|cli)/templates/, not just src/ — template edits ship
as scaffolding and are covered deliberately. Both packages distribute the
gh-aw-enlistment skill, so both take a patch bump.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* docs(gh-aw): correct activation capacity and rescope label-evidence claim
Addresses review findings A-D on the activation section.
A. The cap table presented 75 as "issues created in one run", which would
lead a reader to size for 75. squad.md:105-107 states the actual
ceiling is 50 issues per activation run; 75 is 50 worst-case plus 25
bounded margin, and 110 covers both readings of the add-labels worst
case (50 calls / 100 label names). Now states the 50-issue ceiling as
the user-facing number and presents 75/110 as underlying headroom,
preserving the workflow's statement that `max` counts safe-output
items (tool calls), not label names.
B. Rescoped the label-evidence claim to the workflow's own epistemic
scope (squad.md:2059-2060): `create-issue`'s `labels:` field never
lands a label the activation run can claim. Dropped the generalized
assertion about GitHub API behavior. Note: "silently drops names the
repository lacks" is verbatim shipped prose at squad.md:2060 — the
scoping concern is upstream in the workflow, flagged rather than
propagated here.
C. Added the fast-path phase temporary ID `#aw_ph{N}` (squad.md:1289),
which was missing from the documented identifier set.
D. Listing labels proves a label exists, not that it landed on the right
issue. Added a per-issue verification path: read the Activation
bindings: block from the origin issue's comments, then compare each
binding against `gh issue view {issue} --json title,labels`.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* docs(gh-aw): explain add-labels vs add_labels naming surfaces
Review flagged the two spellings as inconsistent. Audited every
occurrence: all six are already correct for their surface. The hyphenated
add-labels is the safe-outputs configuration key (squad.md:113) and is
what the caps apply to; the underscored add_labels is the run-time tool
call (squad.md:1294) and is what appears in summaries and incomplete
reports. Rather than collapse them to one spelling, which would make one
of the two surfaces unsearchable, this states the distinction explicitly
at first joint mention.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Enable online documentation in Squad research (#1977)
* feat: enable online Squad research
Enable web-fetch for /squad research, prefer current authoritative documentation, and disclose when online sources are unavailable.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 7d6c4262-f790-49ff-88f8-8aae54b9287c
* test: simplify section extraction
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 7d6c4262-f790-49ff-88f8-8aae54b9287c
* Close direct cast issues when their PRs merge (#1975)
* feat: close direct cast issues on merge
Closes #1974
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d20ee964-dcbd-4e17-921d-e624f8bc0eb3
* test: simplify cast pivot assertion
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d20ee964-dcbd-4e17-921d-e624f8bc0eb3
* fix: clarify cast issue substitution
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d20ee964-dcbd-4e17-921d-e624f8bc0eb3
---------
Copilot-Session: d20ee964-dcbd-4e17-921d-e624f8bc0eb3
* fix(gh-aw): make Cast validator delivery deterministic (#1976)
* fix(gh-aw): make Cast validator delivery deterministic
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): anchor Cast validation failures
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): authenticate Cast validator bytes
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): accept CRLF validator markers
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* test: avoid variable-length validator lookbehind
Use capture groups when replacing the embedded validator payload so the portability regression fixture does not depend on variable-length lookbehind support.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix: order Cast validator find options
Place the depth limit before predicates so validator discovery remains bounded and deterministic across find implementations. Add a regression assertion for the command shape.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* test: clarify Cast command budget source
State explicitly that the command markers are authored inside the squad-cast inline skill, which gh-aw extracts from the ambient prompt.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* test: resolve workflow shell on Windows
Use the shared POSIX-shell resolver for Git for Windows while retaining bash execution on POSIX hosts for the workflow's pipefail contract.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): make Cast failures truthful (#1978)
Materialize and authenticate the Cast validator outside the agent prompt, preserve exact validation authorization, and emit bounded factual terminal failures without success-shaped reporting.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>\nCopilot-Session: 84876c36-36ab-4d53-a689-6ab9a52fe551
* fix(gh-aw): restore public installability after #1977 (#1979)
* fix(gh-aw): restore public installability after #1977
PR #1977 added correct safety prose telling research runs to distrust
fetched web content, but it quoted a canonical adversarial phrase
verbatim. `gh aw compile --strict` does not run gh-aw's markdown
security scanner, so the source PR passed; `gh aw add` does run it, so
every consumer bootstrapping from dev hit:
workflows/squad.md:1438:1: error: [social-engineering] contains
prompt injection pattern (attempts to override AI agent instructions)
Rephrase the line to describe the override attempt instead of
reproducing it. Online research and fetched-content distrust semantics
are unchanged: fetched pages remain untrusted evidence, never
instructions, and embedded directives, persona assignments, tool-use
requests, and instruction-override attempts are still ignored.
Add test/gh-aw-security-scan.test.ts as the regression guard. It runs
the real gh-aw scanner over every distributed workflow Markdown file
rather than a handwritten phrase blocklist, which would drift from
gh-aw's ruleset. The gate is offline, needs no GitHub round-trip, runs
in seconds, and fails closed per the #1833/#1834 convention.
Scratch repos are created outside this checkout: gh aw add resolves
.github/workflows/ by walking up from its working directory, and a
nested workspace let it escape into the real tree and write stray
files there. A self-check asserts the sandbox held.
Verified: the guard fails on pre-fix content with the exact scanner
error and passes after; all four workflows strict-compile; the public
four-workflow gh aw add succeeds from the pushed branch.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): address review on the security-scan gate
Two findings from Copilot review on #1979.
1. `git commit` in the scratch repo made the gate flaky on machines with
`commit.gpgsign=true` set globally and no usable signing key. Rather
than disabling signing, drop the commit entirely: an empty `git init`
is sufficient for gh-aw once the workspace lives outside this
checkout. The commit was only ever compensating for the earlier
in-repo workspace, so removing it eliminates the failure class
instead of suppressing it. Verified green with
`commit.gpgsign=true` forced.
2. The `-n` comment claimed it avoided a batch-abort on basename
collision, but each file already gets its own workspace, so no such
collision exists. Corrected to state the real reason: a deterministic
installed name for the sandbox-leak self-check.
Guard re-verified in both directions after the refactor: fails on
pre-fix content with the exact scanner error, 10 passed on this branch.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* test(gh-aw): prove the scan gate needs no commit, under hostile signing
Independent review flagged the same portability defect Copilot did: a
scratch-repo commit inherits global `commit.gpgsign=true`, so a machine
without a usable signing key fails before gh-aw's scanner ever runs,
turning an installability gate into an environment-dependent one.
0f26442 already removed the commit (the reviewer's preferred option:
`git init` alone is sufficient once the workspace lives outside this
checkout). What was missing is the reviewer's second ask -- making the
property non-regressable rather than merely documented.
Add a test that executes a real scan under a signing-hostile git
environment: `commit.gpgsign=true`, `tag.gpgsign=true`, and
`gpg.program` pointed at a path asserted not to exist. Any reintroduced
commit dies there, while a path that never commits is unaffected.
Verified by temporarily restoring the commit: the new test fails with
"gpg failed to sign the data". It passes on this branch.
Config is injected through `GIT_CONFIG_COUNT`/`GIT_CONFIG_KEY_n`, which
applies to every git process in the subtree, including any git that
`gh aw` shells out to, without mutating global config.
Scope unchanged: two files. Guard still bidirectional (fails on pre-fix
content with the exact scanner error). Targeted suites 218 passed,
eslint and tsc clean.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): fast-path /squad activate artifact integrity (E4 preflight A) (#1980)
* fix(gh-aw): fast-path /squad activate artifact integrity (E4 preflight A)
Closes the gap where the recommended /squad activate fast path
(squad-plan-accept, artifacts plan-accepted/phases-accepted) created and
labeled issues identically to the granular /squad plan activate path but
was not covered by the Activation bindings: contract, the deterministic
checker, or the CI collector.
- workflows/squad.md: fast path Step 4 now requires the same non-empty
Activation bindings: JSON block (shape/quoting/omission semantics) as
squad-plan-activate. Renamed both paths' label-reporting heading to the
identical "Label operations accepted" text. Reworded the "label set it
should have received" trap phrase to drop the forbidden certainty word
"received" while preserving meaning.
- workflows/shared/squad-planning-ontology.md: the bindings mapping is now
documented as mandatory for phases-accepted/plan-accepted too, not just
phases-activated/activated.
- scripts/check-agent-binding.mjs: ACTIVATION_ARTIFACTS now includes
plan-accepted/phases-accepted so missing/empty bindings fail closed for
fast-path artifacts exactly like granular ones. Added
assertAcceptedOnlyLabelWording(), which rejects standalone certainty
claims (applied, received, landed, verified, confirmed, checked) in
label-operation reporting. It is scoped to lines that actually mention
label vocabulary, strips fenced/inline code and quoted strings first,
skips markdown table rows, and treats explicit negations as compliant --
never a blanket whole-comment scan -- so quoted titles, unrelated
sections, negations, and substrings (unverified) don't false-positive.
Wired into main()'s per-comment loop.
- .github/workflows/squad-agent-binding-check.yml: the collector filter
matched only /activated/i, which a plan-accepted/phases-accepted comment
never contains, so fast-path artifacts were silently never passed to the
checker. Now matches the squad_artifact field precisely for all four
activation artifact types.
- test/gh-aw-activation-artifact-integrity.test.ts (new): heading parity,
fast-path bindings-contract presence + mutation kills against committed
source, checker/runtime parity across all four artifact types (missing
and [] bindings), a full parseStructuredData+validateActivation pipeline
test against realistic comment strings (including bindings-block
deletion/emptying), parameterized forbidden-word rejection (6 words x
case/punctuation), negative tests for quoted titles/table
rows/unrelated sections/negations/substrings, and collector-regex
parity/regression tests.
- test/gh-aw-activation-capacity.test.ts: updated the one existing
assertion pinned to the reworded trap phrase.
Out of scope per the E4 preflight package A brief: workflow discriminators,
docs sequencing, draft PR UX, and all other E4 findings.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): scope negation/claim detection to clauses in label-wording check
FIDO rejected the first revision of #1980 with two reproduced defects in
assertAcceptedOnlyLabelWording (scripts/check-agent-binding.mjs):
1. False negative: NEGATION_NEARBY matched a negation anywhere on the whole
line, so an unrelated negation earlier in the line (e.g. "No issues were
skipped") blanket-suppressed a real, separate certainty claim later in the
same line ("Label squad:kint was verified for #42").
2. False positive: a forbidden word describing an unrelated subject sharing a
line with a label token ("its verified real number" describing a reused
issue number, not the label operation) was incorrectly flagged.
Fix: split each line into clauses on clause/sentence-ending punctuation
(., ,, ;, :), protecting squad:{agent} tokens so their embedded colon is never
mistaken for a clause boundary. Label-operation context, the forbidden word,
and any negation must now all be found within the *same* clause before a
claim is flagged. This lets an unrelated negation in a different clause fail
to suppress a real claim, and lets a forbidden word in a clause that carries
no label-operation context correctly fall out of scope, without weakening the
existing quoted-title/table-row/code-fence/substring/negation guards or the
six forbidden standalone certainty claims (applied, received, landed,
verified, confirmed, checked).
Adds two permanent regression tests reproducing FIDO's exact reported
strings in test/gh-aw-activation-artifact-integrity.test.ts.
Testing:
- npx vitest run test/gh-aw-activation-artifact-integrity.test.ts — 90/90
passed (88 previously + 2 new regression tests)
- npx vitest run test/check-agent-binding.test.ts
test/gh-aw-activation-summary-outcomes.test.ts
test/gh-aw-activation-capacity.test.ts test/gh-aw-quality.test.ts
test/gh-aw-activate-roster-binding.test.ts
test/gh-aw-agent-binding-correspondence.test.ts
test/gh-aw-activation-artifact-integrity.test.ts — 377/377 passed
- npx vitest run (full suite) — only pre-existing, unrelated failures
remain (externalized-state CLI tests), confirmed identical on the
pre-revision commit
- npx eslint scripts/check-agent-binding.mjs
test/gh-aw-activation-artifact-integrity.test.ts
test/gh-aw-activation-capacity.test.ts — clean
- npm run build — succeeds; build-metadata/version-bump and skill-template
CRLF sync side effects reverted before commit, not part of this diff
Scope: only scripts/check-agent-binding.mjs and
test/gh-aw-activation-artifact-integrity.test.ts touched, per FIDO's
required narrow revision.
Closes the FIDO REJECT on #1980.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): resolve quoted issue references before prefetching labels
main() filtered binding.issue/epic_issue with Number.isInteger, but
compliant activation artifacts write these as quoted "#42" strings per
the resolveIssueReference() contract. That produced an empty issues
list, skipped label fetching entirely, and made validateActivation()
fail with "labels could not be resolved" for otherwise-valid bindings.
Add extractIssueNumber(), a non-throwing counterpart to
resolveIssueReference() that also accepts the "#42" string form, and
use it when building the label-prefetch list in main().
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* test(gh-aw): cover quoted activation references
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): add dispatch job discriminators (#1981)
Refs #1958
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* test(gh-aw): prove plaintext resource delivery (#1983)
* feat(gh-aw): add resource delivery probe
Closes #1982
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 083906de-529b-42f9-ae2d-36b0c911eaef
* chore(gh-aw): keep resource probe scope focused
Closes #1982
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 083906de-529b-42f9-ae2d-36b0c911eaef
* test(gh-aw): exercise resource readability guard (#1982)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 083906de-529b-42f9-ae2d-36b0c911eaef
---------
Copilot-Session: 083906de-529b-42f9-ae2d-36b0c911eaef
* gh-aw: replace gzip+Base64 Cast validator transport with plaintext resource (#1986)
* gh-aw: replace gzip+Base64 Cast validator transport with plaintext resource
Replace the fake-skill gzip+Base64 transport for the Cast validator
(workflows/shared/squad-cast-validator.md, materialized at runtime via
SKILL.md discovery and gunzip/base64 extraction) with a canonical
plaintext gh-aw resources sidecar, workflows/shared/squad-cast-validator.mjs,
installed verbatim at .github/workflows/shared/ in consumer repos.
- workflows/squad.md: declare the validator as a resources entry (not
imports); rewrite the validator runner step to execute the installed
resource directly from GITHUB_WORKSPACE (never staged to or run from
RUNNER_TEMP); drop the SKILL.md search/extraction logic; restore the
pwd -P physical-path normalization the old script relied on (needed
so import.meta.url resolution is not defeated by symlinked
temp/workspace paths); reduce the cast-failure job stage taxonomy
from 6 to 4 stages (discovery/integrity/syntax/validation); update
Step 7 docs and stage table to match.
- workflows/shared/squad-cast-validator.mjs: new plaintext resource,
byte-identical to scripts/validate-gh-aw-cast.mjs, pinned by
SHA-256 in the runner script.
- Remove workflows/shared/squad-cast-validator.md (fake-skill payload)
and workflows/shared/squad-gh-aw-resource-probe.txt (experimental
probe-only resource from #1982/#1983), plus their .gitattributes
entry and probe-only docs.
- test/gh-aw-cast-validator.test.ts, test/gh-aw-quality.test.ts:
rewrite delivery-mechanism coverage for the new 4-stage model;
remove probe-only tests; update SOURCE_GROWTH_BUDGET_KB.
Pinned SHA-256 authentication, node --check, the exact authorization
output ("Cast validation passed."), and the typed Cast failure
contract (fail-closed on missing/unreadable/modified/syntactically
invalid/rejecting validators) are unchanged. The direct install path
in .github/AGENTS.md (gh aw add bradygaster/squad/workflows/squad.md@dev)
is untouched.
Validation:
- npx vitest run test/gh-aw-cast-validator.test.ts test/gh-aw-quality.test.ts
-> 213/213 passed (includes dynamic gh-aw strict-mode compile via
lockText()).
- Manual gh aw compile squad --strict against a scratch workspace
(repository-pinned gh-aw v0.87.10): compiled successfully; inspected
generated squad.lock.yml runner script contains no SKILL.md search,
base64, or gzip logic, reads validator_script directly from
GITHUB_WORKSPACE, and preserves the 4-stage fail_cast taxonomy.
- npm run build (packages/squad-sdk then packages/squad-cli): passed.
Closes #1984
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* test(gh-aw): restore cast-failure output diagnostic tests
Restore three tests deleted during the plaintext resource transport
migration for unchanged cast-failure safe-output handler behavior:
- fails malformed agent output with a deterministic diagnostic
- fails non-object output items with a deterministic diagnostic
- diagnoses conflicting failure and pull-request outputs without
claiming prevention
Closes #1984
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Fix Cast validator sandbox path (#1989)
* fix: keep Cast validator inside sandbox workspace
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* test: remove redundant Cast fixture setup
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Preserve built-in agents in gh-aw casts (#1990)
* fix: preserve built-in agents in gh-aw casts
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: bc7757e5-628e-4f82-bb3c-7ea20b6b6056
* fix: address built-in validation feedback
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: bc7757e5-628e-4f82-bb3c-7ea20b6b6056
* test: use canonical fact-checker directory
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: bc7757e5-628e-4f82-bb3c-7ea20b6b6056
---------
Copilot-Session: bc7757e5-628e-4f82-bb3c-7ea20b6b6056
* gh-aw: enforce byte-identical built-in charters and fix late-restore clobbering (#1992)
* gh-aw: enforce byte-identical built-in charters in Cast validator
Strengthen the GH-AW Cast validator so it fails Cast validation unless
every final .squad/agents/{scribe,ralph,rai,fact-checker}/charter.md
is byte-for-byte identical to its canonical resource under
.github/workflows/shared/builtins/{id}-charter.md. Previously the
validator only checked that the four built-in directories existed and
were referenced correctly, not that their content survived intact
through a squad init run or agent rewrite after the deterministic
materialization step.
- Add validateBuiltinCharterFidelity to
workflows/shared/squad-cast-validator.mjs, mirrored verbatim to
scripts/validate-gh-aw-cast.mjs.
- Update the validator SHA-256 pin in workflows/squad.md for the new
validator bytes.
- Update test/gh-aw-cast-validator.test.ts fixtures to materialize
real canonical built-in charter content (read from
workflows/shared/builtins/) instead of placeholders, and add
focused tests covering byte-mismatch rejection, missing canonical
resource, and byte-identical acceptance.
- Update the hardcoded SHA-256 expectation in
test/gh-aw-quality.test.ts.
Validated: targeted vitest run (226 passed), full gh-aw-*.test.ts run
(699 passed, 1 pre-existing unrelated failure from an unbuilt SDK
workspace package), and gh aw compile --strict for all four Squad
workflows using the pinned v0.87.10 compiler via the repo's
CI-mirroring recipe.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* gh-aw: run built-in charter materialization as a pre-agent-step
Fix the residual clobbering path the byte-fidelity validator (previous
commit) could only detect, not prevent: gh-aw's native
"Restore agent config folders from base branch" and the (unconditional,
no runtime if:-guard) repeated "Restore ambient folders from activation
artifact" step run AFTER our old steps: placement, and can reintroduce
a stale committed .squad/ snapshot over the freshly materialized
built-in charters whenever this workflow's pull_request_comment trigger
causes checkout-pr to succeed and a stale .squad/ already exists on the
relevant ref (matching the octodemo/zava-social-squad-backend#13
scenario, and the residual gap identified in review of PR #1992).
Root-cause detail confirmed empirically against the compiled lock file
(pkg/workflow/compiler_yaml_ai_execution.go in github/gh-aw): custom
steps: are always spliced in early (right after the activation-artifact
download), while base-branch restore, both ambient-folder restores, and
inline sub-agent/skill restore are compiler-injected later in the same
job — before pre-agent-steps, MCP setup, and Copilot CLI execution. The
existing steps: mechanism was structurally unable to run after those
restores; pre-agent-steps is the documented gh-aw hook designed for
exactly this ordering need.
- workflows/squad.md: move "Materialize canonical built-in support
agents" and "Prepare deterministic Cast validator runner" from
steps: to pre-agent-steps:. Verified via `gh aw compile --strict`
that both now execute after every restore step and before MCP setup
/ "Execute GitHub Copilot CLI".
- test/gh-aw-quality.test.ts: replace the now-inverted ordering
assertion (validator-runner used to run before "Restore inline
skills"; it now correctly runs after every restore and before agent
execution) and add a new focused test asserting the full ordering
invariant end-to-end: activation job (squad init) precedes the agent
job; materialization runs after init and after every restore step
(Squad state, base-branch, both ambient-folder occurrences, inline
sub-agents, inline skills); and materialization precedes "Execute
GitHub Copilot CLI".
Validated with the mandatory npm proxy set before every npm/npx
invocation:
- `npx vitest run test/gh-aw-cast-validator.test.ts test/gh-aw-quality.test.ts`
-> 227/227 passed
- `npx vitest run test/gh-aw-*.test.ts` -> 700/700 passed (1
pre-existing unrelated failure from an unbuilt SDK workspace package,
same as before this change and on dev)
- `gh aw compile --strict` for all four Squad workflows using the
pinned v0.87.10 compiler via the repo's CI-mirroring recipe — all 4
succeeded
- Confirmed step order in the compiled squad.lock.yml directly:
Restore agent config folders from base branch -> Restore ambient
folders from activation artifact (2nd occurrence) -> Restore inline
sub-agents -> Restore inline skills -> Materialize canonical
built-in support agents -> Prepare deterministic Cast validator
runner -> Start MCP Gateway -> Execute GitHub Copilot CLI
Only the already-authorized workflow/validator/test files were
touched; no changeset added (workflow/test-only scope is exempt from
the changelog gate's SDK/CLI path regex).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* deps: Bump fast-uri from 3.1.5 to 3.1.7 (#1991)
Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.5 to 3.1.7.
- [Release notes](https://github.com/fastify/fast-uri/releases)
- [Commits](https://github.com/fastify/fast-uri/compare/v3.1.5...v3.1.7)
---
updated-dependencies:
- dependency-name: fast-uri
dependency-version: 3.1.7
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brady Gaster <41929050+bradygaster@users.noreply.github.com>
* deps: bump sharp from 0.35.3 to 0.35.4 in /docs in the minor-patch group (#1952)
Bumps the minor-patch group in /docs with 1 update: [sharp](https://github.com/lovell/sharp).
Updates `sharp` from 0.35.3 to 0.35.4
- [Release notes](https://github.com/lovell/sharp/releases)
- [Commits](https://github.com/lovell/sharp/compare/v0.35.3...v0.35.4)
---
updated-dependencies:
- dependency-name: sharp
dependency-version: 0.35.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: minor-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brady Gaster <41929050+bradygaster@users.noreply.github.com>
* deps: bump astro in /docs in the astro-minor-patch group (#1950)
Bumps the astro-minor-patch group in /docs with 1 update: [astro](https://github.com/withastro/astro/tree/HEAD/packages/astro).
Updates `astro` from 7.2.4 to 7.2.9
- [Release notes](https://github.com/withastro/astro/releases)
- [Changelog](https://github.com/withastro/astro/blob/main/packages/astro/CHANGELOG.md)
- [Commits](https://github.com/withastro/astro/commits/astro@7.2.9/packages/astro)
---
updated-dependencies:
- dependency-name: astro
dependency-version: 7.2.9
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: astro-minor-patch
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* deps: Bump qs from 6.15.2 to 6.16.0 (#1993)
Bumps [qs](https://github.com/ljharb/qs) from 6.15.2 to 6.16.0.
- [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ljharb/qs/compare/v6.15.2...v6.16.0)
---
updated-dependencies:
- dependency-name: qs
dependency-version: 6.16.0
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brady Gaster <41929050+bradygaster@users.noreply.github.com>
* deps: Bump @humanfs/node from 0.16.7 to 0.16.8 (#1994)
Bumps [@humanfs/node](https://github.com/humanwhocodes/humanfs/tree/HEAD/packages/node) from 0.16.7 to 0.16.8.
- [Release notes](https://github.com/humanwhocodes/humanfs/releases)
- [Changelog](https://github.com/humanwhocodes/humanfs/blob/main/packages/node/CHANGELOG.md)
- [Commits](https://github.com/humanwhocodes/humanfs/commits/node-v0.16.8/packages/node)
---
updated-dependencies:
- dependency-name: "@humanfs/node"
dependency-version: 0.16.8
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brady Gaster <41929050+bradygaster@users.noreply.github.com>
* ci: Bump github/gh-aw-actions (#1954)
Bumps the github-actions group with 1 update in the / directory: [github/gh-aw-actions](https://github.com/github/gh-aw-actions).
Updates `github/gh-aw-actions` from 0.87.2 to 0.87.9
- [Release notes](https://github.com/github/gh-aw-actions/releases)
- [Changelog](https://github.com/github/gh-aw-actions/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/gh-aw-actions/compare/v0.87.2...v0.87.9)
---
updated-dependencies:
- dependency-name: github/gh-aw-actions
dependency-version: 0.87.9
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brady Gaster <41929050+bradygaster@users.noreply.github.com>
* Preserve full URLs in Squad research output (#1998)
* fix(gh-aw): preserve research source URLs
Allow the public Microsoft Learn and Aspire documentation domains through safe-output URL sanitization while retaining credential and sensitive-query safeguards.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f3bb47aa-1b45-4302-8ec2-5e3dc868de42
* test(gh-aw): tighten research URL guards
Assert the exact safe-output domain allowlist, tolerate prompt line wrapping, and exclude safe-output metadata from operation max validation.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 7abb1583-79f9-4355-882d-a9d099f6817f
---------
Copilot-Session: f3bb47aa-1b45-4302-8ec2-5e3dc868de42
Copilot-Session: 7abb1583-79f9-4355-882d-a9d099f6817f
* ci: Bump the github-actions group across 1 directory with 2 updates (#2002)
* ci: Bump the github-actions group across 1 directory with 2 updates
Bumps the github-actions group with 2 updates in the / directory: [github/gh-aw-actions](https://github.com/github/gh-aw-actions) and [actions/deploy-pages](https://github.com/actions/deploy-pages).
Updates `github/gh-aw-actions` from 0.87.9 to 0.88.4
- [Release notes](https://github.com/github/gh-aw-actions/releases)
- [Changelog](https://github.com/github/gh-aw-actions/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/gh-aw-actions/compare/v0.87.9...v0.88.4)
Updates `actions/deploy-pages` from 5.0.0 to 5.0.1
- [Release notes](https://github.com/actions/deploy-pages/releases)
- [Commits](https://github.com/actions/deploy-pages/compare/cd2ce8fcbc39b97be8ca5fce6e763baed58fa128...368f82528645a54fb793d4d04e342629a3f51346)
---
updated-dependencies:
- dependency-name: actions/deploy-pages
dependency-version: 5.0.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions
- dependency-name: github/gh-aw-actions
dependency-version: 0.88.4
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-actions
...
Signed-off-by: dependabot[bot] <support@github.com>
* ci: pin gh-aw actions to v0.88.4 commit
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brady Gaster <brady.gaster@gmail.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* deps: Bump the minor-patch group across 1 directory with 4 updates (#2007)
* deps: Bump the minor-patch group across 1 directory with 4 updates
Bumps the minor-patch group with 4 updates in the /docs directory: [@astrojs/markdown-remark](https://github.com/withastro/astro/tree/HEAD/packages/markdown/remark), [@astrojs/sitemap](https://github.com/withastro/astro/tree/HEAD/packages/integrations/sitemap), [astro](https://github.com/withastro/astro/tree/HEAD/packages/astro) and [@playwright/test](https://github.com/microsoft/playwright).
Updates `@astrojs/markdown-remark` from 7.2.4 to 7.3.0
- [Release notes](https://github.com/withastro/astro/releases)
- [Changelog](https://github.com/withastro/astro/blob/main/packages/markdown/remark/CHANGELOG.md)
- [Commits](https://github.com/withastro/astro/commits/@astrojs/markdown-remark@7.3.0/packages/markdown/remark)
Updates `@astrojs/sitemap` from 3.7.3 to 3.7.4
- [Release notes](https://github.com/withastro/astro/releases)
- [Changelog](https://github.com/withastro/astro/blob/main/packages/integrations/sitemap/CHANGELOG.md)
- [Commits](https://github.com/withastro/astro/commits/@astrojs/sitemap@3.7.4/packages/integrations/sitemap)
Updates `astro` from 7.2.9 to 7.2.10
- [Release notes](https://github.com/withastro/astro/releases)
- [Changelog](https://github.com/withastro/astro/blob/main/packages/astro/CHANGELOG.md)
- [Commits](https://github.com/withastro/astro/commits/astro@7.2.10/packages/astro)
Updates `@playwright/test` from 1.62.1 to 1.63.0
- [Release notes](https://github.com/microsoft/playwright/releases)
- [Commits](https://github.com/microsoft/playwright/compare/v1.62.1...v1.63.0)
---
updated-dependencies:
- dependency-name: "@astrojs/markdown-remark"
dependency-version: 7.3.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: minor-patch
- dependency-name: "@astrojs/sitemap"
dependency-version: 3.7.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: minor-patch
- dependency-name: astro
dependency-version: 7.2.10
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: minor-patch
- dependency-name: "@playwright/test"
dependency-version: 1.63.0
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: minor-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* fix(docs): stabilize Astro upgrade validation
Update generated Astro content types, preserve sidebar scroll before transition preparation, and refresh stale feature/API assertions.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brady Gaster <brady.gaster@gmail.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Brady Gaster <41929050+bradygaster@users.noreply.github.com>
* deps: Bump the minor-patch group across 1 directory with 18 updates (#2008)
* deps: Bump the minor-patch group across 1 directory with 18 updates
Bumps the minor-patch group with 15 updates in the / directory:
| Package | From | To |
| --- | --- | --- |
| [@opentelemetry/context-async-hooks](https://github.com/open-telemetry/opentelemetry-js) | `2.10.0` | `2.11.0` |
| [@opentelemetry/sdk-metrics](https://github.com/open-telemetry/opentelemetry-js) | `2.10.0` | `2.11.0` |
| [@opentelemetry/sdk-trace-base](https://github.com/open-telemetry/opentelemetry-js) | `2.10.0` | `2.11.0` |
| [@playwright/test](https://github.com/microsoft/playwright) | `1.62.1` | `1.63.0` |
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `8.67.0` | `8.69.0` |
| [cspell](https://github.com/streetsidesoftware/cspell/tree/HEAD/packages/cspell) | `10.0.1` | `10.2.2` |
| [eslint](https://github.com/eslint/eslint) | `10.8.1` | `10.10.0` |
| [markdown-it](https://github.com/markdown-it/markdown-it) | `15.0.0` | `15.0.1` |
| [vscode-jsonrpc](https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/jsonrpc) | `9.0.1` | `9.0.2` |
| [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `26.2.0` | `26.4.1` |
| [@github/copilot-sdk](https://github.com/github/copilot-sdk) | `1.0.11` | `1.0.13` |
| [typedoc-plugin-markdown](https://github.com/typedoc2md/typedoc-plugin-markdown/tree/HEAD/packages/typedoc-plugin-markdown) | `4.12.0` | `4.13.0` |
| [@opentelemetry/exporter-metrics-otlp-grpc](https://github.com/open-telemetry/opentelemetry-js) | `0.221.0` | `0.222.0` |
| [@opentelemetry/exporter-trace-otlp-grpc](https://github.com/open-telemetry/opentelemetry-js) | `0.221.0` | `0.222.0` |
| [@opentelemetry/sdk-node](https://github.com/open-telemetry/opentelemetry-js) | `0.221.0` | `0.222.0` |
Updates `@opentelemetry/context-async-hooks` from 2.10.0 to 2.11.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md)
- [Commits](https://github.com/open-telemetry/opentelemetry-js/compare/v2.10.0...v2.11.0)
Updates `@opentelemetry/sdk-metrics` from 2.10.0 to 2.11.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md)
- [Commits](https://github.com/open-telemetry/opentelemetry-js/compare/v2.10.0...v2.11.0)
Updates `@opentelemetry/sdk-trace-base` from 2.10.0 to 2.11.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md)
- [Commits](https://github.com/open-telemetry/opentelemetry-js/compare/v2.10.0...v2.11.0)
Updates `@playwright/test` from 1.62.1 to 1.63.0
- [Release notes](https://github.com/microsoft/playwright/releases)
- [Commits](https://github.com/microsoft/playwright/compare/v1.62.1...v1.63.0)
Updates `@typescript-eslint/eslint-plugin` from 8.67.0 to 8.69.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.69.0/packages/eslint-plugin)
Updates `@typescript-eslint/parser` from 8.67.0 to 8.69.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.69.0/packages/parser)
Updates `cspell` from 10.0.1 to 10.2.2
- [Release notes](https://github.com/streetsidesoftware/cspell/releases)
- [Changelog](https://github.com/streetsidesoftware/cspell/blob/main/packages/cspell/CHANGELOG.md)
- [Commits](https://github.com/streetsidesoftware/cspell/commits/v10.2.2/packages/cspell)
Updates `eslint`…
…heckouts (#2164) * fix(release): repair Homebrew/WinGet publish auth for external-repo checkouts (#2161) * fix(release): replace broken external-repo checkout auth for Homebrew/WinGet publish The publish-homebrew and publish-winget jobs used actions/checkout with a custom classic PAT against external repositories (bradygaster/homebrew-squad, microsoft/winget-pkgs, tamirdresher/winget-pkgs). This failed deterministically in the v1.0.0 release run (reproduced on rerun) with: fatal: could not read Username for 'https://github.com': terminal prompts disabled Root cause not fully isolated (token validity could not be checked from outside Actions), so this change removes the dependency on actions/checkout's token/includeIf mechanism entirely rather than guessing around it: - All three target repos are public, so the initial read/clone never actually needs authentication - switched to plain anonymous 'git clone'. - Push credentials (needed only for the later 'git push'/gh pr create steps) are now set via a local, non-global 'git config --local http.<url>.extraheader' scoped to just that one clone directory - never embedded in a remote URL, never printed, and cleaned up automatically when the job's workspace is discarded. - Added an explicit preflight step to each job that validates the relevant token via 'gh api user' and checks '.permissions.push' on the target repo before attempting any clone/push, so an actually-invalid/expired PAT fails fast with a clear, actionable error instead of surfacing as a confusing low-level git auth error. No changes to job graph, secrets, or permissions scopes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * fix(release): keep actions/checkout for contract-tested steps, disable credential persistence The contract test (test/standalone-release-workflow.test.ts) asserts the Homebrew tap checkout and the 'Check out existing WinGet version branch' step remain real actions/checkout steps with specific with: fields (repository/ref/path/token) - replacing them with raw git clone broke that contract and failed the test job on PR #2161. Revert those two specific steps to actions/checkout, but add persist-credentials: false so the action does not attempt to write its own git credential config (the suspected source of the original 'could not read Username... terminal prompts disabled' failure). Credential configuration for the later git push is now done explicitly via a scoped, local-only http.extraheader in a separate step - never persisted globally, never logged, never embedded in a remote URL. The two clones that are not covered by the contract test (the read-only winget-base base clone and the new-branch clone from microsoft/winget-pkgs master) remain anonymous git clone, since no credential is needed to read these public repos. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <Copilot@users.noreply.github.com> * fix(release): avoid token-authenticated checkout for Homebrew tap read The Homebrew tap checkout previously used actions/checkout with 'token: secrets.HOMEBREW_TAP_TOKEN' and 'persist-credentials: false'. persist-credentials only controls whether the credential is scrubbed AFTER the step completes - it does not change how the step's own initial fetch authenticates. The real production failure (run 37104124444, job 111157909375) showed this exact checkout failing with 'fatal: could not read Username ... terminal prompts disabled' despite a valid, non-empty token (preflight passed) - meaning the prior persist-credentials:false change alone did not address the failing mechanism. bradygaster/homebrew-squad is a public repository, so the read-only clone does not need any credential at all. Replace the token-bearing actions/checkout with a plain anonymous 'git clone', and continue to configure the push credential as a locally-scoped git config entry (set only after the clone, only for the later push step) - this removes the token from the path that was actually failing while preserving scoped, non-persisted auth for the write operation. Root cause of the exact actions/checkout auth-setup failure itself remains unconfirmed (no definitive matching upstream report found); this change eliminates the observed failure path rather than claiming a confirmed upstream bug. Updates the standalone-release-workflow contract test to assert the new anonymous-clone + scoped-push-credential shape instead of the token-bearing checkout shape. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * fix(release): apply same anonymous-clone pattern to WinGet branch reuse The 'Check out existing WinGet version branch' step (exercised only when re-publishing to an already-open version branch) used the same token-bearing actions/checkout + persist-credentials:false shape that was just shown to be unreliable for the Homebrew tap checkout. This exact path has never been exercised by a real production run (the only successful standalone-release run on record predates this branch-reuse code and always took the branch_exists=false path), so it carries the same latent risk without any positive evidence it works. tamirdresher/winget-pkgs is a public fork, so apply the identical fix: anonymous git clone for the read, scoped local push credential configured afterward only for the subsequent push. Update the matching contract test. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <Copilot@users.noreply.github.com>
* fix(cli): accept persistent names in health routes (#2165) Co-authored-by: brady gaster <bradygaster@github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> (cherry picked from commit d2364df) * chore(release): prepare surgical npm v1.0.1 patch Closes #2165. Consume only its approved CLI health patch changeset; preserve historical main fragments and unchanged SDK/NuGet source. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * fix(release): include approved latest-stable activation correction Integrate only the approved technical changes from 90c5396, 2385cf7, 0e881f7 and 50e4b3a into the existing main-based 1.0.1 candidate for #2166, without merging dev history. Resolve canonical conflicts surgically and regenerate package workflows, manifest and compiler-tamper fixtures from the combined main tree. Preserve the #2165 health fix, root/SDK/CLI 1.0.1 lockstep and SDK floor. SDK runtime, NuGet and historical changesets remain untouched. Build and targeted contracts passed; current-head hosted CI and human review remain required before merge/publication. Closes #2167 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: brady gaster <bradygaster@github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <Copilot@users.noreply.github.com>
* docs: refresh stable release messaging Closes #2071 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * docs: retain generated Astro schemas Keep the tracked editor schemas and metadata while leaving only the stale content cache removed. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* deps: Bump devalue from 5.8.1 to 5.9.2 in /docs (#2055)
Bumps [devalue](https://github.com/sveltejs/devalue) from 5.8.1 to 5.9.2.
- [Release notes](https://github.com/sveltejs/devalue/releases)
- [Changelog](https://github.com/sveltejs/devalue/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sveltejs/devalue/compare/v5.8.1...v5.9.2)
---
updated-dependencies:
- dependency-name: devalue
dependency-version: 5.9.2
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brady Gaster <41929050+bradygaster@users.noreply.github.com>
* deps: Bump the minor-patch group across 1 directory with 2 updates (#2058)
Bumps the minor-patch group with 2 updates in the /docs directory: [@astrojs/markdown-remark](https://github.com/withastro/astro/tree/HEAD/packages/markdown/remark) and [astro](https://github.com/withastro/astro/tree/HEAD/packages/astro).
Updates `@astrojs/markdown-remark` from 7.3.0 to 7.3.1
- [Release notes](https://github.com/withastro/astro/releases)
- [Changelog](https://github.com/withastro/astro/blob/main/packages/markdown/remark/CHANGELOG.md)
- [Commits](https://github.com/withastro/astro/commits/@astrojs/markdown-remark@7.3.1/packages/markdown/remark)
Updates `astro` from 7.3.1 to 7.3.3
- [Release notes](https://github.com/withastro/astro/releases)
- [Changelog](https://github.com/withastro/astro/blob/main/packages/astro/CHANGELOG.md)
- [Commits](https://github.com/withastro/astro/commits/astro@7.3.3/packages/astro)
---
updated-dependencies:
- dependency-name: "@astrojs/markdown-remark"
dependency-version: 7.3.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: minor-patch
- dependency-name: astro
dependency-version: 7.3.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: minor-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brady Gaster <41929050+bradygaster@users.noreply.github.com>
* deps: Bump the microsoft-packages group with 2 updates (#2059)
Bumps Microsoft.Agents.AI.GitHub.Copilot from 1.20.0 to 1.22.0
Bumps Microsoft.Extensions.AI from 10.9.0 to 10.10.0
---
updated-dependencies:
- dependency-name: Microsoft.Agents.AI.GitHub.Copilot
dependency-version: 1.22.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: microsoft-packages
- dependency-name: Microsoft.Extensions.AI
dependency-version: 10.10.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: microsoft-packages
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brady Gaster <41929050+bradygaster@users.noreply.github.com>
* deps: Bump GitHub.Copilot.SDK from 1.0.13 to 1.0.14 (#2060)
---
updated-dependencies:
- dependency-name: GitHub.Copilot.SDK
dependency-version: 1.0.14
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brady Gaster <41929050+bradygaster@users.noreply.github.com>
* deps: Bump the minor-patch group across 1 directory with 6 updates (#2062)
Bumps the minor-patch group with 6 updates in the / directory:
| Package | From | To |
| --- | --- | --- |
| [cspell](https://github.com/streetsidesoftware/cspell/tree/HEAD/packages/cspell) | `10.2.2` | `10.3.3` |
| [markdown-it](https://github.com/markdown-it/markdown-it) | `15.0.1` | `15.0.2` |
| [react](https://github.com/react/react/tree/HEAD/packages/react) | `19.2.8` | `19.3.0` |
| [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) | `19.2.18` | `19.3.0` |
| [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `26.5.0` | `26.6.1` |
| [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) | `19.2.18` | `19.3.0` |
| [@github/copilot-sdk](https://github.com/github/copilot-sdk) | `1.0.13` | `1.0.14` |
Updates `cspell` from 10.2.2 to 10.3.3
- [Release notes](https://github.com/streetsidesoftware/cspell/releases)
- [Changelog](https://github.com/streetsidesoftware/cspell/blob/main/packages/cspell/CHANGELOG.md)
- [Commits](https://github.com/streetsidesoftware/cspell/commits/v10.3.3/packages/cspell)
Updates `markdown-it` from 15.0.1 to 15.0.2
- [Changelog](https://github.com/markdown-it/markdown-it/blob/master/CHANGELOG.md)
- [Commits](https://github.com/markdown-it/markdown-it/compare/15.0.1...15.0.2)
Updates `react` from 19.2.8 to 19.3.0
- [Release notes](https://github.com/react/react/releases)
- [Changelog](https://github.com/react/react/blob/main/CHANGELOG.md)
- [Commits](https://github.com/react/react/commits/v19.3.0/packages/react)
Updates `@types/react` from 19.2.18 to 19.3.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react)
Updates `@types/node` from 26.5.0 to 26.6.1
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)
Updates `@types/react` from 19.2.18 to 19.3.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react)
Updates `@github/copilot-sdk` from 1.0.13 to 1.0.14
- [Release notes](https://github.com/github/copilot-sdk/releases)
- [Changelog](https://github.com/github/copilot-sdk/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/copilot-sdk/compare/v1.0.13...v1.0.14)
---
updated-dependencies:
- dependency-name: cspell
dependency-version: 10.3.3
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: minor-patch
- dependency-name: markdown-it
dependency-version: 15.0.2
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: minor-patch
- dependency-name: react
dependency-version: 19.3.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: minor-patch
- dependency-name: "@types/react"
dependency-version: 19.3.0
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: minor-patch
- dependency-name: "@types/node"
dependency-version: 26.6.1
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: minor-patch
- dependency-name: "@types/react"
dependency-version: 19.3.0
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: minor-patch
- dependency-name: "@github/copilot-sdk"
dependency-version: 1.0.14
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: minor-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brady Gaster <41929050+bradygaster@users.noreply.github.com>
* docs: require Issues before gh-aw install
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* docs: add gh-aw enlistment changeset
Add patch release metadata for the CLI and SDK templates changed by PR #2072.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* docs: fail closed when enabling Issues
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* docs: deduplicate gh-aw Issues changeset
Keep the fail-closed CLI and SDK release note from the review-fix commit as the single changeset for this documentation update.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Harden gh-aw workflow distribution integrity
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* test: add hosted gh-aw bootstrap e2e harness
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* test: align hosted e2e with bundle manifest
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* test: consume native gh-aw bundle contract
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* test: bind hosted e2e to resolved source
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix: normalize generated workflow whitespace
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix: harden native gh-aw package
Closes #2075
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix: capture gh-aw version output
Closes #2075
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix: use public registries for locked packages
Closes #2075
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix: narrow native gh-aw hardening scope
Keep the revision focused on the seven reviewed blockers and generate resource-free package workflow sources so remote gh-aw v0.89.21 installs the exact 7/15/1 topology without duplicate resources.\n\nCloses #2075\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix: verify remote package ownership
Normalize gh-aw's immutable source annotation when checking installed workflow bytes and match v0.89.21's 23-entry ownership record while verifying the skill separately.\n\nCloses #2075\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix: accept pinned gh-aw source annotations
Normalize only the two immutable source annotations emitted by gh-aw v0.89.21 before comparing installed workflow bytes to canonical digests.\n\nCloses #2075\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix: normalize installer trailing newline
Allow gh-aw v0.89.21's downloaded workflow representation to omit the canonical source's single final newline while preserving exact content verification.\n\nCloses #2075\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix: restore stable workspace lock dependency
Remove the build-generated prerelease SDK dependency floor from package-lock.json so the stable workspace policy remains satisfied.\n\nCloses #2075\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* test: align native package expectations
Replace stale six-workflow, ambient-version, and top-level Markdown assumptions with the current nested seven-workflow package contract.\n\nCloses #2075\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* test: delegate native install proof to CI
Replace the duplicate ambient-compiler install test with assertions for the exact nested package and pinned v0.89.21 strict-compile job.\n\nCloses #2075\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix: harden package trust boundaries
Reject symlinked manifest/runtime paths and require explicit credential-bearing child processes, including separation of source-read and mutation tokens.\n\nCloses #2075\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix: bind hosted bootstrap evidence (Part of #2075)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix: bind bootstrap outputs to run provenance
Part of #2075
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): protect dependency changelog
Closes #2091
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* ci: add repo-health PR-head shadow harness
Add a read-only pull_request shadow that exercises proposed scanners and the real reporter contract without mutating GitHub. Document the authoritative post-merge hostile-filename canary and label production comments by evidence level.
Closes #1800
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix: align repo-health fixtures with git transport
Closes #1800
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix: allow gh-aw cast genesis state
Closes #2067
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(repo-health): decode Git-quoted leakage paths
Closes #1800
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): fail closed on rejected squad commands
Closes #1824
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): route commands outside start position
Closes #1824
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* test(gh-aw): include command router in CI topology
Closes #1824
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* chore(gh-aw): keep command fix within review scope
Closes #1824
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): enforce independent Squad review and gate epic relay
Closes #1734
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* test(gh-aw): reconcile reviewed topology after final restack
Closes #1734
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): make review guard first-install safe
Closes #2103
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): fail closed on missing installed review guard
Closes #2103
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): bind first-install review identity
Part of #2103
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): verify clean-install package bytes
Bind reserved first-install identities to immutable canonical package content, exact installed ownership bytes, and normalized compiled lock digests. Add live-loader mutation coverage for source, lock, canonical-content, and fetch failures.\n\nRefs #2103\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): stabilize local install verification
Rebind local-package workflow sources before compilation and normalize only compiler-declared repository-scattered schedules in trusted lock digests.
Refs #2103
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): make first install a human trust boundary
Part of #2103
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): harden hosted strict compile fixture
Part of #2103
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): bind review to automatic PR runs
Part of #2105
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): attest review from base context
Part of #2103
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* test(gh-aw): expose installed lock digest mismatch
Part of #2103
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): dedicate review check identity
Part of #2103
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* chore: record dedicated review app change
Part of #2103
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): normalize compiler setup pin
Closes #2103
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(ci): align gh-aw compiler pin
Closes #2103
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* test(ci): enforce structural gh-aw compiler pins
Closes #2103
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* test(ci): reject continued and dynamic compiler installers
Closes #2103
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): replace reviewer App with native review authority (#2109)
Removes the dedicated reviewer App, private-key secret, environment, token minting, and custom Checks API publisher. Uses the base-controlled native GitHub Actions/gh-aw review job and exact-run relay binding, with context-only merge enforcement explicitly advisory unless source-bound policy is available.\n\nCloses #2103\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): verify native package source digest variants (#2111)
Supports both legitimate native installer provenance forms with complete source-selected digests and deterministic immutable gh-aw toolchain action pins. Integrity normalization and installed-byte verification remain unchanged.\n\nCloses #2103\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): submit bootstrap chunks without agent transcription (#2115)
* fix(gh-aw): submit bootstrap chunks without agent transcription
Closes #2112
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(ci): seed immutable actions in native workflow consumer
Closes #2112
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): preserve ownership staging with bounded index verification (#2116)
* fix(gh-aw): verify ownership metadata in staged installs
Handoff for independent revision: staged-tree enumeration still requires the reviewer-requested large-consumer correction before PR creation.
Closes #2113
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): bound staged install queries to required paths
Independently revise the rejected ownership staging handoff. Avoid recursive consumer-tree enumeration and preserve exact staged type and digest checks. Cover 20,000 unrelated tracked files, unchanged staging, bounded blob reads, index locks, and substituted directories.
Closes #2113
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* docs(changeset): record verified gh-aw ownership staging
Add the coordinator-authorized patch changeset for both template-shipping packages to satisfy the hosted changelog gate.
Closes #2113
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): correct exact enlistment compiler warning gate (#2118)
* fix(gh-aw): correct exact enlistment warning gate
Closes #2117
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* docs(gh-aw): retain bot-trigger explanation
Closes #2117
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Enforce coordinator scope and tracked behavior changes (#2110)
* fix: enforce coordinator scope boundaries
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix: address scope control review
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): harden hosted canary contracts (#2120)
* fix(gh-aw): harden hosted canary contracts
Validate bootstrap output in isolation before trusted writes, authorize mutating command dispatches, and bind review relays to the latest exact base-controlled run attempt.
Closes #2103
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): close review authorization gaps
Closes #2103
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix: ignore CommonMark tab-indented commands
Closes #2103
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): read committed cast registry from the checkout when validating an isolated bootstrap candidate
The materialize step copies the checkout into a .git-less candidate (#2120),
but committedRegistry() ran git rev-parse/ls-tree/show in that candidate, so
every bootstrap failed with 'registry base: committed HEAD is unavailable'.
Thread an optional gitRoot (default root) through validateBootstrapPayload ->
validateCastTree -> parseRegistry, and pass gitRoot: checkout from the
materializer. Adds a regression test.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* test(gh-aw): refresh pinned squad lock digests for the updated cast validator
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): require 0.89.22 for central ops
Closes octodemo/zava-social-cao-ops-20260929111840#18
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* feat(gh-aw): opt-in committed research scope for bootstrap
Adds .squad/research-scope.json (squad-research-scope/v1). When committed at HEAD, every bootstrap proposal must cite evidence under a declared root. Uncommitted scope files are ignored.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): preserve bootstrap candidate isolation
Validate candidate bytes from the isolated tree while resolving committed Cast provenance from the trusted checkout. Adds regression coverage for CAO integration issue octodemo/zava-social-cao-ops-20260929111840#26.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): preserve review provenance marker
Describe the implementation marker without a literal HTML comment so gh-aw retains the exact regex in compiled reviewer prompts. Adds compiled-artifact regression coverage for octodemo/zava-social-cao-ops-20260929111840#20.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): require exact enlistment compiler
Closes #2129
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): create bootstrap candidate payload parent
Part of #2128
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(test): raise Aspire dashboard health-check timeout to absorb CI runner contention (#2132)
* fix(test): pin Aspire dashboard image to verified-good 13.5.2 build
Root cause of the #2123/#2132 Aspire integration test CI failures was
NOT CPU contention: `mcr.microsoft.com/dotnet/aspire-dashboard:latest`
(and the major-version tag `:13`, confirmed to currently resolve to
the identical freshly-published `13.6.0` build/digest) is broken — the
container exits immediately (exitCode=145) because
/app/Aspire.Dashboard.dll is missing from the image, so the dashboard
health check can never succeed no matter the timeout.
Fix: pin docker pull/run to `:13.5.2`, a distinct ~3-week-older build
(different layer digests, verified via the MCR manifest API) that
predates the broken `13.6.0` release and does not exhibit the
missing-DLL problem.
Diagnostics hardening made while chasing this down (kept, as they are
independently valuable for any future flake in this suite):
- Removed --rm from the dashboard `docker run` so a crashed container
survives long enough for failure-path `docker inspect`/`docker logs`
diagnostics to run (relying on existing explicit removeContainer()
cleanup instead).
- Captured container stderr in the `docker logs` diagnostics call
(`2>&1`), since .NET unhandled-exception output goes to stderr and
was previously silently dropped, hiding the real crash reason.
- Raised isDockerAvailable()'s `docker info` timeout from 5s to 20s to
prevent false-skip of the whole Docker-dependent suite under CI CPU
contention (which would otherwise look like a false pass).
- Raised the dashboard health-check timeout to 120s as defense-in-depth
against genuine contention-induced slow starts, independent of the
image-pinning fix above.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(test): widen beforeAll hook budget for diagnostics margin
Addresses reviewer feedback on PR #2132:
- The 240s beforeAll hook budget had zero margin above the bounded
120s docker-pull timeout + 120s health-check timeout, so Vitest
could abort the hook with a generic timeout before
waitForHealthy's more informative crash diagnostics could be
thrown. Widened to 300s (~60s margin for container startup,
diagnostics collection, and Playwright browser launch).
- The --rm-vs-diagnostics concern on the same thread was already
resolved in a prior commit (docker run no longer passes --rm);
no further change needed there.
Also trims two overly verbose/speculative inline comments (image-pin
rationale, health-check rationale) down to the essential facts.
Closes #2133
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: brady gaster <bradygaster@github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* test: harden Aspire dashboard startup (#2134)
Pin the dashboard fixture to the verified 13.5.2 manifest and diagnose startup exits immediately with bounded container state and logs. Add deterministic regression coverage for the missing-DLL exit and hung health-request paths.
Closes #2133
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* deps: Bump Microsoft.NET.Test.Sdk from 18.10.0 to 18.10.1 (#2073)
---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
dependency-version: 18.10.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: microsoft-packages
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tamir Dresher <tamir.dresher@gmail.com>
* ci: Bump the github-actions group across 1 directory with 2 updates (#2087)
Bumps the github-actions group with 2 updates in the / directory: [github/gh-aw-actions/setup](https://github.com/github/gh-aw-actions) and [github/gh-aw-actions/setup-cli](https://github.com/github/gh-aw-actions).
Updates `github/gh-aw-actions/setup` from 0.89.17 to 0.90.0
- [Release notes](https://github.com/github/gh-aw-actions/releases)
- [Changelog](https://github.com/github/gh-aw-actions/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/gh-aw-actions/compare/f3b81cdb3070066a47faa9bdf440f4f1dc78b1f0...a65c3ae1e11016c37f426bb3847a6f5e1a7d58df)
Updates `github/gh-aw-actions/setup-cli` from 0.89.17 to 0.90.0
- [Release notes](https://github.com/github/gh-aw-actions/releases)
- [Changelog](https://github.com/github/gh-aw-actions/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/gh-aw-actions/compare/f3b81cdb3070066a47faa9bdf440f4f1dc78b1f0...a65c3ae1e11016c37f426bb3847a6f5e1a7d58df)
---
updated-dependencies:
- dependency-name: github/gh-aw-actions/setup
dependency-version: 0.89.21
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions
- dependency-name: github/gh-aw-actions/setup-cli
dependency-version: 0.89.21
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tamir Dresher <tamir.dresher@gmail.com>
* chore(deps): Bump @grpc/grpc-js in /samples/autonomous-pipeline (#2127)
Bumps [@grpc/grpc-js](https://github.com/grpc/grpc-node) from 1.14.3 to 1.14.5.
- [Release notes](https://github.com/grpc/grpc-node/releases)
- [Commits](https://github.com/grpc/grpc-node/compare/@grpc/grpc-js@1.14.3...@grpc/grpc-js@1.14.5)
---
updated-dependencies:
- dependency-name: "@grpc/grpc-js"
dependency-version: 1.14.5
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tamir Dresher <tamir.dresher@gmail.com>
* deps: Bump fast-uri from 3.1.7 to 3.1.8 (#2126)
Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.7 to 3.1.8.
- [Release notes](https://github.com/fastify/fast-uri/releases)
- [Commits](https://github.com/fastify/fast-uri/compare/v3.1.7...v3.1.8)
---
updated-dependencies:
- dependency-name: fast-uri
dependency-version: 3.1.8
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tamir Dresher <tamir.dresher@gmail.com>
* deps: Bump brace-expansion from 5.0.7 to 5.0.12 (#2125)
Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 5.0.7 to 5.0.12.
- [Release notes](https://github.com/juliangruber/brace-expansion/releases)
- [Commits](https://github.com/juliangruber/brace-expansion/compare/v5.0.7...v5.0.12)
---
updated-dependencies:
- dependency-name: brace-expansion
dependency-version: 5.0.12
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tamir Dresher <tamir.dresher@gmail.com>
* deps: Bump undici from 8.10.0 to 8.11.2 in /docs (#2097)
Bumps [undici](https://github.com/nodejs/undici) from 8.10.0 to 8.11.2.
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](https://github.com/nodejs/undici/compare/v8.10.0...v8.11.2)
---
updated-dependencies:
- dependency-name: undici
dependency-version: 8.11.2
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tamir Dresher <tamir.dresher@gmail.com>
* deps: Bump astro in /docs in the astro-minor-patch group (#2086)
Bumps the astro-minor-patch group in /docs with 1 update: [astro](https://github.com/withastro/astro/tree/HEAD/packages/astro).
Updates `astro` from 7.3.3 to 7.3.5
- [Release notes](https://github.com/withastro/astro/releases)
- [Changelog](https://github.com/withastro/astro/blob/main/packages/astro/CHANGELOG.md)
- [Commits](https://github.com/withastro/astro/commits/astro@7.3.5/packages/astro)
---
updated-dependencies:
- dependency-name: astro
dependency-version: 7.3.5
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: astro-minor-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tamir Dresher <tamir.dresher@gmail.com>
* deps: Bump ip-address from 10.4.0 to 10.7.2 (#2098)
Bumps [ip-address](https://github.com/beaugunderson/ip-address) from 10.4.0 to 10.7.2.
- [Release notes](https://github.com/beaugunderson/ip-address/releases)
- [Commits](https://github.com/beaugunderson/ip-address/compare/v10.4.0...v10.7.2)
---
updated-dependencies:
- dependency-name: ip-address
dependency-version: 10.7.2
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tamir Dresher <tamir.dresher@gmail.com>
* deps: Bump js-yaml and markdownlint-cli2 (#2108)
Bumps [js-yaml](https://github.com/nodeca/js-yaml) to 5.4.1 and updates ancestor dependency [markdownlint-cli2](https://github.com/DavidAnson/markdownlint-cli2). These dependencies need to be updated together.
Updates `js-yaml` from 5.2.2 to 5.4.1
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nodeca/js-yaml/compare/5.2.2...5.4.1)
Updates `markdownlint-cli2` from 0.23.2 to 0.23.3
- [Changelog](https://github.com/DavidAnson/markdownlint-cli2/blob/main/CHANGELOG.md)
- [Commits](https://github.com/DavidAnson/markdownlint-cli2/compare/v0.23.2...v0.23.3)
---
updated-dependencies:
- dependency-name: js-yaml
dependency-version: 5.4.1
dependency-type: indirect
- dependency-name: markdownlint-cli2
dependency-version: 0.23.3
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix(gh-aw): relay normalized squad commands through dispatch (#2136)
* fix(gh-aw): relay normalized squad commands through dispatch
Fixes three command-routing defects reported against source SHA
261d140679b158888f1a3c4d9a5a3e74eb55b633
(octodemo/zava-social-backend-20261001184422#1):
1. The lifecycle-repair fallback in the shared squad.md coordinator only
recognized exact, /squad-prefixed issue-comment bodies. A command
normalized and relayed by squad-command-router.md via workflow_dispatch
(e.g. the bare "activate" dispatch input for a /squad activate comment)
skipped repair entirely. Repair gating and the effective command are now
derived identically for both the issue_comment and workflow_dispatch
event paths (CANONICAL_BY_BARE_COMMAND normalization).
2. squad-command-router.md omitted `roles: all`, so gh-aw's default
write-role activation gate blocked the router from running at all for
non-write actors -- including modes the router intentionally allows
anyone to invoke. Added `roles: all`; the router's own in-script,
per-command authorization for mutating modes is unchanged.
3. The router's relayed dispatch dropped originating comment provenance, so
an embedded /squad approve-improvement could never supply a real
approval_comment_id and was rejected outright. The router now forwards
an aw_context pointer (item type/number + originating comment id)
through the dispatch, and squad-improvement-gate.mjs's
validateApprovalDispatchRelay re-fetches and validates that live comment,
binding permission to its own author -- never the dispatch actor -- so
approval binding is not weakened.
Package/lock/manifest regenerated via the standard
`node workflows/shared/squad-install-verifier.mjs --write-source` pipeline;
strict `gh aw compile --strict` passes with only the two documented
warnings. Added test/gh-aw-command-router-relay.test.ts (true end-to-end
router -> repair-job relay via real extracted step scripts, plus a
normalization mutation-kill test), and extended
test/gh-aw-command-parse.test.ts / test/gh-aw-improvement-worker.test.ts
with regression coverage for all three findings.
Local npm install is broken in this environment (missing transitive deps
such as fdir), so vitest/eslint cannot run locally; every new/changed
assertion was independently verified by direct Node/vm execution of the
real production modules and scripts, and by compiled-lock diffing. Hosted
CI at the PR head is the authoritative suite result.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): update compiled-digest golden hashes for relay fix
The roles: all / aw_context changes to squad.md and
squad-command-router.md legitimately alter the compiled squad.lock.yml
content. Update the three hardcoded golden SHA-256 digests in
test/gh-aw-quality.test.ts's canonical package integrity contract
suite to match, following the same pattern as commit b5455084.
Independently recomputed via direct execution of the real
compileWithPinnedActions/normalizeCompiledLock helpers (node
--experimental-strip-types, bypassing the broken local vitest
install) and confirmed to match hosted CI's reported values exactly.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): forward real item identity across the squad.md -> squad-improvement-worker relay hop
Fixes a downstream defect in the command-routing relay chain (flagged by
copilot-pull-request-reviewer[bot] against PR #2136, which fixed the three
originally-scoped findings from source SHA
261d140679b158888f1a3c4d9a5a3e74eb55b633,
octodemo/zava-social-backend-20261001184422#1).
Root cause: gh-aw's own dispatch_workflow safe-output engine
unconditionally overwrites any agent-supplied aw_context input with its
own buildAwContext() whenever a dispatch's target workflow declares an
aw_context workflow_dispatch input. buildAwContext() derives
item_type/item_number/comment_id solely from the CURRENT run's own event
payload -- never inherited across a hop. When a relayed (workflow_dispatch
-triggered) squad.md run dispatches to squad-improvement-worker via the
squad-approve-improvement skill, that dispatch goes through gh-aw's real
dispatch_workflow handler, so the engine always overwrites squad.md's
aw_context with its own context -- which, because squad.md's own run is a
workflow_dispatch event with no issue/comment payload, always carries empty
item_type/item_number/comment_id. collectImprovementContext's existing
strict exact-match check (correct for the native direct-comment path, where
the engine's own context genuinely is accurate) therefore always rejected
every relayed /squad approve-improvement, independent of any event_type
widening.
Fix (no gh-aw change; pure squad.md-side plumbing):
- squad-improvement-worker.md: declare a new, non-colliding
squad_approval_relay workflow_dispatch input (distinct name from
aw_context, so gh-aw's engine never auto-overwrites it) and wire a
parallel SQUAD_IMPROVE_RELAY_CONTEXT env var at both existing call sites.
- squad.md: the squad-approve-improvement skill now always forwards
squad_approval_relay: {event_type, item_type, item_number, comment_id}
alongside the existing issue_number/approval_comment_id inputs, reusing
the same already-resolved values.
- squad-improvement-gate.mjs: collectImprovementContext keeps the
unconditional repo/workflow_id provenance check against the engine's own
(always-accurate) context, then branches: native path (event_type ===
issue_comment) validates item identity against the engine context
unchanged; relayed path (any other event_type) validates with identical
exact-match strictness against the new SQUAD_IMPROVE_RELAY_CONTEXT
instead. No approval-binding check is weakened on either path; all
unconditional live re-verification (comment/permission/revocation/
revision/linked-PR checks) is untouched.
Regenerated workflows/package/*.md and workflows/squad-workflows.manifest.json
via `node workflows/shared/squad-install-verifier.mjs --write-source`.
Tests (test/gh-aw-improvement-worker.test.ts):
- Extends the skill-JSON-shape assertion for the new relay field.
- New describe block covering: relayed-path authorization success, repo/
workflow_id forgery still rejected, mutation-kill coverage (tampered
comment_id/item_number/item_type/event_type each independently rejected),
malformed/missing relay context rejected (no silent fallback to the
engine's empty item fields), native-path non-regression, source wiring
assertions, and a compiled-artifact assertion (gh aw compile --strict)
proving both the worker's lock.yml declares/wires the new input and
squad.lock.yml's compiled dispatch step actually emits
squad_approval_relay.
Verified locally: standalone Node execution of collectImprovementContext's
new branch logic (native path, relayed success, 4 mutation-kill cases, 3
malformed/missing-context cases, repo/workflow_id forgery); gh aw compile
--strict across all 8 installed workflows produces exactly the two
documented warnings (Compiled 8 workflows: 8 succeeded, 2 warnings);
per-workflow strict compiles of squad and squad-improvement-worker confirm
the new input/env/dispatch-field wiring in the generated lock.yml files.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* test(gh-aw): update stale compiled-lock golden digests after relay-context fix
Updating workflows/squad.md's squad-approve-improvement dispatch payload
(and squad-improvement-worker.md's new input/env wiring) changes the
compiled squad.lock.yml / squad-improvement-worker.lock.yml content, which
shifts the normalized SHA-256 digests asserted by the canonical package
integrity contract tests in test/gh-aw-quality.test.ts (tamper-mutation
fixtures recomputed over the new baseline compiled output).
Re-derived both digest pairs from the actual compiled output (workflow and
package source bindings) and updated the three assertions that pinned the
stale values. No test logic changed; this is a golden-value refresh
consistent with the same pattern applied for the three originally-scoped
fixes earlier in this PR.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): bind router commands to text author (#2141)
Fixes octodemo/zava-social-queue-worker-20261001211503#1
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): harden GA-review-blocked source contract (9 findings)
Fixes 9 confirmed GH-AW GA review blockers as one coherent source-contract
hardening pass:
1. squad-improvement-gate.mjs: added regression/mutation test coverage for
rejecting a content-only modification of an already-tracked executable
(100755) Markdown improvement target (production ALLOWED_FILE_MODE guard
was already correct; the defect was a test-coverage gap).
2. squad_approval_relay: unambiguous JSON-string contract end-to-end between
squad.md and squad-improvement-worker.md/gate, preserving the distinct
input name since gh-aw overwrites aw_context.
3. squad-review-guard.mjs: added regression tests confirming override
candidates are authorized before cardinality/record validation, so
malformed or unauthorized markers fail closed.
4. squad-planning-ontology.md: normalized `Result: ✅ PASS` to the exact
`RESULT: PASS` string downstream parsers require.
5. squad-install-verifier.mjs: confirmed verifyInstalledBytes() normalizes
only the one documented injected source: binding before hashing and
fails on any other tamper; existing mutation-test table already covers
this (no source change needed).
6. Numeric issue/comment IDs from issue_comment events are canonicalized to
safe-integer strings before comparison against workflow_dispatch string
inputs; invalid forms are rejected. Direct and relayed coverage added.
7. squad-command-router.md: block replay of bot-authored standalone /squad
issue/comment command text while preserving trusted workflow_dispatch
continuation and documented bot behavior, for created/edited events.
8. can_approve_pull_request_reviews: proved via gh-aw source this is a
single combined toggle gating both GITHUB_TOKEN PR creation and PR-review
approval (cannot be split via job permissions). Per least-privilege
policy and the mandatory independent-human-approval requirement, flipped
true->false across all public/enlistment/setup copies and added a
fallback-to-issue mechanism (manual compare-URL link) to
squad-bootstrap.md for when push succeeds but PR creation is blocked.
9. Eliminated unbounded mutable commits/dev channel resolution; GA install
guidance now requires an explicit, pre-validated 40-character SQUAD_SHA,
synced across public/enlistment docs and skill mirrors. Exact-SHA
fixture testing is unaffected; no release is published.
Verification:
- All 28 gh-aw-prefixed test files pass (1849/1849 tests), including the
previously-failing test/gh-aw-install-staging.test.ts (15/15) after
regenerating workflows/squad-workflows.manifest.json via
`npm run gh-aw:integrity:write` to pick up the item 8/9 SKILL.md edits.
- packages/squad-sdk and packages/squad-cli both build cleanly
(tsc --noEmit reports zero warnings/errors for both).
- Real (non-mocked) `gh aw compile --strict` against the canonical
workflows/*.md sources compiles all 8 workflows successfully and
produces exactly the two documented/allowed warnings (pull_request_target
advisory on squad-review.md; bot-trigger advisory on squad.md).
- Independent security review found no high-confidence issues.
- No package.json/package-lock.json drift anywhere in the tree.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): avoid false-positive security scan on bootstrap fallback marker
gh-aw's --strict compile security scanner flags any unclosed '<!--' token
because it scans forward to the nearest subsequent '-->' anywhere in the
file (a hidden-content/prompt-injection detection heuristic). The item-8
bootstrap PR-fallback marker intentionally stored only the opening '<!--'
as a module constant and appended the closing '-->' later via string
interpolation, which made the scanner capture ~240 lines of unrelated JS
as a single 'HTML comment' and reject it as suspicious content.
Fix: build the complete marker (open + close delimiters together) in a
single template literal inside bootstrapPrFallbackIssueMarker(), exactly
mirroring the existing (already-safe) BOOTSTRAP_ISSUE_MARKER shape. The
runtime marker text is byte-identical (verified via direct invocation);
only the constant's exported value lost its leading '<!-- ' (now built at
call time instead).
Regenerated the pinned SHA-256 digest for squad-bootstrap-validator.mjs
via 'npm run gh-aw:integrity:write' (workflows/squad-bootstrap.md,
workflows/package/squad-bootstrap.md, workflows/squad-workflows.manifest.json).
Verified:
- node workflows/shared/squad-install-verifier.mjs --check-source: current
- npx vitest run test/gh-aw-bootstrap-workflow.test.ts: 33/33 passed
- npx vitest run test/gh-aw-*.test.ts (28 files): 1849/1849 passed
- Real (non-mocked) 'gh aw compile --strict --no-check-update' against a
scratch materialized .github/workflows/ tree: security scan passes,
8/8 workflows compile, exactly 2 allowed warnings (pull_request_target
advisory + slash_command/bots advisory) — matching CI's failing job.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): trusted signed-provenance fallback for manual bootstrap PR
Replace the dead-end manual-PR-fallback boundary flagged in Copilot
auto-review with a narrowly-scoped trusted path: the bootstrap
workflow now stamps a signed, machine-readable provenance line
(repo/run/base branch/head branch/head SHA/compare URL) into the
fallback issue body it files when GITHUB_TOKEN cannot open the Cast
PR itself. squad-review-guard validates a human-opened Cast PR
against that provenance record end-to-end (aggregate fields, compare
URL, run binding, issue-created-before-PR ordering) before granting
@squad/base-controlled-bootstrap / @squad/base-controlled-review
roles, with every other provenance/review/content/head check
unchanged and malformed/forged records still failing closed.
- workflows/shared/squad-bootstrap-validator.mjs: add
buildBootstrapPrFallbackProvenanceLine/parseBootstrapPrFallbackProvenance/
buildBootstrapPrFallbackCompareUrl; buildBootstrapPrFallbackIssueBody
now requires a signed provenanceLine argument.
- workflows/shared/squad-review-guard.mjs: add
validateBootstrapPrFallbackAttribution, wired ahead of the existing
bot-authored bootstrap-PR path so a verified fallback PR is treated
identically (including the bootstrap-run-success gate).
- workflows/squad-bootstrap.md (+ generated package copy): thread the
signed provenance line into the fallback issue body.
- test/gh-aw-review-guard.test.ts: full new fallback-scenario suite
(valid fallback incl. enforceReviewOutputs parity, run-success
gating, unrelated/ambiguous-issue rejection, and a 15-case mutation
table for forged/edited/malformed provenance) — mutation-verified by
independently neutering each of the 4 requireThat checks in
validateBootstrapPrFallbackAttribution.
- test/gh-aw-bootstrap-workflow.test.ts: update VM-sandboxed
stateModule mock and fixtures for the new provenance-line export and
strict 40-hex-char head-SHA validation.
- docs/src/content/docs/guide/gh-aw.md: document the new
signed-provenance trust model and its exact matching requirements.
- workflows/squad-command-router.md (+ generated package copy),
gh-aw-enlistment SKILL.md copies, scripts/gh-aw-hosted-e2e.mjs,
test/gh-aw-hosted-e2e.test.ts, workflows/squad-workflows.manifest.json:
carry-through updates for findings 7-9 (bot-authored command
blocking, can_approve_pull_request_reviews=false default, explicit
SHA-pinned enlistment) already validated earlier this PR; this
commit regenerates the manifest/package artifacts to match.
Verified: npx vitest run test/gh-aw-*.test.ts (28 files, 1884 tests,
all passing); npm run lint (tsc --noEmit, both packages, clean); real
scratch-consumer gh aw compile --strict across all 8 package
workflows with exactly the 2 previously-allowed warnings preserved;
npm run gh-aw:integrity:write regenerated manifest/package artifacts
cleanly.
Addresses PR #2142 review finding Medium #3 (bootstrap PR fallback
cannot satisfy provenance checks), per coordinator-approved redesign.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* docs(changeset): note signed-provenance bootstrap-PR fallback redesign
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): harden bootstrap-PR-fallback trust and command-router bot block (8 review findings)
Addresses the 8 fresh Copilot auto-review findings from the review on
commit 9b45d116 (after the signed-provenance fallback redesign):
- squad-bootstrap-validator.mjs: filter fallback-issue dedupe/ambiguity
candidates by bot-authorship + title + valid-provenance *before*
counting/matching, closing a decoy-issue forgery/DoS gap.
- squad-review-guard.mjs: bind the fallback provenance path's cited
bootstrap run to the exact base commit (run.head_sha === pr.base.sha),
matching the bot-authored path's existing binding.
- scripts/gh-aw-hosted-e2e.mjs: validate the full signed provenance
record (independently re-implemented, not imported) instead of a
plain-text marker/compare-URL substring check, so the hosted E2E can
no longer report success for a fallback issue production would reject.
- squad-command-router.md: add direct test coverage (user.type /
payload.sender.type fixtures, previously never populated) proving the
existing bot-authorship block is reachable and enforced for both
created and edited events, with mutation-kill tests.
- Updated docs/src/content/docs/guide/gh-aw.md, .github/agents.md,
README.md (removed a stale @dev-tracking note contradicting the
explicit-SQUAD_SHA policy), and all 5 synchronized copies of
skills/gh-aw-enlistment/SKILL.md to describe the fallback-issue-first
Cast PR flow.
Verified: full test/gh-aw-*.test.ts suite (28 files, 1896 tests) passes;
npm run lint (tsc --noEmit, both packages) clean; a real scratch-consumer
`gh aw compile --strict` against workflows/package/*.md produces exactly
the two documented warnings. No stable release published.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* docs(gh-aw): close remaining stale automatic-Cast-PR passages (review threads 1-8)
Follow-up to f1084ec1: fixed two stale passages a second hosted-review
pass on the same commit flagged:
- skills/gh-aw-enlistment/SKILL.md anti-pattern list still said
'automatic Cast PR' unconditionally.
- docs/src/content/docs/guide/gh-aw.md activation-canary/automatic-
bootstrap checklist rows still described only the unconditional-
automatic case, including research-proposals-issue creation timing.
Both now cover the manual-fallback path and its provenance
requirement. Regenerated workflows/squad-workflows.manifest.json via
npm run gh-aw:integrity:write (SKILL.md digest only).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): resolve fresh Copilot review findings on PR #2142 (7 fixes)
Fresh hosted Copilot review on commit 3bf5c01f surfaced 1 new Medium finding
plus 6 previously-missed findings. All 7 are fixed/tested:
- squad-bootstrap-validator.mjs: edited-fallback-issue dedupe bug (Medium) -
findExistingBootstrapPrFallbackIssue now requires unedited created_at ===
updated_at timestamps, mirroring validateBootstrapPrFallbackAttribution's
review-time requirement exactly.
- gh-aw-hosted-e2e.mjs: selectBootstrapFallback now mirrors the same
open-state and unedited-timestamp lifecycle checks production enforces.
- squad-review-guard.mjs: validateBootstrapPrFallbackAttribution tightened
from `!== 'Bot'` to `=== 'User'` so non-Bot, non-User account types
(Organization, Mannequin) can no longer pass fallback-PR authorship.
- squad-review-guard.mjs: assertClearingReview now caches collaborator
permission lookups per login for the duration of one evaluation.
- squad-improvement-gate.mjs: added direct test coverage for sameNumericId's
cross-type normalization and malformed/overflow rejection at the nested
origin.item_number/relay.item_number level (production was already
correct; this closed a test-only gap).
- squad-planning-ontology.md: added a regression test pinning the exact
RESULT: <PASS | FAIL> template text (production doc was already correct;
test-only gap).
- squad-bootstrap-validator.mjs: buildBootstrapPrFallbackIssueBody now tells
the human to manually re-run the workflow if they want the linked
research-proposals issue before merging the fallback-opened Cast PR, since
no GitHub event re-triggers bootstrap until the next default-branch push.
Proved via a scratch gh aw compile --strict run that adding a
pull_request_target trigger instead would both require an unacceptable
checkout: false security posture change and break the documented
'exactly two compile warnings' contract - a missing instruction, not a
missing trigger, was the actual defect.
Regenerated workflows/squad-workflows.manifest.json and the generated
workflows/package/squad-bootstrap.md copy via npm run gh-aw:integrity:write
to pick up the new source digests. Synced the 4 enlistment SKILL.md mirror
copies via npm run sync-templates.
All 28 gh-aw-*.test.ts files / 1919 tests pass. npm run lint clean. The
enlistment-skill compile-warning-allowlist contract (exactly two warnings)
remains intact.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): close bootstrap-fallback dedupe staleness, title-check, and notification gaps (review on 1a9c4081)
- squad-bootstrap-validator.mjs: add base_sha staleness binding to the
fallback-issue provenance record so an old fallback issue is no longer
silently reused once the default branch advances past it.
- squad-review-guard.mjs: require the canonical Cast-PR title on the
fallback review path too, matching the bot-authored path.
- squad-bootstrap.md: reword the run-success notification to be accurate
when only the fallback issue (not a Cast PR) exists.
- Regenerate workflows/package/squad-bootstrap.md and
squad-workflows.manifest.json via npm run gh-aw:integrity:write.
- Update docs/src/content/docs/guide/gh-aw.md fallback-provenance section.
- Add regression + mutation coverage across
gh-aw-bootstrap-workflow.test.ts, gh-aw-review-guard.test.ts, and
gh-aw-hosted-e2e.test.ts (staleness, malformed-argument, title-rejection
cases).
Validated: targeted test files (308/308), full gh-aw suite
(28 files / 1921 tests), npm run lint (tsc), npm run lint:eslint
(0 errors), npm run build.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): close workflow_dispatch fallback dead-end and E2E fallback-terminal gap
Fresh Copilot review on commit e024db94 surfaced two findings:
- High (workflows/squad-bootstrap.md): a workflow_dispatch run could open a
bootstrap-PR-fallback issue that squad-review-guard.mjs's
validateBootstrapPrFallbackAttribution can never authorize (it requires
event === 'push'), and dedupe matching would keep reusing that permanently
dead-end issue forever. Now fails closed with an actionable error instead.
- Medium (scripts/gh-aw-hosted-e2e.mjs): the hosted E2E's fallback outcome
reported terminal success the moment bootstrap opened the fallback issue,
without ever exercising the Cast-PR-fallback review/attribution path. The
obvious fix (E2E opens the Cast PR itself with its own PAT) was rejected:
that would substitute automation for the human-in-the-loop step
can_approve_pull_request_reviews=false exists to require. Instead the
fallback outcome is now non-terminal (awaiting_manual_pr); a new read-only
selectManualFallbackCastPr independently re-derives production's
authorization logic to observe (never create) a human-opened PR, and a new
resume-fallback command + squad-gh-aw-hosted-e2e-resume dispatch trigger
let a later run resume from the original run's persisted baseline identity
to validate that PR through to the same base-controlled Squad Review
canary the bot-authored path exercises.
Added regression/mutation coverage for both findings and regenerated the
installed package mirror/manifest digests via
`npm run gh-aw:integrity:write`.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* docs(gh-aw): document and prove resume-fallback token scoping
Addresses a sibling-session scope-gate follow-up on the resume-fallback job
added for the hosted-E2E Medium-finding redesign: audit confirmed the job's
`secrets.SQUAD_GH_AW_E2E_TOKEN` usage never creates, approves, or mutates the
Cast fallback pull request. It is reused (not removable) only because no
separate read-only PAT exists for the external target fixture repository and
`github.token` cannot reach a repository outside this one.
Documents each job's token scoping separately in the workflow comments, and
adds a transitive-call-graph test proving every function `resumeFallback` can
reach (`bootstrapOutputs`, the `githubAdapter` block,
`selectManualFallbackCastPr`, `waitForManualFallbackCastPr`,
`waitForBaseControlledReviewCanary`) issues only GET `gh api` calls -- no
`pr create`/`pr merge`/`pr review`/write `--method` call anywhere in that
reachable graph.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): remove cross-repo secret from bootstrap-PR fallback continuation
Architectural correction to the hosted-E2E fallback redesign: no credential
(PAT, GitHub App token, or repository/environment secret) may ever be used to
observe or validate the manually opened Cast PR, even read-only. A
workflow-held credential capable of reading that PR's state undermines the
can_approve_pull_request_reviews=false trust boundary, which exists
specifically so a human must act outside of any CI-held credential.
- Reverted .github/workflows/squad-gh-aw-hosted-e2e.yml to its pre-existing
baseline: removes the resume-fallback job, its squad-gh-aw-hosted-e2e-resume
dispatch trigger, and the action-gating added for it. File is now byte-
identical to origin/dev (zero net diff).
- hosted()'s fallback branch no longer calls bootstrapOutputs()/
selectManualFallbackCastPr()/waitForBaseControlledReviewCanary() inline and
makes zero further GitHub API calls. It now parses the fallback issue's own
already-fetched provenance body (parseBootstrapPrFallbackProvenance, a pure
string-parsing function) and terminates immediately, non-terminally, at
status: 'awaiting_manual_pr' with complete evidence (target, fallback issue,
head/base branch+SHA, compare URL, next_step instructions).
- The target repository's own installed Squad Review workflow validates the
human-opened PR locally, using that repository's own GITHUB_TOKEN/gh-aw
authority -- no cross-repository read by this controller is needed.
- resumeFallback() is retained unchanged internally (still provably GET-only
via the existing transitive call-graph test) but is now framed exclusively
as a local, operator-run-only CLI command: never wired to any Actions job
or repository_dispatch trigger, relying only on the operator's own
`gh auth login` session, never a repository secret.
- Updated test/gh-aw-hosted-e2e.test.ts: workflow-topology test now asserts a
single hosted-e2e job/dispatch type and explicit absence of any
resume-fallback job; added a test asserting hosted()'s fallback branch
writes complete evidence with none of the removed inline calls present;
the dispatcher-wiring test now asserts resumeFallback's doc comment states
it is operator-run-only/never-CI-wired/never-secret-backed and that the
workflow file contains no reference to it. Removed the now-obsolete
per-job token-scoping test (the job no longer exists). The existing
transitive read-only call-graph proof for resumeFallback is unchanged.
- Updated .changeset/gh-aw-ga-review-hardening.md with a new section
documenting this correction.
Validation:
- npx vitest run test/gh-aw-hosted-e2e.test.ts -> 139/139 pass
- npx vitest run test/gh-aw*.test.ts -> 28 files / 1938 tests pass
- npm run lint (tsc, both packages) -> clean
- npm run lint:eslint -> 0 errors (pre-existing warning baseline only)
- npm run build -> succeeds (prebuild version-bump side effects reverted)
- npm run gh-aw:integrity:check -> current (no canonical workflow source
touched this round)
- Scratch-consumer gh-aw compile --strict (mirroring squad-ci.yml's
gh-aw-compile job exactly): 8/8 workflows compile, exactly 2 documented
warnings (pull_request_target advisory on squad-review.md; bots:/
slash_command advisory on squad.md); all 8 compile individually with
--strict; squad-install-verifier.mjs --verify-install --strict-compile
passes.
- git diff origin/dev -- .github/workflows/squad-gh-aw-hosted-e2e.yml -> empty
(file content is byte-identical to dev; this path no longer appears in the
PR's net diff against dev)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): close base-sha drift, bootstrap-branch doc, and resume-fallback gaps from fresh review
Fixes 7 Copilot review findings on commit 140ce8eb:
- scripts/gh-aw-hosted-e2e.mjs: next_step instruction for resume-fallback
was missing its three required CLI flags; now emits a complete
gh run download + resume-fallback --target/--evidence-in/--evidence
recipe with interpolated values.
- workflows/shared/squad-review-guard.mjs: the bootstrap-PR fallback
review path bound to the live, mutable pr.base.sha, making manual
recovery permanently unrecoverable after any further default-branch
commit. Replaced with a GitHub Compare API ancestry check
(identical/ahead) that also binds the response's own resolved
base_commit/merge_base_commit SHAs back to the immutable
provenance.base_sha, and fails closed on any compare API error.
findExistingBootstrapPrFallbackIssue's baseSha is now optional for
the review-path lookup (push-triggered dedupe caller is unchanged).
- skills/gh-aw-enlistment/SKILL.md (canonical + 4 synced mirrors):
fixed the automated fallback explanation to name the real Cast
fallback branch (squad/bootstrap-cast) instead of the unrelated
human-run install branch (chore/squad-gh-aw-bootstrap).
Regenerated workflows/squad-workflows.manifest.json and the embedded
digest in workflows/squad-bootstrap.md / workflows/package/squad-bootstrap.md
via npm run gh-aw:integrity:write; confirmed clean via
npm run gh-aw:integrity:check.
Added regression + mutation test coverage for all three findings,
including four new binding-mutation tests proving a passing compare
status alone is insufficient without base_commit/merge_base_commit
SHA agreement.
Validation: full test/gh-aw*.test.ts suite (28 files, 1949 tests)
passes; npm run lint (tsc --noEmit, both packages) clean; npm run
build clean. Two pre-existing, unrelated failures (test/cli/copilot.test.ts,
test/acceptance/acceptance.test.ts, one case in test/cli/cast.test.ts)
reproduce identically on the pre-session tree via git stash and are
unaffected by this change.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* fix(gh-aw): resolve fresh review findings on bb805b2c (ambiguous fallback matches, merge-trigger claim, open-PR filter)
- squad-bootstrap-validator.mjs: fix a regression this session's own prior
fix introduced - when baseSha is omitted (review path), multiple genuine
open fallback-issue matches (stale + fresh across base drift) no longer
throw "Ambiguous"; they resolve deterministically to the newest match,
unless they share the identical base_sha (a true unresolvable duplicate),
which still fails closed regardless of caller.
- squad-bootstrap-validator.mjs + canonical SKILL.md (+4 mirrors): correct
the false claim that merging a Cast PR automatically retriggers Squad
Bootstrap - confirmed via squad-bootstrap.md's push trigger paths that
it never does; manual workflow_dispatch is always required, before or
after merge.
- gh-aw-hosted-e2e.mjs: selectManualFallbackCastPr now requires
pr.state === 'open', excluding closed/merged look-alike PRs from the
manual fallback candidate set.
- docs/guide/gh-aw.md: rewrite the fallb…
Preserve stable release changes from #2173, #2164 and #2166 alongside the github-org migration. Resolve historical squash conflicts against the dev parent of the original #2241 promotion, whose resulting tree is identical to main. Carry sanitized-test fixes; do not duplicate context-tier guidance or policy outcome emission. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Synchronize package/plugin/NuGet release metadata, consume 25 reviewed changesets into the stable changelog, preserve historical release notes and github-org identity, and document exact-SHA human-only promotion/publication. Refs #2241, #2173, #2164. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
🔴 Impact Analysis — PR #2534Risk tier: 🔴 CRITICAL 📊 Summary
🎯 Risk Factors
📦 Modules Affecteddocs (7 files)
root (33 files)
scripts (1 file)
squad-cli (2 files)
squad-sdk (2 files)
tests (5 files)
|
🛫 PR Readiness Check
PR Scope: 🔧 Infrastructure
|
| Status | Check | Details |
|---|---|---|
| ❌ | Single commit | 16 commits — consider squashing before review |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | Changeset file found |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ❌ | Copilot threads resolved | 5 unresolved Copilot thread(s) — fix and resolve before merging |
| ✅ | CI passing | All checks passing |
Files Changed (50 files, +271 −200)
| File | +/− |
|---|---|
.changeset/backend-outage-stop.md |
+0 −6 |
.changeset/claude-agent-sdk-harness.md |
+0 −6 |
.changeset/claude-agent-tool-dispatch.md |
+0 −5 |
.changeset/claude-code-plugin.md |
+0 −8 |
.changeset/claude-dashboard.md |
+0 −5 |
.changeset/claude-demo-blockers.md |
+0 −6 |
.changeset/claude-governance-hooks.md |
+0 −6 |
.changeset/claude-init-inline-cast.md |
+0 −6 |
.changeset/claude-linked-team.md |
+0 −6 |
.changeset/claude-member-subagents.md |
+0 −6 |
.changeset/claude-polish.md |
+0 −10 |
.changeset/claude-projection-v2.md |
+0 −5 |
.changeset/claude-skills-projection.md |
+0 −5 |
.changeset/claude-watch-preset.md |
+0 −5 |
.changeset/dashboard-headless-end.md |
+0 −5 |
.changeset/decide-where-stored.md |
+0 −5 |
.changeset/doctor-real-paths.md |
+0 −5 |
.changeset/human-signoff-gate.md |
+0 −6 |
.changeset/init-next-steps.md |
+0 −5 |
.changeset/launcher-path-lookup.md |
+0 −6 |
.changeset/mcp-launcher-subfolder.md |
+0 −6 |
.changeset/plugin-icon-human-members.md |
+0 −6 |
.changeset/portable-launch.md |
+0 −6 |
.changeset/self-sufficient-digests.md |
+0 −6 |
.changeset/symlinked-team-root.md |
+0 −6 |
.claude-plugin/marketplace.json |
+1 −1 |
CHANGELOG.md |
+57 −4 |
docs/_internal/release-checklist.md |
+10 −1 |
docs/src/content/docs/features/state-backends.md |
+0 −1 |
docs/src/content/docs/get-started/installation.md |
+0 −1 |
docs/src/content/docs/get-started/migration.md |
+1 −1 |
docs/src/content/docs/scenarios/release-process.md |
+47 −11 |
docs/src/content/docs/whatsnew.md |
+18 −2 |
docs/src/pages/index.astro |
+1 −1 |
package-lock.json |
+13 −5 |
package.json |
+1 −1 |
packages/squad-cli/CHANGELOG.md |
+14 −0 |
packages/squad-cli/package.json |
+2 −2 |
packages/squad-sdk/CHANGELOG.md |
+14 −0 |
packages/squad-sdk/package.json |
+1 −1 |
plugins/squad/.claude-plugin/plugin.json |
+1 −1 |
plugins/squad/README.md |
+2 −2 |
plugins/squad/agents/squad.md |
+1 −1 |
scripts/release/test-reconciliation.mjs |
+7 −0 |
src/Squad.Agents.AI/Squad.Agents.AI.csproj |
+1 −1 |
test/acceptance/steps/cli-steps.ts |
+25 −3 |
test/agent-provenance.test.ts |
+13 −5 |
test/gh-aw-quality.test.ts |
+8 −3 |
test/ralph-reference-authority.test.ts |
+2 −2 |
test/test-reconciliation.test.ts |
+31 −3 |
Total: +271 −200
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
🏗️ Architectural Review
Automated architectural review — informational only. |
🔒 Security Review
🔒 Security review: 3 info.
Automated security review — informational only. |
Classify only the reviewed provenance assertion skips while retaining the live-team producer contract and fail-on-unexplained gate. Refs #2534. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Release blockers remain: NuGet publication bypasses the promised human dispatch, unexplained test skips fail the release verification gate, and installation instructions reference a version that does not match the package being built.
5 open issues
What changed in this PR
Prepares Squad 2.0.0 stable on dev, reconciling recent main changes while updating release metadata, documentation, and tests for sanitized release checkouts.
Changes:
- Aligns npm workspace versions, the CLI’s SDK dependency floor, NuGet metadata, and Claude plugin stamps.
- Consolidates 25 changeset fragments into stable release notes and refreshes current-version documentation.
- Carries forward sanitized-checkout test support and clarifies promotion and publication instructions.
| File | Description |
|---|---|
test/ralph-reference-authority.test.ts |
Filters absent live-team reference paths. |
test/gh-aw-quality.test.ts |
Makes live-routing checks conditional. |
test/agent-provenance.test.ts |
Handles checkouts without a live registry. |
test/acceptance/steps/cli-steps.ts |
Initializes isolated acceptance-test projects. |
src/Squad.Agents.AI/Squad.Agents.AI.csproj |
Sets NuGet source version to 2.0.0. |
plugins/squad/README.md |
Updates generated plugin version text. |
plugins/squad/agents/squad.md |
Updates the coordinator’s version handshake. |
plugins/squad/.claude-plugin/plugin.json |
Sets plugin version to 2.0.0. |
packages/squad-sdk/package.json |
Sets SDK version to 2.0.0. |
packages/squad-sdk/CHANGELOG.md |
Adds SDK stable-release notes. |
packages/squad-cli/package.json |
Sets CLI version and stable SDK floor. |
packages/squad-cli/CHANGELOG.md |
Adds CLI stable-release notes. |
package.json |
Sets root version to 2.0.0. |
package-lock.json |
Synchronizes versions and optional peer metadata. |
docs/src/pages/index.astro |
Updates the stable-release label. |
docs/src/content/docs/whatsnew.md |
Adds the 2.0.0 stable overview. |
docs/src/content/docs/scenarios/release-process.md |
Clarifies promotion and exact-SHA publication. |
docs/src/content/docs/get-started/migration.md |
Updates expected stable-version output. |
docs/src/content/docs/get-started/installation.md |
Removes a blank line only. |
docs/src/content/docs/features/state-backends.md |
Removes a blank line only. |
docs/_internal/release-checklist.md |
Documents promotion paths and publication flags. |
CHANGELOG.md |
Adds dated 2.0.0 notes and migration guidance. |
.claude-plugin/marketplace.json |
Sets marketplace version to 2.0.0. |
.changeset/symlinked-team-root.md |
Removes consumed symlink-path fix notes. |
.changeset/self-sufficient-digests.md |
Removes consumed coordinator-independence notes. |
.changeset/portable-launch.md |
Removes consumed portable-launcher notes. |
.changeset/plugin-icon-human-members.md |
Removes consumed plugin asset notes. |
.changeset/mcp-launcher-subfolder.md |
Removes consumed subfolder-launch fix notes. |
.changeset/launcher-path-lookup.md |
Removes consumed PATH-resolution notes. |
.changeset/init-next-steps.md |
Removes consumed host-specific init guidance. |
.changeset/human-signoff-gate.md |
Removes consumed human-sign-off notes. |
.changeset/doctor-real-paths.md |
Removes consumed real-path diagnostic notes. |
.changeset/decide-where-stored.md |
Removes consumed decision-storage messaging notes. |
.changeset/dashboard-headless-end.md |
Removes consumed headless-session completion notes. |
.changeset/claude-watch-preset.md |
Removes consumed Claude watch-runner notes. |
.changeset/claude-skills-projection.md |
Removes consumed native-skill projection notes. |
.changeset/claude-projection-v2.md |
Removes consumed projection-version notes. |
.changeset/claude-polish.md |
Removes consumed Claude integration follow-ups. |
.changeset/claude-member-subagents.md |
Removes consumed member-subagent notes. |
.changeset/claude-linked-team.md |
Removes consumed linked-team support notes. |
.changeset/claude-init-inline-cast.md |
Removes consumed init-mode casting guidance. |
.changeset/claude-governance-hooks.md |
Removes consumed advisory-hook notes. |
.changeset/claude-demo-blockers.md |
Removes consumed permissions and review-gate notes. |
.changeset/claude-dashboard.md |
Removes consumed dashboard feature notes. |
.changeset/claude-code-plugin.md |
Removes consumed plugin and streaming notes. |
.changeset/claude-agent-tool-dispatch.md |
Removes consumed subagent-tool wording notes. |
.changeset/claude-agent-sdk-harness.md |
Removes consumed execution-harness notes. |
.changeset/backend-outage-stop.md |
Removes consumed backend-outage handling notes. |
Review effort: Max (adaptive)
| setting this version does not publish the package. | ||
| --> | ||
| <Version>1.0.0</Version> | ||
| <Version>2.0.0</Version> |
| setting this version does not publish the package. | ||
| --> | ||
| <Version>1.0.0</Version> | ||
| <Version>2.0.0</Version> |
| it.skipIf(hasLiveRegistry)( | ||
| 'skips the live-team producer audit when the sanitized checkout has no .squad directory', |
| // #2015 isolation). Mirrors the sibling "without a .squad directory" | ||
| // step's use of an isolated temp dir, and downstream "I run" steps pick | ||
| // up context.tempDir automatically. | ||
| const tempDir = mkdtempSync(join(tmpdir(), 'squad-e2e-')); |
| const liveRoutingPath = join(process.cwd(), '.squad/routing.md'); | ||
| if (existsSync(liveRoutingPath)) { | ||
| expect(readText(liveRoutingPath)).toContain( | ||
| '| Agentic workflows | agentic-workflows-dev |', | ||
| ); | ||
| } else { | ||
| expect(existsSync(liveRoutingPath)).toBe(false); | ||
| } |
Resolve docs/src/pages/index.astro by keeping the #2447 redesign and setting the homepage label to v2.0.0. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>


What
Prepare Squad 2.0.0 stable on
dev, including a real back-merge of currentmain, synchronized root/CLI/SDK versions and lockfile, CLI SDK floor>=2.0.0, generated Claude plugin stamps, NuGet package metadata, and the dated stable changelog. This PR does not publish, tag, promote, or dispatch a release workflow.Why
Maintainer-requested Squad 2 release preparation. Preserve the recent stable-release work, especially David Pine's docs (#2173), Homebrew/WinGet authentication repair (#2164), 1.0.1 preparation (#2166), historical changelog entries, and the later
github/squadorganization migration. npm package names deliberately remain@bradygaster.How
Evidence-based ancestry repair, not an ours/theirs blanket merge.
Current
main(c24da2aa) is a squash of the original #2241 promotion head7ca30467; those two entire trees are byte-identical. That original promotion's dev parentd5076d91is an ancestor of current dev. Comparing main against that recovered parent isolates the actual stable-only drift from historical squash conflicts. The ordinary merge reports 284 conflicted paths; a three-way simulation against the recovered dev parent has zero conflicts. The committed reconciliation is a real two-parent merge, with current main as its second parent.Audited all 1,299 unique paths changed by the 12 main-only commits: 965 already present, 283 subsequently evolved on dev, six substantive/whitespace deltas carried forward, six duplicate-only deltas deliberately not reintroduced, three install-generated lockfile deltas superseded by current dependency resolution, and 36 release-only sanitization paths kept on dev. The full per-file CSV and provenance audit are retained as session artifacts.
54f699f2v0.12.0 promotion (#1698)e19ba5a8v0.13.0 promotion47fcb79emerge #188956bcd043sync-skill-templates absent-source fixfefed28cmerge #189043cd92eaexpanded 0.13.0 changelog5e086cecmerge #1892dfe53679v1.0.0 promotion (#2154)5c662ba0external-repo publish auth (#2164)37b418ad1.0.1 preparation (#2166)2aabd8dfDavid Pine stable docs (#2173)c24da2aav1.1.0 promotion (#2241)test/acceptance/steps/cli-steps.tstest/agent-provenance.test.tstest/gh-aw-quality.test.tstest/ralph-reference-authority.test.tsdocs/src/content/docs/features/state-backends.md,docs/src/content/docs/get-started/installation.md.github/agents/squad.agent.md,.squad-templates/squad.agent.md,templates/squad.agent.md.template,packages/squad-cli/templates/squad.agent.md.template,packages/squad-sdk/templates/squad.agent.md.templatepackages/squad-sdk/src/agents/lifecycle.tsdocs/package-lock.json,samples/cost-aware-router/package-lock.json,samples/hello-squad/package-lock.jsonRelease metadata and consumption. Add
## [2.0.0] - 2026-11-18, summarize all four previews, preserve the detailed subsequent Claude Code work and all historical releases, and consume exactly 25 pending changeset fragments into that entry. Every fragment was read; additional plugin transition/streaming, watch permission, and harness-credential details were added before deletion. Original fragment bodies and their disposition are retained in a consumption artifact. These deletions are intentional: release policy rejects undrained fragments.The root's private workspace
file:link is intentionally unchanged. Neither publishable package manifest contains afile:,link:, orworkspace:dependency. Lock refresh also records the SDK's already-declared optional Claude SDK peer; it does not bump any dependency.Human release boundary. Maintainer docs now match the current exact-SHA workflow.
squad-release.ymlis manual-only, not main-push-triggered.squad-promote.ymlwithoutpromotion_branchpushes main and immediately dispatches all stable publication channels; the documented protected-main alternative opens a PR from an already-prepared sanitized branch. Only a human dispatches these workflows. The source coordinator's0.0.0-sourceplaceholder is intentional; installation stamps it dynamically.Release-verification repair. The initial Linux full suite passed, but exact-SHA evidence reconciliation rejected the one skipped member of the inherited, mutually exclusive live-registry assertions. Add a reviewed
env-gatedrule limited to those two exact assertion titles andskippedstatus. Both live-registry assertions and the fail-on-unexplained gate remain intact. Focused regression tests verify both checkout shapes and confirm unrelated skips and failed producer assertions still block release. Exact-SHA verification must pass again on the fix commit before merge.npx changeset add/.changeset/*.md, directCHANGELOG.mdentry for maintainers, orskip-changeloglabel for no user-facing changes)PR Readiness Checklist
Branch & Commit
dev(notmain)dev(git fetch upstream && git rebase upstream/dev)git diff --cached --stat)Build & Test
npm run buildpassesnpm testpasses (all tests green)npm run lintpasses (type check clean)npm run lint:eslintpassesValidation evidence:
$env:SKIP_BUILD_BUMP='1'; npm run buildnpm testin Linux/Node 22 CI67010797(run); the follow-up skip-accounting fix is rerun through required CI and exact-SHA verification before merge.npm test -- --reporter=default --reporter=json --outputFile.json=<session-artifacts>\vitest-results.jsonnpm run lintnpm run lint:eslintnode --test 'test/*.test.cjs'node --test docs\tests\astro-features.test.mjsnode scripts\build-claude-plugin.mjs --checknode scripts\release\policy-gates.mjs --mode=releasenode scripts\release\workspace-lockfile.mjs checknode scripts\release\pack-evidence.mjs --out <session-artifacts>\pack-evidence --expect-version 2.0.0 --expect-sdk-dep '>=2.0.0'node node_modules\vitest\vitest.mjs run test/retired-symbols.test.ts --reporter=dotnode node_modules\vitest\vitest.mjs run test/retired-symbols.test.ts test/claude-plugin.test.ts test/agent-provenance.test.ts test/ralph-reference-authority.test.ts --reporter=dotnode node_modules\markdownlint-cli2\markdownlint-cli2.mjs 'docs/src/content/docs/whatsnew.md' 'docs/src/content/docs/get-started/migration.md' 'docs/src/content/docs/scenarios/release-process.md'node node_modules\cspell\bin.mjs --no-progress --dot 'docs/src/content/docs/whatsnew.md' 'docs/src/content/docs/get-started/migration.md' 'docs/src/content/docs/scenarios/release-process.md'git diff --checknode node_modules\vitest\vitest.mjs run test\test-reconciliation.test.ts test\agent-provenance.test.ts --reporter=default --reporter=json --outputFile.json=<session-artifacts>\provenance-reconciliation-tests.jsonnode scripts\release\test-reconciliation.mjs --report <session-artifacts>\provenance-reconciliation-tests.json --out <session-artifacts>\provenance-reconciliation --fail-on-unexplainednode node_modules\eslint\bin\eslint.js scripts\release\test-reconciliation.mjs test\test-reconciliation.test.tsChangeset
npx changeset add(ifpackages/squad-sdk/src/orpackages/squad-cli/src/changed)CHANGELOG.mdentry (maintainers only — write-protected for external contributors)skip-changeloglabel applied (if no user-facing changes)Docs
No new feature is introduced by this preparation; generated plugin README and stable release, migration and maintainer docs are updated. The existing homepage design is unchanged apart from the stable version label.
Exports
N/A: no new modules or exports.
Breaking Changes
Squad 2 includes the previously documented major-release behavior changes. The 2.0.0 changelog and upgrading guide explain removed user-profile commands, canonical
/clientimports, experimental/backendopt-in, project-only resolution and earlier-first upstream precedence. This preparation introduces no additional API changes.Waivers
No CI, review, or branch-protection waiver requested. Preserve the real merge commit: do not squash or rebase-merge this PR, which would lose the repaired main ancestry. The maintainer explicitly approved the >20-file reconciliation. Only the 25 consumed changeset fragments are deleted; no product files are deleted. Teampilot-specific status/registry sync tooling does not apply to github/squad; Squad's actual template/plugin and documentation checks are used instead.