Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
@copilot Resolve conflicts |
…ogging-adxtrace-inspect-3db3ed33caa0db8d # Conflicts: # server/internal/adxtrace/dataset.go Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Contributor
Resolved the conflict with |
mnkiefer
deleted the
self-care/server-go-logging-adxtrace-inspect-3db3ed33caa0db8d
branch
November 7, 2026 07:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the ledger-counting logic of
adxtrace.Inspectinto a puresummarizeLedgerfunction and adds a debug log line for the inspection result. Behavior is unchanged.Action: Reviewer should confirm
summarizeLedgermatches the previous inline counting and thatgo -C server vet ./... && go -C server test ./...pass.Summary
server/internal/adxtrace/dataset.go(Inspect).cao:adxtracelog after a successful inspection, with only integer counts and a boolean (frames, eligible, gaps, pending, degraded). Disabled by default; no records, identifiers, paths or errors are logged.summarizeLedger, so freshness is testable.Tests and validation
summarize_test.go: empty ledger, delivered/undelivered records, gaps, fresh/stale/not-ready mining, mining-enabled checked-without-mining, and the exact freshness boundary. Real values only, no mocks.gofmtclean;go -C server vet ./...andgo -C server test ./...pass.Control Plane
41890067426-3333githubnext/gh-cao