[mnkiefer]

SQLite's local reader accepted keyset continuation pages whose key names differ from the resolved page plan. PostgreSQL rejects them as stale. This patch makes SQLite reject them too, and adds a shared conformance case that covers both backends.

Action: Dashboard server maintainer should review the change and accept it if TestReadContract passes for both PostgreSQL and SQLite. The fix is proposed only; it is not deployed or accepted.

Finding

• Principle: interchangeable implementations (Calesi check 4).
• Frozen SHA: 83f12ba71108396f1b752fe01e64a5e15c4b20fb.
• Contract: server/internal/dashboardstore/store.go, KeysetPage and Reader.
• Consumer: server/internal/server/server.go:1780-1805 builds the KeysetPage.
• PostgreSQL adapter: server/internal/postgresx/sql_plan.go:58-79 checks the boundary, comparator, key count and each key name.
• SQLite adapter: server/internal/sqlitex/query.go:50-60 checked only the boundary and comparator.
• Impact: a continuation with swapped or wrong keys was accepted by SQLite but rejected by PostgreSQL.
• Counter-evidence: server.go validates the cursor before calling the store. A direct Reader caller still saw the divergence.
• Intentional limitations preserved: SQLite still rejects resource-limit overrides and repository scoping explicitly.

Validation

• Before the fix, with the new conformance case: TestReadContract/sqlite/keyset-continuation-keys failed with "mismatched continuation keys were accepted".
• After the fix, go test -race ./internal/dashboardstore ./internal/sqlitex passed against an isolated local PostgreSQL 18.
• go vet ./..., gofmt, golangci-lint fmt --diff, golangci-lint run on the touched packages, and git diff --check were clean.
• ./internal/server has failures that predate this change. TestWorkflowListContractUsesPostgres fails identically on the unchanged baseline with a missing runs partition. The role-privilege tests need a numeric-loopback admin, which my Unix-socket local database did not provide. I did not run the full ./... suite.
• golangci-lint run ./... was run only on the two touched packages, not the whole module.

Control Plane

• Correlation ID: 42311677914-3489
• Central repository: githubnext/gh-cao
• Control plane run: https://github.com/githubnext/gh-cao/actions/runs/42311677914

cao: githubnext/gh-cao, correlation: 42311677914-3489

gh-aw-workflow-id: self-care-calesi-design-principles

Generated by SelfCare / Calesi Principles · copilot · auto · ~66 AIC · ⌖ ~1 AIC · ⊞ 16.1K · ◷

• expires on Nov 13, 2026, 11:49 PM UTC