Repository navigation
[self-care:server-go-logging] Extract token broker policy parsing with diagnostic logging - #20348
Merged
mnkiefer merged 1 commit intoNov 7, 2026
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mnkiefer
marked this pull request as ready for review
November 7, 2026 14:54
mnkiefer
deleted the
self-care/server-go-logging-tokenbroker-policy-19d0662ce7e04527
branch
November 7, 2026 14:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits
tokenbroker.Service.authorizedinto three testable units (readPolicyFile,parseWorkflowRules,ruleAllows) with unchanged fail-closed behavior, and addscao:tokenbrokerdebug logging for policy denials.Action: Reviewer should confirm the refactor preserves authorization semantics; acceptance check is passing
go -C server vet ./...andgo -C server test ./....Diagnostic value and privacy
Up to three disabled-by-default log calls, one per denial reason (
unreadable,invalid_policy,no_matching_rulewith a rule count). No identities, refs, SHAs, paths, policy contents or error text are logged, and control flow is unchanged.Tests
New
policy_rules_test.gouses real values and temp files, no mocks:Validation
gofmt,go -C server vet ./...andgo -C server test ./...all pass. Diff scanned: no secrets.Control Plane
42352488609-3513githubnext/gh-cao